From patchwork Fri Jun 14 12:41:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 804593 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B36A719A2A8 for ; Fri, 14 Jun 2024 12:41:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718368905; cv=none; b=V7GR3YRhSNvbZXyMyR5jNRSA5fhQ6yLCMCxJ9DFriX9FGzawmt2ISqgvmJLm9AMRFjN1PcFMp4gRbq9SurcQiIwTWCUHBpaXhSdaUgwdODFnA9rFAmlfKOtEKlxvqkhKo07fS/xAv0yy+HWFNyO1Oq8oJ1X4YwT3jTIVLceCJc4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718368905; c=relaxed/simple; bh=OVCh0xiNtbKDo7jHdOZaakUb3rirDOQ3yptayCuHr+8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jmzkQywzY7rMqulqsQdrlOYeluJgb8XzwoRPcyaQ72Jr1SLcJyXpNUWvqV2WzRg+Hfj9CFbk4ZoEHVfvj5roaV6nnU29HbK9Jx5+hB85KBpxDdD8S+/Z7/DQ+zDefarpm6s8N0YVkazZI6opyhGeglbpMBfC7JmxMXtRo8rTMqE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=T50MrKNc; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="T50MrKNc" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-6afbf9c9bc0so12799656d6.3 for ; Fri, 14 Jun 2024 05:41:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1718368902; x=1718973702; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BmhzD6drL+dqelhUuMiG4rDosl5mRy0mIhnFlZNZ6YM=; b=T50MrKNcSLj0hGcRihRrH9Ok907alJUsFeoP952I+XrOArHlgHCBxDMpxYrgOhnyKx UYBDGXgF+vp2hfBV0dfglqZyuXdDqC81EBkJIcnimrEuAUHNpH1kVbKdJbHCmgl2JHvP 0Iwz/KJ9ISkMpnaRr3Zac+SuTyDF1J7SIT7y0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718368902; x=1718973702; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BmhzD6drL+dqelhUuMiG4rDosl5mRy0mIhnFlZNZ6YM=; b=fxaNyvFEZxlGSOpOrIb7AAidnRix3U2LMLRnSJKQRR71s+Zv4bnvBKhedqloG9TlxU Vnz/A6FNcsBe6P/MPs4nC6pT2kzQIzq2Azujs0K8z3RAkaGEO4TJ2xUQ/PekRw8Pq8D7 vT3pz4jk/Vspf6/aiQLrrNsdyWVrpehXu5KDBjkQunEEuARDLU4AsDIuSghxiABCGrDk VWeYqI1VLlwJqOF46680d0e9nj0Y6O43o2s6x/Ezd6JK/Nbw6HuWWMHhj+r1xxS3xM+7 zHIyizY6vHyREPn/ExI4pvLfw0UVa0pZ0ud+v0RLG4KaKtEnKIoKMQ1LP04IRNEvCq3o vRNA== X-Forwarded-Encrypted: i=1; AJvYcCXl6lMBEDEtyxvETdYc8RbVOHFw/W2t4w+j603gKUzX+LsYQpE4T09mNJg4XStLuqrrsmt1OucYsgs3DB1rK6u9ZhlTpyuiWqek0sc= X-Gm-Message-State: AOJu0YzDJRC18jRrM4V37AbOmZHtRrk0XC/YPdpJinz2d/aosjg5xIBl 9HlHvihuMxWWyJY6UhBDgyjQYiiAhx4+VgLm4WfUokzu2d+IH2RXK5XHjUA5aA== X-Google-Smtp-Source: AGHT+IEhkccRGU/pAfXr2wII9wTmtO39p/PGCYtDnTWQ8tgsir/ZFOzyqT7qIyMxanAIk0Mr5KL2DQ== X-Received: by 2002:a05:6214:4b85:b0:6b0:76f1:8639 with SMTP id 6a1803df08f44-6b2afd5a04amr24760176d6.42.1718368902656; Fri, 14 Jun 2024 05:41:42 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b2a5c202e8sm17734056d6.50.2024.06.14.05.41.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 05:41:41 -0700 (PDT) From: Ricardo Ribalda Date: Fri, 14 Jun 2024 12:41:30 +0000 Subject: [PATCH v6 4/4] media: uvcvideo: Exit early if there is not int_urb Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240614-guenter-mini-v6-4-7b7fdc3b21b3@chromium.org> References: <20240614-guenter-mini-v6-0-7b7fdc3b21b3@chromium.org> In-Reply-To: <20240614-guenter-mini-v6-0-7b7fdc3b21b3@chromium.org> To: Mauro Carvalho Chehab Cc: Guenter Roeck , Tomasz Figa , Laurent Pinchart , Alan Stern , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Paul , Ricardo Ribalda , Sakari Ailus , Sergey Senozhatsky X-Mailer: b4 0.13.0 If there is no int_urb there is no need to do a clean stop. Also we avoid calling usb_kill_urb(NULL). It is properly handled by the usb framework, but it is not polite. Now that we are at it, fix the code style in uvc_status_start() for consistency. Reviewed-by: Sergey Senozhatsky Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_status.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_status.c b/drivers/media/usb/uvc/uvc_status.c index 8fd8250110e2..9108522beea6 100644 --- a/drivers/media/usb/uvc/uvc_status.c +++ b/drivers/media/usb/uvc/uvc_status.c @@ -308,7 +308,7 @@ static int __uvc_status_start(struct uvc_device *dev, gfp_t flags) { lockdep_assert_held(&dev->status_lock); - if (dev->int_urb == NULL) + if (!dev->int_urb) return 0; return usb_submit_urb(dev->int_urb, flags); @@ -320,6 +320,9 @@ static void __uvc_status_stop(struct uvc_device *dev) lockdep_assert_held(&dev->status_lock); + if (!dev->int_urb) + return; + /* * Prevent the asynchronous control handler from requeing the URB. The * barrier is needed so the flush_status change is visible to other