| Message ID | 20210623095734.3046-1-wsa+renesas@sang-engineering.com |
|---|---|
| Headers | show |
| Series | mmc: use proper DMAENGINE API for termination | expand |
On Wed, Jun 23, 2021 at 11:58 AM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > dmaengine_terminate_all() is deprecated in favor of explicitly saying if > it should be sync or async. Here, we want dmaengine_terminate_sync() > because there is no other synchronization code in the driver to handle > an async case. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Looks OK, as this driver uses a threaded irq handler. Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Have you tried triggering DMA termination, with lockdep enabled? Gr{oetje,eeting}s, Geert
On Wed, 23 Jun 2021 at 11:57, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > dmaengine_terminate_all() is deprecated in favor of explicitly saying if > it should be sync or async. Update the drivers I audited. > > > Wolfram Sang (3): > mmc: renesas_sdhi_sys_dmac: : use proper DMAENGINE API for termination > mmc: sh_mmcif: : use proper DMAENGINE API for termination > mmc: usdhi6rol0: : use proper DMAENGINE API for termination > > drivers/mmc/host/renesas_sdhi_sys_dmac.c | 4 ++-- > drivers/mmc/host/sh_mmcif.c | 4 ++-- > drivers/mmc/host/usdhi6rol0.c | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > Queued up for v5.15 (temporary on the devel branch), thanks! Kind regards Uffe