Message ID | 20230531111518.396868-4-victorshihgli@gmail.com |
---|---|
State | New |
Headers | show |
Series | Add Genesys Logic GL9767 support | expand |
On 31/05/23 14:15, Victor Shih wrote: > From: Victor Shih <victor.shih@genesyslogic.com.tw> > > Add new definition for VDD2 - UHS2 or PCIe/NVMe. > > Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw> > Signed-off-by: Victor Shih <victor.shih@genesyslogic.com.tw> > --- > drivers/mmc/host/sdhci.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h > index f4f2085c274c..140a0c20d4f2 100644 > --- a/drivers/mmc/host/sdhci.h > +++ b/drivers/mmc/host/sdhci.h > @@ -100,6 +100,14 @@ > #define SDHCI_POWER_300 0x0C > #define SDHCI_POWER_330 0x0E > > +/* > + * VDD2 - UHS2 or PCIe/NVMe > + * VDD2 power on/off and voltage select > + */ > +#define SDHCI_VDD2_POWER_ON 0x10 > +#define SDHCI_VDD2_POWER_120 0x80 > +#define SDHCI_VDD2_POWER_180 0xA0 They should really align with SDHCI_POWER_330 etc above as they are all from SDHCI_POWER_CONTROL > + > #define SDHCI_BLOCK_GAP_CONTROL 0x2A > > #define SDHCI_WAKE_UP_CONTROL 0x2B
Hi, Adrian On Wed, May 31, 2023 at 9:27 PM Adrian Hunter <adrian.hunter@intel.com> wrote: > > On 31/05/23 14:15, Victor Shih wrote: > > From: Victor Shih <victor.shih@genesyslogic.com.tw> > > > > Add new definition for VDD2 - UHS2 or PCIe/NVMe. > > > > Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw> > > Signed-off-by: Victor Shih <victor.shih@genesyslogic.com.tw> > > --- > > drivers/mmc/host/sdhci.h | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h > > index f4f2085c274c..140a0c20d4f2 100644 > > --- a/drivers/mmc/host/sdhci.h > > +++ b/drivers/mmc/host/sdhci.h > > @@ -100,6 +100,14 @@ > > #define SDHCI_POWER_300 0x0C > > #define SDHCI_POWER_330 0x0E > > > > +/* > > + * VDD2 - UHS2 or PCIe/NVMe > > + * VDD2 power on/off and voltage select > > + */ > > +#define SDHCI_VDD2_POWER_ON 0x10 > > +#define SDHCI_VDD2_POWER_120 0x80 > > +#define SDHCI_VDD2_POWER_180 0xA0 > > They should really align with SDHCI_POWER_330 etc > above as they are all from SDHCI_POWER_CONTROL > I will update it in patch v5. > > + > > #define SDHCI_BLOCK_GAP_CONTROL 0x2A > > > > #define SDHCI_WAKE_UP_CONTROL 0x2B > Thanks, Victor Shih
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h index f4f2085c274c..140a0c20d4f2 100644 --- a/drivers/mmc/host/sdhci.h +++ b/drivers/mmc/host/sdhci.h @@ -100,6 +100,14 @@ #define SDHCI_POWER_300 0x0C #define SDHCI_POWER_330 0x0E +/* + * VDD2 - UHS2 or PCIe/NVMe + * VDD2 power on/off and voltage select + */ +#define SDHCI_VDD2_POWER_ON 0x10 +#define SDHCI_VDD2_POWER_120 0x80 +#define SDHCI_VDD2_POWER_180 0xA0 + #define SDHCI_BLOCK_GAP_CONTROL 0x2A #define SDHCI_WAKE_UP_CONTROL 0x2B