| Message ID | 20231122053817.3401748-13-quic_gaurkash@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Hardware wrapped key support for qcom ice and ufs | expand |
On 22/11/2023 06:38, Gaurav Kashyap wrote: > Add documentation for the ice-use-hwkm property in > qcom ice. > > Signed-off-by: Gaurav Kashyap <quic_gaurkash@quicinc.com> Another day, another same comments: https://lore.kernel.org/all/6e435e84-fea9-4f74-8977-d589cbc31ded@kernel.org/ Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Please kindly resend and include all necessary To/Cc entries. Best regards, Krzysztof
On Tue, Nov 21, 2023 at 09:38:17PM -0800, Gaurav Kashyap wrote: > Add documentation for the ice-use-hwkm property in > qcom ice. Please describe the problem that you're solving by adding this property to the binding (the description of hardware/firmware). > > Signed-off-by: Gaurav Kashyap <quic_gaurkash@quicinc.com> > --- > .../bindings/crypto/qcom,inline-crypto-engine.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml > index ca4f7d1cefaa..93e017dddc9d 100644 > --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml > +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml > @@ -24,6 +24,13 @@ properties: > clocks: > maxItems: 1 > > + qcom,ice-use-hwkm: > + type: boolean > + description: > + Use the supported Hardware Key Manager (HWKM) in Qualcomm > + ICE to support wrapped keys. This dictates if wrapped keys > + have to be used by ICE. As described it sounds like software configuration, rather than a description of the capabilities of the hardware/firmware. In what cases would we, and would we not, specify this property? Regards, Bjorn > + > required: > - compatible > - reg > -- > 2.25.1 > >
diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml index ca4f7d1cefaa..93e017dddc9d 100644 --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml @@ -24,6 +24,13 @@ properties: clocks: maxItems: 1 + qcom,ice-use-hwkm: + type: boolean + description: + Use the supported Hardware Key Manager (HWKM) in Qualcomm + ICE to support wrapped keys. This dictates if wrapped keys + have to be used by ICE. + required: - compatible - reg
Add documentation for the ice-use-hwkm property in qcom ice. Signed-off-by: Gaurav Kashyap <quic_gaurkash@quicinc.com> --- .../bindings/crypto/qcom,inline-crypto-engine.yaml | 7 +++++++ 1 file changed, 7 insertions(+)