From patchwork Tue Feb 12 07:13:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 158117 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3509991jaa; Mon, 11 Feb 2019 23:14:20 -0800 (PST) X-Google-Smtp-Source: AHgI3IZ9xov2mJTJjNcAciFodRc0p/l69TgDwGD3hFHt7bEACYavGniTMW6gluLvMdjHwlprACc4 X-Received: by 2002:a65:6116:: with SMTP id z22mr2284968pgu.265.1549955660630; Mon, 11 Feb 2019 23:14:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549955660; cv=none; d=google.com; s=arc-20160816; b=iSQ85g9IhNZ12S1hQhQ6waZ4PlOd7rF2zx6n9MMz8ciFuGiy93WwKujOBnAEoLIi6x j3SZG4X5Cv/64Jq//J15kvDbPH8coLlMnwKOiD8P/JKAVZ8BbOZOxu8J4X1uSy1nm/WS p3JvXvJDSOjUIrsQIaSQDJbFNQwPxSBIpCevZGpcssRJesjCgtVpZ3T6fsaF1nQcCyE9 eEw+SFORJIqKB2q5y/hYBIHlm4imehaPl+CSeCeb/WC0133x9Tg8crUpTPNzxN2jW15q zMWngcDqto+TR+yLRSW2Z3hR++i5+SioBtVuduXRdHfeAjDUV67uEneelfGcn/zM+UHu X9Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:references:in-reply-to:message-id:date:subject :to:from:dkim-signature:dkim-filter:dkim-signature; bh=UJy+pSH1v7wytLhdgbswF1GVmhCNwLIBOxng2R63Rzo=; b=An6ci5PJRiSnY9O914w8ovdOLQsy2fXyqcQm4hcfiut0PKANUzpZGxvT9zUHhiuSAv ZuMY9uEIg66Q8xJfLzVLypZkzN2+cP5yATqajVn0I/I3cMOMoVTeHceDBM5p6LNkMSQe 0eOhD2toVP2bFg0ksz5ioGXyP5wJz13yOITNL05Ei09LWhyRbcLjbjC5Fw+Q87Q8gXmo Z6VDd4+MIDvxADVYJSkLcnoSfsdmIOAl221nA7hpnU7UcGlROGiGKB6Jq2Mp7XpvH/Fq zet/tMgNMKOsspm3JezTkAD5b+Uumt6llgloYq59PpVme0Gq9Tf1C9vTZ5FVQ2Tjam59 g8uA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b=GQb3iCGd; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b="I0/FSzXM"; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id t74si11304693pgc.150.2019.02.11.23.14.20 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Feb 2019 23:14:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b=GQb3iCGd; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b="I0/FSzXM"; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=UJy+pSH1v7wytLhdgbswF1GVmhCNwLIBOxng2R63Rzo=; b=GQb3iCGdoYs+MjcT7L3o3duLup b4/9+GQp4TJ3Rn48lNsggHlhIuyJhyXaFPbbbL/CiFxaec9Mki5+EZOXfH6jRnC1uS/um6OON12hn /dzUgm8pSJFWDdb9xm3nIctr1Fe4I6NzUF5NEMj9XzOz6QpV6PEhaJ92gugTrymzhR5hEukOzsCeZ BDxpYf61c3Z1e3Ob0JsilWoFhSksJDjEu/PKMnBdH9I5Jd0Bm7f8rt8l2I6om6g8T4OEZncBR+8QL 6trI0azp3KiCOMxKDGEEZiiojxDiTxp+Rw5BgslA5f7UMBVmc83WpHb1M3KJra/VIefCtT3sz19EO yP45CYDQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtSGj-0003hJ-9G; Tue, 12 Feb 2019 07:14:13 +0000 Received: from conuserg-09.nifty.com ([210.131.2.76]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtSGM-0003J3-M7 for linux-mtd@lists.infradead.org; Tue, 12 Feb 2019 07:13:53 +0000 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-09.nifty.com with ESMTP id x1C7DPdX019269; Tue, 12 Feb 2019 16:13:33 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-09.nifty.com x1C7DPdX019269 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1549955614; bh=W7SE5qbwsV5rwyJe9i+cPWUmbUQD+IWEIEw4oDfctm8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I0/FSzXMmmwcZRVqdoNJocDfNuGW9hQQjoC9s67boSMYKaZXGnuTQMmtkks+QGOvG COzcdy5n0w2A+KXCxcLENXdh4eSzaUHZifq9S5C9Z8jX37lId3SxHqu8bBkS3L9Fnu EGHsCx4235f57Nr1bmSnt4uJ67uG02O/ZJU6A0hwPIWeROwjfeX14bm+lIl/B1bknB I8Zdqi6OES0gsiXGJaR7IwokTvdKEt/WeEZeVqDmEwYMtBufDdfSlusM0EHj+54I8i X2x8fw1RArjB+LSLPBeL25NGBdn00cD1/siDJmQ+qhBhYt4uUAeo13BhaskQWDSmUg Nd9VjJXCqAo9w== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-mtd@lists.infradead.org, Miquel Raynal Subject: [PATCH v2 09/10] mtd: rawnand: denali: remove DENALI_NR_BANKS macro Date: Tue, 12 Feb 2019 16:13:01 +0900 Message-Id: <1549955582-30346-10-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1549955582-30346-1-git-send-email-yamada.masahiro@socionext.com> References: <1549955582-30346-1-git-send-email-yamada.masahiro@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190211_231351_548218_34972801 X-CRM114-Status: GOOD ( 10.55 ) X-Spam-Score: 1.0 (+) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (1.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [210.131.2.76 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Masahiro Yamada , Richard Weinberger , Boris Brezillon , linux-kernel@vger.kernel.org, Marek Vasut , Brian Norris , David Woodhouse MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org Use the runtime-detected denali->nbanks instead of hard-coded DENALI_NR_BANKS (=4). The actual number of banks depends on the IP configuration, and can be less than DENALI_NR_BANKS. It is pointless to touch registers of unsupported banks. Signed-off-by: Masahiro Yamada --- Changes in v2: None drivers/mtd/nand/raw/denali.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) -- 2.7.4 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/drivers/mtd/nand/raw/denali.c b/drivers/mtd/nand/raw/denali.c index a162bd1..eb58136 100644 --- a/drivers/mtd/nand/raw/denali.c +++ b/drivers/mtd/nand/raw/denali.c @@ -40,7 +40,6 @@ #define DENALI_BANK(denali) ((denali)->active_bank << 24) #define DENALI_INVALID_BANK -1 -#define DENALI_NR_BANKS 4 static struct denali_chip *to_denali_chip(struct nand_chip *chip) { @@ -92,7 +91,7 @@ static void denali_enable_irq(struct denali_controller *denali) { int i; - for (i = 0; i < DENALI_NR_BANKS; i++) + for (i = 0; i < denali->nbanks; i++) iowrite32(U32_MAX, denali->reg + INTR_EN(i)); iowrite32(GLOBAL_INT_EN_FLAG, denali->reg + GLOBAL_INT_ENABLE); } @@ -101,7 +100,7 @@ static void denali_disable_irq(struct denali_controller *denali) { int i; - for (i = 0; i < DENALI_NR_BANKS; i++) + for (i = 0; i < denali->nbanks; i++) iowrite32(0, denali->reg + INTR_EN(i)); iowrite32(0, denali->reg + GLOBAL_INT_ENABLE); } @@ -117,7 +116,7 @@ static void denali_clear_irq_all(struct denali_controller *denali) { int i; - for (i = 0; i < DENALI_NR_BANKS; i++) + for (i = 0; i < denali->nbanks; i++) denali_clear_irq(denali, i, U32_MAX); } @@ -130,7 +129,7 @@ static irqreturn_t denali_isr(int irq, void *dev_id) spin_lock(&denali->irq_lock); - for (i = 0; i < DENALI_NR_BANKS; i++) { + for (i = 0; i < denali->nbanks; i++) { irq_status = ioread32(denali->reg + INTR_STATUS(i)); if (irq_status) ret = IRQ_HANDLED;