mbox series

[0/5] drop unused BACKLIGHT_GENERIC option

Message ID 20201130152137.24909-1-andrey.zhizhikin@leica-geosystems.com
Headers show
Series drop unused BACKLIGHT_GENERIC option | expand

Message

Andrey Zhizhikin Nov. 30, 2020, 3:21 p.m. UTC
Since the removal of generic_bl driver from the source tree in commit
7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it is
unused") BACKLIGHT_GENERIC config option became obsolete as well and
therefore subject to clean-up from all configuration files.

This series introduces patches to address this removal, separated by
architectures in the kernel tree.

Andrey Zhizhikin (5):
  ARM: configs: drop unused BACKLIGHT_GENERIC option
  arm64: defconfig: drop unused BACKLIGHT_GENERIC option
  MIPS: configs: drop unused BACKLIGHT_GENERIC option
  parisc: configs: drop unused BACKLIGHT_GENERIC option
  powerpc/configs: drop unused BACKLIGHT_GENERIC option

 arch/arm/configs/at91_dt_defconfig          | 1 -
 arch/arm/configs/cm_x300_defconfig          | 1 -
 arch/arm/configs/colibri_pxa300_defconfig   | 1 -
 arch/arm/configs/jornada720_defconfig       | 1 -
 arch/arm/configs/magician_defconfig         | 1 -
 arch/arm/configs/mini2440_defconfig         | 1 -
 arch/arm/configs/omap2plus_defconfig        | 1 -
 arch/arm/configs/pxa3xx_defconfig           | 1 -
 arch/arm/configs/qcom_defconfig             | 1 -
 arch/arm/configs/sama5_defconfig            | 1 -
 arch/arm/configs/sunxi_defconfig            | 1 -
 arch/arm/configs/tegra_defconfig            | 1 -
 arch/arm/configs/u8500_defconfig            | 1 -
 arch/arm64/configs/defconfig                | 1 -
 arch/mips/configs/gcw0_defconfig            | 1 -
 arch/mips/configs/gpr_defconfig             | 1 -
 arch/mips/configs/lemote2f_defconfig        | 1 -
 arch/mips/configs/loongson3_defconfig       | 1 -
 arch/mips/configs/mtx1_defconfig            | 1 -
 arch/mips/configs/rs90_defconfig            | 1 -
 arch/parisc/configs/generic-64bit_defconfig | 1 -
 arch/powerpc/configs/powernv_defconfig      | 1 -
 22 files changed, 22 deletions(-)


base-commit: b65054597872ce3aefbc6a666385eabdf9e288da
prerequisite-patch-id: bfd382cf1dc021d20204f10ea9403319c1c32b12
prerequisite-patch-id: 5397c0c8648bb3e0b830207ea867138c11c6e644
prerequisite-patch-id: a3c284dff5fe6d02828918a886db6a8ed3197e20

Comments

Krzysztof Kozlowski Nov. 30, 2020, 6:52 p.m. UTC | #1
On Mon, Nov 30, 2020 at 03:21:33PM +0000, Andrey Zhizhikin wrote:
> Commit 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it is
> unused") removed geenric_bl driver from the tree, together with
> corresponding config option.
> 
> Remove BACKLIGHT_GENERIC config item from all ARM configurations.
> 
> Fixes: 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it is unused")
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> ---
>  arch/arm/configs/at91_dt_defconfig        | 1 -
>  arch/arm/configs/cm_x300_defconfig        | 1 -
>  arch/arm/configs/colibri_pxa300_defconfig | 1 -
>  arch/arm/configs/jornada720_defconfig     | 1 -
>  arch/arm/configs/magician_defconfig       | 1 -
>  arch/arm/configs/mini2440_defconfig       | 1 -
>  arch/arm/configs/omap2plus_defconfig      | 1 -
>  arch/arm/configs/pxa3xx_defconfig         | 1 -
>  arch/arm/configs/qcom_defconfig           | 1 -
>  arch/arm/configs/sama5_defconfig          | 1 -
>  arch/arm/configs/sunxi_defconfig          | 1 -
>  arch/arm/configs/tegra_defconfig          | 1 -
>  arch/arm/configs/u8500_defconfig          | 1 -
>  13 files changed, 13 deletions(-)

You need to send it to arm-soc maintainers, otherwise no one might feel
responsible enough to pick it up.
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

+CC Arnd and Olof,

Dear Arnd and Olof,

Maybe it is worth to add arm-soc entry to the MAINTAINERS file?
Otherwise how one could get your email address? Not mentioning the
secret-soc address. :)

Best regards,
Krzysztof
Krzysztof Kozlowski Nov. 30, 2020, 6:53 p.m. UTC | #2
On Mon, Nov 30, 2020 at 03:21:37PM +0000, Andrey Zhizhikin wrote:
> Commit 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it is
> unused") removed geenric_bl driver from the tree, together with
> corresponding config option.
> 
> Remove BACKLIGHT_GENERIC config item from generic-64bit_defconfig.
> 
> Fixes: 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it is unused")
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> ---
>  arch/powerpc/configs/powernv_defconfig | 1 -
>  1 file changed, 1 deletion(-)
> 

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof
Andrey Zhizhikin Nov. 30, 2020, 7:50 p.m. UTC | #3
Hello Krzysztof,

> -----Original Message-----

> From: Krzysztof Kozlowski <krzk@kernel.org>

> Sent: Monday, November 30, 2020 7:52 PM

> To: ZHIZHIKIN Andrey <andrey.zhizhikin@leica-geosystems.com>

> Cc: linux@armlinux.org.uk; nicolas.ferre@microchip.com;

> alexandre.belloni@bootlin.com; ludovic.desroches@microchip.com;

> tony@atomide.com; mripard@kernel.org; wens@csie.org;

> jernej.skrabec@siol.net; thierry.reding@gmail.com; jonathanh@nvidia.com;

> catalin.marinas@arm.com; will@kernel.org; tsbogend@alpha.franken.de;

> James.Bottomley@HansenPartnership.com; deller@gmx.de;

> mpe@ellerman.id.au; benh@kernel.crashing.org; paulus@samba.org;

> lee.jones@linaro.org; sam@ravnborg.org; emil.l.velikov@gmail.com;

> daniel.thompson@linaro.org; linux-arm-kernel@lists.infradead.org; linux-

> kernel@vger.kernel.org; linux-omap@vger.kernel.org; linux-

> tegra@vger.kernel.org; linux-mips@vger.kernel.org; linux-

> parisc@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Arnd Bergmann

> <arnd@arndb.de>; Olof Johansson <olof@lixom.net>

> Subject: Re: [PATCH 1/5] ARM: configs: drop unused BACKLIGHT_GENERIC

> option

> 

> This email is not from Hexagon’s Office 365 instance. Please be careful while

> clicking links, opening attachments, or replying to this email.

> 

> 

> On Mon, Nov 30, 2020 at 03:21:33PM +0000, Andrey Zhizhikin wrote:

> > Commit 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it

> > is

> > unused") removed geenric_bl driver from the tree, together with

> > corresponding config option.

> >

> > Remove BACKLIGHT_GENERIC config item from all ARM configurations.

> >

> > Fixes: 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it

> > is unused")

> > Cc: Sam Ravnborg <sam@ravnborg.org>

> > Signed-off-by: Andrey Zhizhikin

> > <andrey.zhizhikin@leica-geosystems.com>

> > ---

> >  arch/arm/configs/at91_dt_defconfig        | 1 -

> >  arch/arm/configs/cm_x300_defconfig        | 1 -

> >  arch/arm/configs/colibri_pxa300_defconfig | 1 -

> >  arch/arm/configs/jornada720_defconfig     | 1 -

> >  arch/arm/configs/magician_defconfig       | 1 -

> >  arch/arm/configs/mini2440_defconfig       | 1 -

> >  arch/arm/configs/omap2plus_defconfig      | 1 -

> >  arch/arm/configs/pxa3xx_defconfig         | 1 -

> >  arch/arm/configs/qcom_defconfig           | 1 -

> >  arch/arm/configs/sama5_defconfig          | 1 -

> >  arch/arm/configs/sunxi_defconfig          | 1 -

> >  arch/arm/configs/tegra_defconfig          | 1 -

> >  arch/arm/configs/u8500_defconfig          | 1 -

> >  13 files changed, 13 deletions(-)

> 

> You need to send it to arm-soc maintainers, otherwise no one might feel

> responsible enough to pick it up.


Good point, thanks a lot!

I was not aware of the fact that there is a separate ML that should receive patches targeted ARM SOCs. Can you (or anyone else) please share it, so I can re-send it there as well?

> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

> 

> +CC Arnd and Olof,

> 

> Dear Arnd and Olof,

> 

> Maybe it is worth to add arm-soc entry to the MAINTAINERS file?

> Otherwise how one could get your email address? Not mentioning the

> secret-soc address. :)


"scripts/get_maintainer.pl --no-git-fallback --no-multiline --no-rolestats --no-n --separator , " across entire series gave only the list of addresses that I've included in the series itself. If I would be given a arm-soc mailing list as output of the script - I would've included it as well.

> 

> Best regards,

> Krzysztof


Regards,
Andrey
Krzysztof Kozlowski Nov. 30, 2020, 8:25 p.m. UTC | #4
On Mon, Nov 30, 2020 at 08:11:33PM +0100, Sam Ravnborg wrote:
> On Mon, Nov 30, 2020 at 03:21:32PM +0000, Andrey Zhizhikin wrote:
> > Since the removal of generic_bl driver from the source tree in commit
> > 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it is
> > unused") BACKLIGHT_GENERIC config option became obsolete as well and
> > therefore subject to clean-up from all configuration files.
> > 
> > This series introduces patches to address this removal, separated by
> > architectures in the kernel tree.
> > 
> > Andrey Zhizhikin (5):
> >   ARM: configs: drop unused BACKLIGHT_GENERIC option
> >   arm64: defconfig: drop unused BACKLIGHT_GENERIC option
> >   MIPS: configs: drop unused BACKLIGHT_GENERIC option
> >   parisc: configs: drop unused BACKLIGHT_GENERIC option
> >   powerpc/configs: drop unused BACKLIGHT_GENERIC option
> 
> For defconfigs I expect arch maintainers to do a make xxxdefconfig / make
> savedefconfig / cp defconfig ... run now and then - this will remove
> all such symbols.

savedefconfig can be tricky because of risk of loosing options:
1. it will remove options which became the default or became selected,
2. later when the default is changed or selecting option is removed, the
   first option from #1 will not be brought back.

This was already for example with DEBUG_FS and the conclusion that time
was - do not run savedefconfig automatically.

Therefore if some symbol(s) can be safely removed, patch is welcomed.

Best regards,
Krzysztof

> 
> If the patches goes in like they are submitted then:
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
Michael Ellerman Dec. 1, 2020, 12:46 a.m. UTC | #5
Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com> writes:
> Commit 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it is

> unused") removed geenric_bl driver from the tree, together with

> corresponding config option.

>

> Remove BACKLIGHT_GENERIC config item from generic-64bit_defconfig.

                                            ^
                                            powernv_defconfig

> Fixes: 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it is unused")

> Cc: Sam Ravnborg <sam@ravnborg.org>

> Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>

> ---

>  arch/powerpc/configs/powernv_defconfig | 1 -

>  1 file changed, 1 deletion(-)


Acked-by: Michael Ellerman <mpe@ellerman.id.au>


cheers

> diff --git a/arch/powerpc/configs/powernv_defconfig b/arch/powerpc/configs/powernv_defconfig

> index cf30fc24413b..60a30fffeda0 100644

> --- a/arch/powerpc/configs/powernv_defconfig

> +++ b/arch/powerpc/configs/powernv_defconfig

> @@ -208,7 +208,6 @@ CONFIG_FB_MATROX_G=y

>  CONFIG_FB_RADEON=m

>  CONFIG_FB_IBM_GXT4500=m

>  CONFIG_LCD_PLATFORM=m

> -CONFIG_BACKLIGHT_GENERIC=m

>  # CONFIG_VGA_CONSOLE is not set

>  CONFIG_LOGO=y

>  CONFIG_HID_A4TECH=m

> -- 

> 2.17.1
Daniel Thompson Dec. 1, 2020, 10:05 a.m. UTC | #6
On Mon, Nov 30, 2020 at 03:21:32PM +0000, Andrey Zhizhikin wrote:
> Since the removal of generic_bl driver from the source tree in commit

> 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it is

> unused") BACKLIGHT_GENERIC config option became obsolete as well and

> therefore subject to clean-up from all configuration files.

> 

> This series introduces patches to address this removal, separated by

> architectures in the kernel tree.

> 

> Andrey Zhizhikin (5):

>   ARM: configs: drop unused BACKLIGHT_GENERIC option

>   arm64: defconfig: drop unused BACKLIGHT_GENERIC option

>   MIPS: configs: drop unused BACKLIGHT_GENERIC option

>   parisc: configs: drop unused BACKLIGHT_GENERIC option

>   powerpc/configs: drop unused BACKLIGHT_GENERIC option


Whole series:
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>



Daniel.
Catalin Marinas Dec. 1, 2020, 2:40 p.m. UTC | #7
On Mon, Nov 30, 2020 at 07:50:25PM +0000, ZHIZHIKIN Andrey wrote:
> From Krzysztof Kozlowski <krzk@kernel.org>:

> > On Mon, Nov 30, 2020 at 03:21:33PM +0000, Andrey Zhizhikin wrote:

> > > Commit 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it is

> > > unused") removed geenric_bl driver from the tree, together with

> > > corresponding config option.

> > >

> > > Remove BACKLIGHT_GENERIC config item from all ARM configurations.

> > >

> > > Fixes: 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it

> > > is unused")

> > > Cc: Sam Ravnborg <sam@ravnborg.org>

> > > Signed-off-by: Andrey Zhizhikin

> > > <andrey.zhizhikin@leica-geosystems.com>

> > > ---

> > >  arch/arm/configs/at91_dt_defconfig        | 1 -

> > >  arch/arm/configs/cm_x300_defconfig        | 1 -

> > >  arch/arm/configs/colibri_pxa300_defconfig | 1 -

> > >  arch/arm/configs/jornada720_defconfig     | 1 -

> > >  arch/arm/configs/magician_defconfig       | 1 -

> > >  arch/arm/configs/mini2440_defconfig       | 1 -

> > >  arch/arm/configs/omap2plus_defconfig      | 1 -

> > >  arch/arm/configs/pxa3xx_defconfig         | 1 -

> > >  arch/arm/configs/qcom_defconfig           | 1 -

> > >  arch/arm/configs/sama5_defconfig          | 1 -

> > >  arch/arm/configs/sunxi_defconfig          | 1 -

> > >  arch/arm/configs/tegra_defconfig          | 1 -

> > >  arch/arm/configs/u8500_defconfig          | 1 -

> > >  13 files changed, 13 deletions(-)

> > 

> > You need to send it to arm-soc maintainers, otherwise no one might feel

> > responsible enough to pick it up.

> 

> Good point, thanks a lot!

> 

> I was not aware of the fact that there is a separate ML that should

> receive patches targeted ARM SOCs. Can you (or anyone else) please

> share it, so I can re-send it there as well?


It's not a mailing list as such (with archives etc.), just an alias to
the arm-soc maintainers: arm@kernel.org.

> > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

> > 

> > +CC Arnd and Olof,

> > 

> > Dear Arnd and Olof,

> > 

> > Maybe it is worth to add arm-soc entry to the MAINTAINERS file?

> > Otherwise how one could get your email address? Not mentioning the

> > secret-soc address. :)


I tried to convince them before, it didn't work. I guess they don't like
to be spammed ;). Or rather, SoC-specific patches, even to defconfig,
should go through the specific SoC maintainers. However, there are
occasional defconfig patches which are more generic or affecting
multiple SoCs. I just ignore them as the arm64 defconfig is usually
handled by the arm-soc folk (when I need a defconfig change, I go for
arch/arm64/Kconfig directly ;)).

Anyway, I still think that we should add a MAINTAINERS entry for
arch/arm64/configs/defconfig and arch/arm64/Kconfig.platforms.

-- 
Catalin
Alexandre Belloni Dec. 1, 2020, 3:41 p.m. UTC | #8
On 01/12/2020 14:40:53+0000, Catalin Marinas wrote:
> On Mon, Nov 30, 2020 at 07:50:25PM +0000, ZHIZHIKIN Andrey wrote:

> > From Krzysztof Kozlowski <krzk@kernel.org>:

> > > On Mon, Nov 30, 2020 at 03:21:33PM +0000, Andrey Zhizhikin wrote:

> > > > Commit 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it is

> > > > unused") removed geenric_bl driver from the tree, together with

> > > > corresponding config option.

> > > >

> > > > Remove BACKLIGHT_GENERIC config item from all ARM configurations.

> > > >

> > > > Fixes: 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it

> > > > is unused")

> > > > Cc: Sam Ravnborg <sam@ravnborg.org>

> > > > Signed-off-by: Andrey Zhizhikin

> > > > <andrey.zhizhikin@leica-geosystems.com>

> > > > ---

> > > >  arch/arm/configs/at91_dt_defconfig        | 1 -

> > > >  arch/arm/configs/cm_x300_defconfig        | 1 -

> > > >  arch/arm/configs/colibri_pxa300_defconfig | 1 -

> > > >  arch/arm/configs/jornada720_defconfig     | 1 -

> > > >  arch/arm/configs/magician_defconfig       | 1 -

> > > >  arch/arm/configs/mini2440_defconfig       | 1 -

> > > >  arch/arm/configs/omap2plus_defconfig      | 1 -

> > > >  arch/arm/configs/pxa3xx_defconfig         | 1 -

> > > >  arch/arm/configs/qcom_defconfig           | 1 -

> > > >  arch/arm/configs/sama5_defconfig          | 1 -

> > > >  arch/arm/configs/sunxi_defconfig          | 1 -

> > > >  arch/arm/configs/tegra_defconfig          | 1 -

> > > >  arch/arm/configs/u8500_defconfig          | 1 -

> > > >  13 files changed, 13 deletions(-)

> > > 

> > > You need to send it to arm-soc maintainers, otherwise no one might feel

> > > responsible enough to pick it up.

> > 

> > Good point, thanks a lot!

> > 

> > I was not aware of the fact that there is a separate ML that should

> > receive patches targeted ARM SOCs. Can you (or anyone else) please

> > share it, so I can re-send it there as well?

> 

> It's not a mailing list as such (with archives etc.), just an alias to

> the arm-soc maintainers: arm@kernel.org.

> 

> > > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

> > > 

> > > +CC Arnd and Olof,

> > > 

> > > Dear Arnd and Olof,

> > > 

> > > Maybe it is worth to add arm-soc entry to the MAINTAINERS file?

> > > Otherwise how one could get your email address? Not mentioning the

> > > secret-soc address. :)

> 

> I tried to convince them before, it didn't work. I guess they don't like

> to be spammed ;).


The first rule of arm-soc is: you do not talk about arm@ and soc@

> Or rather, SoC-specific patches, even to defconfig,

> should go through the specific SoC maintainers. However, there are

> occasional defconfig patches which are more generic or affecting

> multiple SoCs. I just ignore them as the arm64 defconfig is usually

> handled by the arm-soc folk (when I need a defconfig change, I go for

> arch/arm64/Kconfig directly ;)).

> 


IIRC, the plan was indeed to get defconfig changes through the platform
sub-trees. It is also supposed to be how multi_v5 and multi_v7 are
handled and they will take care of the merge.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Arnd Bergmann Dec. 1, 2020, 3:50 p.m. UTC | #9
On Tue, Dec 1, 2020 at 4:41 PM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
> On 01/12/2020 14:40:53+0000, Catalin Marinas wrote:

> > On Mon, Nov 30, 2020 at 07:50:25PM +0000, ZHIZHIKIN Andrey wrote:

> > > From Krzysztof Kozlowski <krzk@kernel.org>:


> > I tried to convince them before, it didn't work. I guess they don't like

> > to be spammed ;).

>

> The first rule of arm-soc is: you do not talk about arm@ and soc@


I don't mind having the addresses documented better, but it needs to
be done in a way that avoids having any patch for arch/arm*/boot/dts
and arch/arm/*/configs Cc:d to soc@kernel.org.

If anyone has suggestions for how to do that, let me know.

> > Or rather, SoC-specific patches, even to defconfig,

> > should go through the specific SoC maintainers. However, there are

> > occasional defconfig patches which are more generic or affecting

> > multiple SoCs. I just ignore them as the arm64 defconfig is usually

> > handled by the arm-soc folk (when I need a defconfig change, I go for

> > arch/arm64/Kconfig directly ;)).

>

> IIRC, the plan was indeed to get defconfig changes through the platform

> sub-trees. It is also supposed to be how multi_v5 and multi_v7 are

> handled and they will take care of the merge.


For cross-platform changes like this one, I'm definitely happy to
pick up the patch directly from soc@kernel.org, or from mailing
list if I know about it.

We usually do the merges for the soc tree in batches and rely
on patchwork to keep track of what I'm missing, so if Olof and
I are just on Cc to a mail, we might have forgotten about it
by the time we do the next merges.

      Arnd
Andrey Zhizhikin Dec. 1, 2020, 7:48 p.m. UTC | #10
Hello Arnd,

> -----Original Message-----

> From: Arnd Bergmann <arnd@kernel.org>

> Sent: Tuesday, December 1, 2020 4:50 PM

> To: Alexandre Belloni <alexandre.belloni@bootlin.com>

> Cc: Catalin Marinas <catalin.marinas@arm.com>; ZHIZHIKIN Andrey

> <andrey.zhizhikin@leica-geosystems.com>; Krzysztof Kozlowski

> <krzk@kernel.org>; linux@armlinux.org.uk; nicolas.ferre@microchip.com;

> ludovic.desroches@microchip.com; tony@atomide.com;

> mripard@kernel.org; wens@csie.org; jernej.skrabec@siol.net;

> thierry.reding@gmail.com; jonathanh@nvidia.com; will@kernel.org;

> tsbogend@alpha.franken.de; James.Bottomley@HansenPartnership.com;

> deller@gmx.de; mpe@ellerman.id.au; benh@kernel.crashing.org;

> paulus@samba.org; lee.jones@linaro.org; sam@ravnborg.org;

> emil.l.velikov@gmail.com; daniel.thompson@linaro.org; linux-arm-

> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux-

> omap@vger.kernel.org; linux-tegra@vger.kernel.org; linux-

> mips@vger.kernel.org; linux-parisc@vger.kernel.org; linuxppc-

> dev@lists.ozlabs.org; Arnd Bergmann <arnd@arndb.de>; Olof Johansson

> <olof@lixom.net>; arm-soc <arm@kernel.org>

> Subject: Re: [PATCH 1/5] ARM: configs: drop unused BACKLIGHT_GENERIC

> option

> 

> 

> On Tue, Dec 1, 2020 at 4:41 PM Alexandre Belloni

> <alexandre.belloni@bootlin.com> wrote:

> > On 01/12/2020 14:40:53+0000, Catalin Marinas wrote:

> > > On Mon, Nov 30, 2020 at 07:50:25PM +0000, ZHIZHIKIN Andrey wrote:

> > > > From Krzysztof Kozlowski <krzk@kernel.org>:

> 

> > > I tried to convince them before, it didn't work. I guess they don't

> > > like to be spammed ;).

> >

> > The first rule of arm-soc is: you do not talk about arm@ and soc@

> 

> I don't mind having the addresses documented better, but it needs to be

> done in a way that avoids having any patch for arch/arm*/boot/dts and

> arch/arm/*/configs Cc:d to soc@kernel.org.

> 

> If anyone has suggestions for how to do that, let me know.


Just as a proposal:
Maybe those addresses should at least be included in the Documentation ("Select the recipients for your patch" section of "Submitting patches"), much like stable@ is. Those who get themselves familiarized with it - would get an idea about which list they would need to include in Cc: for such changes.

That should IMHO partially reduce the traffic on the list since it would not pop-up in the output of get_maintainer.pl, but would at least be documented so contributors can follow the process.

> 

> > > Or rather, SoC-specific patches, even to defconfig, should go

> > > through the specific SoC maintainers. However, there are occasional

> > > defconfig patches which are more generic or affecting multiple SoCs.

> > > I just ignore them as the arm64 defconfig is usually handled by the

> > > arm-soc folk (when I need a defconfig change, I go for

> > > arch/arm64/Kconfig directly ;)).

> >

> > IIRC, the plan was indeed to get defconfig changes through the

> > platform sub-trees. It is also supposed to be how multi_v5 and

> > multi_v7 are handled and they will take care of the merge.

> 

> For cross-platform changes like this one, I'm definitely happy to pick up the

> patch directly from soc@kernel.org, or from mailing list if I know about it.


Should I collect all Ack's and re-send this series including the list "nobody talks about" :), or the series can be picked up as-is?

Your advice would be really welcomed here!

> 

> We usually do the merges for the soc tree in batches and rely on patchwork

> to keep track of what I'm missing, so if Olof and I are just on Cc to a mail, we

> might have forgotten about it by the time we do the next merges.

> 

>       Arnd


Regards,
Andrey
Arnd Bergmann Dec. 1, 2020, 8:44 p.m. UTC | #11
On Tue, Dec 1, 2020 at 8:48 PM ZHIZHIKIN Andrey
<andrey.zhizhikin@leica-geosystems.com> wrote:
> Hello Arnd,

> > > > Or rather, SoC-specific patches, even to defconfig, should go

> > > > through the specific SoC maintainers. However, there are occasional

> > > > defconfig patches which are more generic or affecting multiple SoCs.

> > > > I just ignore them as the arm64 defconfig is usually handled by the

> > > > arm-soc folk (when I need a defconfig change, I go for

> > > > arch/arm64/Kconfig directly ;)).

> > >

> > > IIRC, the plan was indeed to get defconfig changes through the

> > > platform sub-trees. It is also supposed to be how multi_v5 and

> > > multi_v7 are handled and they will take care of the merge.

> >

> > For cross-platform changes like this one, I'm definitely happy to pick up the

> > patch directly from soc@kernel.org, or from mailing list if I know about it.

>

> Should I collect all Ack's and re-send this series including the list "nobody

> talks about" :), or the series can be picked up as-is?

>

> Your advice would be really welcomed here!


Yes, please do, that makes my life easier. I would apply the patches
for arch/arm and arch/arm64 when you send them to soc@kernel.org,
the others go to the respective architecture maintainers, unless they
want me to pick up the whole series.

      Arnd
Krzysztof Kozlowski Dec. 1, 2020, 9:18 p.m. UTC | #12
On Tue, Dec 01, 2020 at 04:50:22PM +0100, Arnd Bergmann wrote:
> On Tue, Dec 1, 2020 at 4:41 PM Alexandre Belloni

> <alexandre.belloni@bootlin.com> wrote:

> > On 01/12/2020 14:40:53+0000, Catalin Marinas wrote:

> > > On Mon, Nov 30, 2020 at 07:50:25PM +0000, ZHIZHIKIN Andrey wrote:

> > > > From Krzysztof Kozlowski <krzk@kernel.org>:

> 

> > > I tried to convince them before, it didn't work. I guess they don't like

> > > to be spammed ;).

> >

> > The first rule of arm-soc is: you do not talk about arm@ and soc@

> 

> I don't mind having the addresses documented better, but it needs to

> be done in a way that avoids having any patch for arch/arm*/boot/dts

> and arch/arm/*/configs Cc:d to soc@kernel.org.

> 

> If anyone has suggestions for how to do that, let me know.


Not a perfect solution but something. How about:
https://lore.kernel.org/linux-arm-kernel/20201201211516.24921-2-krzk@kernel.org/T/#u

Would not work on defconfigs but there is a chance someone will find
your addresses this way. Should not cause to much additional traffic.

Best regards,
Krzysztof