| Message ID | 20221025185147.665365-1-helgaas@kernel.org |
|---|---|
| Headers | show |
| Series | PCI: Remove unnecessary <linux/of_irq.h> includes | expand |
On Tue, Oct 25, 2022 at 01:51:43PM -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas <bhelgaas@google.com> > > Many host controller drivers #include <linux/of_irq.h> even though they > don't need it. Remove the unnecessary #includes. > > v1: https://lore.kernel.org/all/20221019195452.37606-1-helgaas@kernel.org/ > > Changes from v1 to v2: > - Include <linux/irqdomain.h> explicitly in altera-msi and microchip, > which don't need <linux/of_irq.h> itself, but relied on it to include > <linux/irqdomain.h> > - Include <linux/irqdomain.h> explicitly in mvebu, which needs both it > and <linux/of_irq.h> > > Bjorn Helgaas (4): > PCI: altera-msi: Include <linux/irqdomain.h> explicitly > PCI: microchip: Include <linux/irqdomain.h> explicitly > PCI: mvebu: Include <linux/irqdomain.h> explicitly > PCI: Remove unnecessary <linux/of_irq.h> includes > drivers/pci/controller/pcie-microchip-host.c | 2 +- Hey Bjorn, actually did the build this time rather than visually inspecting... For the microchip bits: Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks!
On Tue, 25 Oct 2022 13:51:46 -0500 Bjorn Helgaas <helgaas@kernel.org> wrote: > From: Bjorn Helgaas <bhelgaas@google.com> > > pci-mvebu.c uses irq_domain_add_linear() and related interfaces but relies > on <linux/irqdomain.h> but doesn't include it directly; it relies on the > fact that <linux/of_irq.h> includes it. > > Include <linux/irqdomain.h> directly to remove this implicit dependency. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > --- > drivers/pci/controller/pci-mvebu.c | 1 + > 1 file changed, 1 insertion(+) Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Thanks! Thomas
From: Bjorn Helgaas <bhelgaas@google.com> Many host controller drivers #include <linux/of_irq.h> even though they don't need it. Remove the unnecessary #includes. v1: https://lore.kernel.org/all/20221019195452.37606-1-helgaas@kernel.org/ Changes from v1 to v2: - Include <linux/irqdomain.h> explicitly in altera-msi and microchip, which don't need <linux/of_irq.h> itself, but relied on it to include <linux/irqdomain.h> - Include <linux/irqdomain.h> explicitly in mvebu, which needs both it and <linux/of_irq.h> Bjorn Helgaas (4): PCI: altera-msi: Include <linux/irqdomain.h> explicitly PCI: microchip: Include <linux/irqdomain.h> explicitly PCI: mvebu: Include <linux/irqdomain.h> explicitly PCI: Remove unnecessary <linux/of_irq.h> includes drivers/pci/controller/cadence/pci-j721e.c | 1 - drivers/pci/controller/dwc/pci-layerscape.c | 1 - drivers/pci/controller/dwc/pcie-armada8k.c | 1 - drivers/pci/controller/dwc/pcie-tegra194.c | 1 - drivers/pci/controller/pci-mvebu.c | 1 + drivers/pci/controller/pci-v3-semi.c | 1 - drivers/pci/controller/pci-xgene-msi.c | 1 - drivers/pci/controller/pci-xgene.c | 1 - drivers/pci/controller/pcie-altera-msi.c | 2 +- drivers/pci/controller/pcie-iproc-platform.c | 1 - drivers/pci/controller/pcie-iproc.c | 1 - drivers/pci/controller/pcie-microchip-host.c | 2 +- drivers/pci/controller/pcie-rockchip-host.c | 1 - drivers/pci/controller/pcie-xilinx-cpm.c | 1 - drivers/pci/controller/pcie-xilinx-nwl.c | 1 - 15 files changed, 3 insertions(+), 14 deletions(-)