From patchwork Fri Mar 6 19:26:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Grygorii.Strashko@linaro.org" X-Patchwork-Id: 45494 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f198.google.com (mail-wi0-f198.google.com [209.85.212.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 3695C214A0 for ; Fri, 6 Mar 2015 19:27:15 +0000 (UTC) Received: by wivz2 with SMTP id z2sf3374515wiv.1 for ; Fri, 06 Mar 2015 11:27:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=32TdSycImxqhr+Vg4UCLWYwsKLG2ViMR7LGSPGzNBl8=; b=ZAB6f/A724wyAuRHB56D2pc276Qm4piG70XcUUI6Z6P2cBGY9KEoLoa/MiW4z69Agw 9uNWXSINvNeFlQ9jBab8ZzDLqZczr9YAQY+RWY0/tYU12JLn4+znPL7OXpGLEncuSM8M Mxyt2RPXOASWgTeFcpVc+q1QvgIurPoXp5ZJL1IwI3ZLneKqXT7E7LneW+U2TghzY7IH bR5l5+JEwiIG7EDmkhg+lMmPtk/krKbdvOJXyzQ4xSLvQvFAd2Z0SfYP82hZzVVkrMvP muTIx4NKl8z8cAibq3FGYo6lLBevaBjwEKxSdyyQVqNYLzjcJQWKsqyC4gQVryxz9M12 AsYg== X-Gm-Message-State: ALoCoQmshaqD3Cpd4n4IgcshIB08jmZ1zUxZ/JBr8QLJclXJcJ3RpUm9incMzIe9PReRwlmyU24H X-Received: by 10.180.91.76 with SMTP id cc12mr3021221wib.7.1425670034247; Fri, 06 Mar 2015 11:27:14 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.7.3 with SMTP id f3ls114388laa.31.gmail; Fri, 06 Mar 2015 11:27:13 -0800 (PST) X-Received: by 10.152.22.200 with SMTP id g8mr14143220laf.96.1425670033925; Fri, 06 Mar 2015 11:27:13 -0800 (PST) Received: from mail-la0-f48.google.com (mail-la0-f48.google.com. [209.85.215.48]) by mx.google.com with ESMTPS id yu12si7907711lbb.25.2015.03.06.11.27.13 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Mar 2015 11:27:13 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.48 as permitted sender) client-ip=209.85.215.48; Received: by labgm9 with SMTP id gm9so20016042lab.8 for ; Fri, 06 Mar 2015 11:27:13 -0800 (PST) X-Received: by 10.152.120.134 with SMTP id lc6mr14172213lab.72.1425670033829; Fri, 06 Mar 2015 11:27:13 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp96391lbj; Fri, 6 Mar 2015 11:27:13 -0800 (PST) X-Received: by 10.66.62.229 with SMTP id b5mr28897886pas.30.1425670032122; Fri, 06 Mar 2015 11:27:12 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a4si4508163pdn.18.2015.03.06.11.27.10; Fri, 06 Mar 2015 11:27:12 -0800 (PST) Received-SPF: none (google.com: linux-omap-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756019AbbCFT1J (ORCPT + 5 others); Fri, 6 Mar 2015 14:27:09 -0500 Received: from mail-lb0-f175.google.com ([209.85.217.175]:38131 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755698AbbCFT1I (ORCPT ); Fri, 6 Mar 2015 14:27:08 -0500 Received: by lbiz12 with SMTP id z12so36866835lbi.5 for ; Fri, 06 Mar 2015 11:27:06 -0800 (PST) X-Received: by 10.152.204.42 with SMTP id kv10mr8083942lac.52.1425670026519; Fri, 06 Mar 2015 11:27:06 -0800 (PST) Received: from localhost ([195.238.92.128]) by mx.google.com with ESMTPSA id i6sm1967973lai.1.2015.03.06.11.27.05 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 06 Mar 2015 11:27:06 -0800 (PST) From: To: Linus Walleij , ssantosh@kernel.org, Javier Martinez Canillas , tony@atomide.com Cc: Alexandre Courbot , linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, Grygorii Strashko Subject: [PATCH 1/2] gpio: omap: irq_shutdown: remove unnecessary call of gpiochip_unlock_as_irq Date: Fri, 6 Mar 2015 21:26:56 +0200 Message-Id: <1425670017-19598-1-git-send-email-grygorii.strashko@linaro.org> X-Mailer: git-send-email 1.9.1 Sender: linux-omap-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: grygorii.strashko@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.48 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Grygorii Strashko GPIOLib core implemnts irqchip->irq_request/release_resources callbacks internally and these callbacks already contain clalls of gpiochip_lock/unlock_as_irq(). Hence, remove unnecessary call of gpiochip_unlock_as_irq() from omap_gpio_irq_shutdown(). Signed-off-by: Grygorii Strashko --- drivers/gpio/gpio-omap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index f476ae2..2b2fc4b 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -826,7 +826,6 @@ static void omap_gpio_irq_shutdown(struct irq_data *d) unsigned offset = GPIO_INDEX(bank, gpio); spin_lock_irqsave(&bank->lock, flags); - gpiochip_unlock_as_irq(&bank->chip, offset); bank->irq_usage &= ~(BIT(offset)); omap_disable_gpio_module(bank, offset); omap_reset_gpio(bank, gpio);