From patchwork Wed Sep 17 17:01:04 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nishanth Menon X-Patchwork-Id: 37534 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f200.google.com (mail-lb0-f200.google.com [209.85.217.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 5F8242057E for ; Wed, 17 Sep 2014 17:01:16 +0000 (UTC) Received: by mail-lb0-f200.google.com with SMTP id u10sf1046602lbd.11 for ; Wed, 17 Sep 2014 10:01:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:cc:subject:message-id :references:mime-version:in-reply-to:user-agent:sender:precedence :list-id:x-original-sender:x-original-authentication-results :mailing-list:list-post:list-help:list-archive:list-unsubscribe :content-type:content-disposition; bh=/Hv4wR1gne0qH7oogpHGlQxbUg24CZirsx60Se1YZ7Y=; b=FyS0sjT0btsnqbZYtFSW/zkvcJer2id7Hz6oKQiVgr3qNHpWwrUmfxwjWV6K+54d6Z dzQENjtAsd0mXUJdKCyB+dCsDg3mujxf2tMaRBsfMq4oBqhr/lFiRLXFNssX4iIpJG+h Vwble0FDxwQWCk0G8EKxjM3WxWQVZ75OEWZMh5exc2FwsBbbnK+K6EJyI2144voYpPK6 dSoR8euhl1TsqPNOrQXwcbgO3MgWE80zIEoxjjspzCbz/OLQgKCKu9cVdxCVWyDOdV0p PM1F4nntpbzLvprLmHtoIMlI7X2UlHStecg3HdOSp2g5SrnNEiY9UCyRyVNNHd5s0sT0 Skiw== X-Gm-Message-State: ALoCoQkLDoXmvI7TDIhNIhtECzqjaj01QAZvvcA+L/KeLzbhvlcF57INYuVk7E9U4uW1m0vaNdYq X-Received: by 10.112.155.133 with SMTP id vw5mr151024lbb.14.1410973275151; Wed, 17 Sep 2014 10:01:15 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.45.101 with SMTP id l5ls124006lam.103.gmail; Wed, 17 Sep 2014 10:01:15 -0700 (PDT) X-Received: by 10.112.56.206 with SMTP id c14mr43247541lbq.27.1410973275003; Wed, 17 Sep 2014 10:01:15 -0700 (PDT) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx.google.com with ESMTPS id jt17si29438315lab.33.2014.09.17.10.01.14 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 17 Sep 2014 10:01:14 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.182 as permitted sender) client-ip=209.85.217.182; Received: by mail-lb0-f182.google.com with SMTP id u10so2285681lbd.13 for ; Wed, 17 Sep 2014 10:01:14 -0700 (PDT) X-Received: by 10.152.5.168 with SMTP id t8mr26273111lat.67.1410973274887; Wed, 17 Sep 2014 10:01:14 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.130.169 with SMTP id of9csp618188lbb; Wed, 17 Sep 2014 10:01:14 -0700 (PDT) X-Received: by 10.67.15.71 with SMTP id fm7mr59307934pad.45.1410973273317; Wed, 17 Sep 2014 10:01:13 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p1si35621857pde.244.2014.09.17.10.01.12 for ; Wed, 17 Sep 2014 10:01:13 -0700 (PDT) Received-SPF: none (google.com: devicetree-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755844AbaIQRBL (ORCPT + 5 others); Wed, 17 Sep 2014 13:01:11 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:54473 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755615AbaIQRBK (ORCPT ); Wed, 17 Sep 2014 13:01:10 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id s8HH15s5007365; Wed, 17 Sep 2014 12:01:05 -0500 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s8HH14QI017238; Wed, 17 Sep 2014 12:01:04 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.3.174.1; Wed, 17 Sep 2014 12:01:05 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s8HH14Qf021721; Wed, 17 Sep 2014 12:01:04 -0500 Date: Wed, 17 Sep 2014 12:01:04 -0500 From: Nishanth Menon To: Sebastian Reichel , Lee Jones CC: Lee Jones , Samuel Ortiz , Tony Lindgren , , , Subject: Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control Message-ID: <20140917170104.GA26864@kahuna> References: <1410957252-764-1-git-send-email-nm@ti.com> <1410957252-764-2-git-send-email-nm@ti.com> <20140917154400.GE30918@lee--X1> <20140917165529.GA24699@earth.universe> MIME-Version: 1.0 In-Reply-To: <20140917165529.GA24699@earth.universe> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: devicetree-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: devicetree@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: nm@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.182 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Content-Disposition: inline On 18:55-20140917, Sebastian Reichel wrote: > On Wed, Sep 17, 2014 at 08:44:00AM -0700, Lee Jones wrote: > > On Wed, 17 Sep 2014, Nishanth Menon wrote: > > > ti,system-power-controller is more or less the standard way of > > > indicating that the PMIC is the system wide power controller and hence > > > may be used to switch off the system. Almost ALL TI PMIC drivers and > > > many Maxim PMIC drivers follow the same style. > > > > > > So support 'ti,system-power-controller' in addition to the usual > > > 'ti,use_poweroff' to indicate that the PMIC instance has control for > > > switching off the system. > > > > > > Signed-off-by: Nishanth Menon > > > --- > > > > > > V2: picked up documentation suggestion from Sebastien > > > > It would be good to get Sebastian's Ack. > > Acked-By: Sebastian Reichel Thanks. > > [...] > > > > +- ti,system-power-controller: This indicates that TWL4030 is the > > > + power supply master of the system. With this flag, the chip will > > > + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the > > > + system poweroffs. > > One minor thing: While the documentation is updated you may want to > fix the typo "will initiates" to "will initiate" (or just drop the > "will"). Updated v3 patch with your ack and correction to drop "will" below. I will assume I wont need to repost the following update. Do let me know if you'd like me to. ---8<--- >From ae3bcfc74080b14f9fd0178f6526bf8f34a8c865 Mon Sep 17 00:00:00 2001 From: Nishanth Menon Date: Wed, 3 Sep 2014 13:55:02 -0500 Subject: [PATCH V3 1/2 ] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control ti,system-power-controller is more or less the standard way of indicating that the PMIC is the system wide power controller and hence may be used to switch off the system. Almost ALL TI PMIC drivers and many Maxim PMIC drivers follow the same style. So support 'ti,system-power-controller' in addition to the usual 'ti,use_poweroff' to indicate that the PMIC instance has control for switching off the system. Signed-off-by: Nishanth Menon Acked-By: Sebastian Reichel --- .../devicetree/bindings/mfd/twl4030-power.txt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/twl4030-power.txt b/Documentation/devicetree/bindings/mfd/twl4030-power.txt index b9ee7b9..15a63e6 100644 --- a/Documentation/devicetree/bindings/mfd/twl4030-power.txt +++ b/Documentation/devicetree/bindings/mfd/twl4030-power.txt @@ -23,8 +23,13 @@ down during off-idle. Note that this does not work on all boards depending on how the external oscillator is wired. Optional properties: -- ti,use_poweroff: With this flag, the chip will initiates an ACTIVE-to-OFF or - SLEEP-to-OFF transition when the system poweroffs. + +- ti,system-power-controller: This indicates that TWL4030 is the + power supply master of the system. With this flag, the chip + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the + system poweroffs. + +- ti,use_poweroff: Deprecated name for ti,system-power-controller Example: &i2c1 {