diff mbox series

[16/42] mfd: max77686: use PLATFORM_DEVID_NONE

Message ID	20200921205016.20461-16-krzk@kernel.org
State	Superseded
Headers	show Return-Path: <SRS0=E7g0=C6=vger.kernel.org=linux-omap-owner@kernel.org> From: Krzysztof Kozlowski <krzk@kernel.org> To: Lee Jones <lee.jones@linaro.org>, Nicolas Ferre <nicolas.ferre@microchip.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Ludovic Desroches <ludovic.desroches@microchip.com>, Chen-Yu Tsai <wens@csie.org>, Florian Fainelli <f.fainelli@gmail.com>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne <nsaenzjulienne@suse.de>, Support Opensource <support.opensource@diasemi.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Milo Kim <milo.kim@ti.com>, Chanwoo Choi <cw00.choi@samsung.com>, Krzysztof Kozlowski <krzk@kernel.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Sangbeom Kim <sbkim73@samsung.com>, Tony Lindgren <tony@atomide.com>, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org Subject: [PATCH 16/42] mfd: max77686: use PLATFORM_DEVID_NONE Date: Mon, 21 Sep 2020 22:49:50 +0200 Message-Id: <20200921205016.20461-16-krzk@kernel.org> In-Reply-To: <20200921205016.20461-1-krzk@kernel.org> References: <20200921205016.20461-1-krzk@kernel.org> Precedence: bulk
Series	[01/42] mfd: arizona: use PLATFORM_DEVID_NONE \| expand [01/42] mfd: arizona: use PLATFORM_DEVID_NONE [02/42] mfd: as3711: use PLATFORM_DEVID_NONE [03/42] mfd: as3722: use PLATFORM_DEVID_NONE [04/42] mfd: atmel-hlcdc: use PLATFORM_DEVID_NONE [05/42] mfd: axp20x: use PLATFORM_DEVID_NONE [06/42] mfd: bcm2835: use PLATFORM_DEVID_NONE [07/42] mfd: bcm590xx: use PLATFORM_DEVID_NONE [08/42] mfd: da9055: use PLATFORM_DEVID_NONE [09/42] mfd: da9150: use PLATFORM_DEVID_NONE [10/42] mfd: intel_msic: use PLATFORM_DEVID_NONE [11/42] mfd: intel_soc_pmic: use PLATFORM_DEVID_NONE [12/42] mfd: kempld: use PLATFORM_DEVID_NONE [13/42] mfd: lp8788: use PLATFORM_DEVID_NONE [14/42] mfd: lp3943: use PLATFORM_DEVID_NONE [15/42] mfd: max14577: use PLATFORM_DEVID_NONE [16/42] mfd: max77686: use PLATFORM_DEVID_NONE [17/42] mfd: max77693: use PLATFORM_DEVID_NONE [18/42] mfd: max77843: use PLATFORM_DEVID_NONE [19/42] mfd: max8907: use PLATFORM_DEVID_NONE [20/42] mfd: max8997: use PLATFORM_DEVID_NONE [21/42] mfd: max8998: use PLATFORM_DEVID_NONE [22/42] mfd: mc13xxx: use PLATFORM_DEVID_NONE [23/42] mfd: rc5t583: use PLATFORM_DEVID_NONE [24/42] mfd: rdc321x: use PLATFORM_DEVID_NONE [25/42] mfd: retu: use PLATFORM_DEVID_NONE [26/42] mfd: rt5033: use PLATFORM_DEVID_NONE [27/42] mfd: sec: use PLATFORM_DEVID_NONE [28/42] mfd: sky81452: use PLATFORM_DEVID_NONE [29/42] mfd: sta2x11: use PLATFORM_DEVID_NONE [30/42] mfd: tc3589x: use PLATFORM_DEVID_NONE [31/42] mfd: timberdale: use PLATFORM_DEVID_NONE [32/42] mfd: tps6507x: use PLATFORM_DEVID_NONE [33/42] mfd: tps65090: use PLATFORM_DEVID_NONE [34/42] mfd: tps65217: use PLATFORM_DEVID_NONE [35/42] mfd: tps6586x: use PLATFORM_DEVID_NONE [36/42] mfd: tps65910: use PLATFORM_DEVID_NONE [37/42] mfd: tps80031: use PLATFORM_DEVID_NONE [38/42] mfd: twl6040: use PLATFORM_DEVID_NONE [39/42] mfd: vx855: use PLATFORM_DEVID_NONE [40/42] mfd: wl1273: use PLATFORM_DEVID_NONE [41/42] mfd: wm8400: use PLATFORM_DEVID_NONE [42/42] mfd: wm8994: use PLATFORM_DEVID_NONE

Commit Message

Krzysztof Kozlowski Sept. 21, 2020, 8:49 p.m. UTC

Use PLATFORM_DEVID_NONE define instead of "-1" value because:
 - it brings some meaning,
 - it might point attention why auto device ID was not used.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/mfd/max77686.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Chanwoo Choi Sept. 28, 2020, 3:16 a.m. UTC | #1

On 9/22/20 5:49 AM, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
>  - it brings some meaning,
>  - it might point attention why auto device ID was not used.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  drivers/mfd/max77686.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
> index 71faf503844b..1f26d00fdd37 100644
> --- a/drivers/mfd/max77686.c
> +++ b/drivers/mfd/max77686.c
> @@ -217,8 +217,8 @@ static int max77686_i2c_probe(struct i2c_client *i2c)
>  		return ret;
>  	}
>  
> -	ret = devm_mfd_add_devices(max77686->dev, -1, cells, n_devs, NULL,
> -				   0, NULL);
> +	ret = devm_mfd_add_devices(max77686->dev, PLATFORM_DEVID_NONE, cells,
> +				   n_devs, NULL, 0, NULL);
>  	if (ret < 0) {
>  		dev_err(&i2c->dev, "failed to add MFD devices: %d\n", ret);
>  		return ret;
> 

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

diff mbox series

Patch

diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
index 71faf503844b..1f26d00fdd37 100644
--- a/drivers/mfd/max77686.c
+++ b/drivers/mfd/max77686.c
@@ -217,8 +217,8 @@  static int max77686_i2c_probe(struct i2c_client *i2c)
 		return ret;
 	}
 
-	ret = devm_mfd_add_devices(max77686->dev, -1, cells, n_devs, NULL,
-				   0, NULL);
+	ret = devm_mfd_add_devices(max77686->dev, PLATFORM_DEVID_NONE, cells,
+				   n_devs, NULL, 0, NULL);
 	if (ret < 0) {
 		dev_err(&i2c->dev, "failed to add MFD devices: %d\n", ret);
 		return ret;