mbox series

[RESEND,v3,0/7] dt-bindings: Convert multiple Qualcomm OPP and CPUFreq bindings to DT schema

Message ID 20220203072226.51482-1-y.oudjana@protonmail.com
Headers show
Series dt-bindings: Convert multiple Qualcomm OPP and CPUFreq bindings to DT schema | expand

Message

Yassine Oudjana Feb. 3, 2022, 7:24 a.m. UTC
This series is a compilation of DT schema conversions of multiple Qualcomm
OPP and CPUFreq bindings:
- qcom-cpufreq-nvmem (operating-points-v2-kryo-cpu)
- qcom-opp (operating-points-v2-qcom-level)
- qcom,cpr

Converting each one to DT schema introduces new dt_binding_check and
dtbs_check errors to the others, so it was better to combine them into
a series. Some errors were also caused by a couple of device trees having
OPP tables with names that do not follow opp-v2-base, so these got fixed
in this series as well. Finally, the lack of MSM8996 compatibles in
arm/qcom.yaml caused an error in the opp-v2-kryo-cpu example, so they were
added to the schema as well as to the msm8996-mtp device tree, which only
had qcom,msm8996-mtp as its compatible.

PATCH 4/7 is a new version of a patch[1] that was sent as part of
a different series before, and PATCH 7/7 is a new version of a patch[2]
that was sent alone.

Changes in v3:
 - Resend with unified version for all patches

Changes since v1 (PATCH v2 4/7):
 - Split the schema into an OPP schema and a CPUFreq schema. 

Changes since v1 (PATCH v2 7/7):
 - Remove allOf from compatible.

Yassine Oudjana (7):
  dt-bindings: arm: qcom: Add msm8996 and apq8096 compatibles
  arm64: dts: qcom: msm8996-mtp: Add msm8996 compatible
  dt-bindings: opp: qcom-opp: Convert to DT schema
  dt-bindings: opp: Convert qcom-nvmem-cpufreq to DT schema
  arm64: dts: qcom: msm8996: Rename cluster OPP tables
  arm64: dts: qcom: qcs404: Rename CPU and CPR OPP tables
  dt-bindings: power: avs: qcom,cpr: Convert to DT schema

 .../devicetree/bindings/arm/qcom.yaml         |  16 +-
 .../bindings/cpufreq/qcom-cpufreq-nvmem.yaml  | 166 ++++
 .../bindings/opp/opp-v2-kryo-cpu.yaml         | 257 ++++++
 .../bindings/opp/opp-v2-qcom-level.yaml       |  60 ++
 .../bindings/opp/qcom-nvmem-cpufreq.txt       | 796 ------------------
 .../devicetree/bindings/opp/qcom-opp.txt      |  19 -
 .../bindings/power/avs/qcom,cpr.txt           | 130 ---
 .../bindings/power/avs/qcom,cpr.yaml          | 160 ++++
 MAINTAINERS                                   |   5 +-
 arch/arm64/boot/dts/qcom/msm8996-mtp.dts      |   2 +-
 arch/arm64/boot/dts/qcom/msm8996.dtsi         |   4 +-
 arch/arm64/boot/dts/qcom/qcs404.dtsi          |   4 +-
 12 files changed, 666 insertions(+), 953 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
 create mode 100644 Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml
 create mode 100644 Documentation/devicetree/bindings/opp/opp-v2-qcom-level.yaml
 delete mode 100644 Documentation/devicetree/bindings/opp/qcom-nvmem-cpufreq.txt
 delete mode 100644 Documentation/devicetree/bindings/opp/qcom-opp.txt
 delete mode 100644 Documentation/devicetree/bindings/power/avs/qcom,cpr.txt
 create mode 100644 Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml

[1] https://lore.kernel.org/linux-arm-msm/20211014083016.137441-6-y.oudjana@protonmail.com/
[2] https://lore.kernel.org/linux-arm-msm/20211221133937.173618-1-y.oudjana@protonmail.com/

Comments

Bjorn Andersson Feb. 11, 2022, 12:20 a.m. UTC | #1
On Thu 03 Feb 01:24 CST 2022, Yassine Oudjana wrote:

> This series is a compilation of DT schema conversions of multiple Qualcomm
> OPP and CPUFreq bindings:
> - qcom-cpufreq-nvmem (operating-points-v2-kryo-cpu)
> - qcom-opp (operating-points-v2-qcom-level)
> - qcom,cpr
> 

Really nice to see these updates!

I'm going to pick up the patches that goes through the Qualcomm tree,
but patch 3,4 and 7 would be better to take through Viresh's tree, so
I've looped him in on this reply.

Thanks,
Bjorn

> Converting each one to DT schema introduces new dt_binding_check and
> dtbs_check errors to the others, so it was better to combine them into
> a series. Some errors were also caused by a couple of device trees having
> OPP tables with names that do not follow opp-v2-base, so these got fixed
> in this series as well. Finally, the lack of MSM8996 compatibles in
> arm/qcom.yaml caused an error in the opp-v2-kryo-cpu example, so they were
> added to the schema as well as to the msm8996-mtp device tree, which only
> had qcom,msm8996-mtp as its compatible.
> 
> PATCH 4/7 is a new version of a patch[1] that was sent as part of
> a different series before, and PATCH 7/7 is a new version of a patch[2]
> that was sent alone.
> 
> Changes in v3:
>  - Resend with unified version for all patches
> 
> Changes since v1 (PATCH v2 4/7):
>  - Split the schema into an OPP schema and a CPUFreq schema. 
> 
> Changes since v1 (PATCH v2 7/7):
>  - Remove allOf from compatible.
> 
> Yassine Oudjana (7):
>   dt-bindings: arm: qcom: Add msm8996 and apq8096 compatibles
>   arm64: dts: qcom: msm8996-mtp: Add msm8996 compatible
>   dt-bindings: opp: qcom-opp: Convert to DT schema
>   dt-bindings: opp: Convert qcom-nvmem-cpufreq to DT schema
>   arm64: dts: qcom: msm8996: Rename cluster OPP tables
>   arm64: dts: qcom: qcs404: Rename CPU and CPR OPP tables
>   dt-bindings: power: avs: qcom,cpr: Convert to DT schema
> 
>  .../devicetree/bindings/arm/qcom.yaml         |  16 +-
>  .../bindings/cpufreq/qcom-cpufreq-nvmem.yaml  | 166 ++++
>  .../bindings/opp/opp-v2-kryo-cpu.yaml         | 257 ++++++
>  .../bindings/opp/opp-v2-qcom-level.yaml       |  60 ++
>  .../bindings/opp/qcom-nvmem-cpufreq.txt       | 796 ------------------
>  .../devicetree/bindings/opp/qcom-opp.txt      |  19 -
>  .../bindings/power/avs/qcom,cpr.txt           | 130 ---
>  .../bindings/power/avs/qcom,cpr.yaml          | 160 ++++
>  MAINTAINERS                                   |   5 +-
>  arch/arm64/boot/dts/qcom/msm8996-mtp.dts      |   2 +-
>  arch/arm64/boot/dts/qcom/msm8996.dtsi         |   4 +-
>  arch/arm64/boot/dts/qcom/qcs404.dtsi          |   4 +-
>  12 files changed, 666 insertions(+), 953 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
>  create mode 100644 Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml
>  create mode 100644 Documentation/devicetree/bindings/opp/opp-v2-qcom-level.yaml
>  delete mode 100644 Documentation/devicetree/bindings/opp/qcom-nvmem-cpufreq.txt
>  delete mode 100644 Documentation/devicetree/bindings/opp/qcom-opp.txt
>  delete mode 100644 Documentation/devicetree/bindings/power/avs/qcom,cpr.txt
>  create mode 100644 Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml
> 
> [1] https://lore.kernel.org/linux-arm-msm/20211014083016.137441-6-y.oudjana@protonmail.com/
> [2] https://lore.kernel.org/linux-arm-msm/20211221133937.173618-1-y.oudjana@protonmail.com/
> -- 
> 2.34.1
> 
>
Viresh Kumar Feb. 11, 2022, 4:35 a.m. UTC | #2
On 10-02-22, 18:20, Bjorn Andersson wrote:
> On Thu 03 Feb 01:24 CST 2022, Yassine Oudjana wrote:
> 
> > This series is a compilation of DT schema conversions of multiple Qualcomm
> > OPP and CPUFreq bindings:
> > - qcom-cpufreq-nvmem (operating-points-v2-kryo-cpu)
> > - qcom-opp (operating-points-v2-qcom-level)
> > - qcom,cpr
> > 
> 
> Really nice to see these updates!
> 
> I'm going to pick up the patches that goes through the Qualcomm tree,
> but patch 3,4 and 7 would be better to take through Viresh's tree, so
> I've looped him in on this reply.

I believe all these need to go together, else you will start getting
schema errors ?