| Message ID | 20221204055909.1351895-1-dmitry.baryshkov@linaro.org |
|---|---|
| Headers | show |
| Series | thermal/drivers/tsens: specify nvmem cells in DT rather than parsing them manually | expand |
On 04/12/2022 06:58, Dmitry Baryshkov wrote: > The msm8974 platform uses two sets of calibration data, add a special > case to handle both of them. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Le dimanche 04 décembre 2022 à 07:59 +0200, Dmitry Baryshkov a écrit : > There is no dtsi file for msm8939 in the kernel sources. Drop the > compatibility with unofficial dtsi and remove support for handling the > single-cell calibration data on msm8939. Could one invoke a "msm8916-like exemption" here ? Also, msm8939.dtsi was submitted once [1], and if helps we could send a v2 this month... [1] https://lore.kernel.org/linux-arm-msm/20220419010903.3109514-1-bryan.odonoghue@linaro.org/
On 04/12/2022 19:25, Vincent Knecht wrote: > Le dimanche 04 décembre 2022 à 19:42 +0100, Vincent Knecht a écrit : >> Le dimanche 04 décembre 2022 à 07:59 +0200, Dmitry Baryshkov a écrit : >>> There is no dtsi file for msm8939 in the kernel sources. Drop the >>> compatibility with unofficial dtsi and remove support for handling the >>> single-cell calibration data on msm8939. >> >> Could one invoke a "msm8916-like exemption" here ? > > Ignore that, guess we'll just have to implement it like there: > https://lore.kernel.org/linux-arm-msm/20221204055909.1351895-9-dmitry.baryshkov@linaro.org/T/#m19cffb13114b6f4f153058e3e7a1943251acaf81 > >> Also, msm8939.dtsi was submitted once [1], >> and if helps we could send a v2 this month... >> >> [1] https://lore.kernel.org/linux-arm-msm/20220419010903.3109514-1-bryan.odonoghue@linaro.org/ > > Offer still stands, the current community one is here: > https://github.com/msm8916-mainline/linux/blob/msm8916/6.1-rc7/arch/arm64/boot/dts/qcom/msm8939.dtsi > > > heh - here's my current https://git.linaro.org/landing-teams/working/qualcomm/kernel.git/log/?h=tracking-qcomlt-msm8939 I've been working on clearing out blockages in legacy yaml conversions phy mdss-dsi-ctrl which thrown up errors on 8939 I took a good bunch of feedback from the list for v1 into that dtsi - there's not much left blocking v2. I'll see if I can get that out this week --- bod
On Mon, 5 Dec 2022 at 14:42, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote: > > On 04/12/2022 19:25, Vincent Knecht wrote: > > Le dimanche 04 décembre 2022 à 19:42 +0100, Vincent Knecht a écrit : > >> Le dimanche 04 décembre 2022 à 07:59 +0200, Dmitry Baryshkov a écrit : > >>> There is no dtsi file for msm8939 in the kernel sources. Drop the > >>> compatibility with unofficial dtsi and remove support for handling the > >>> single-cell calibration data on msm8939. > >> > >> Could one invoke a "msm8916-like exemption" here ? Colleagues, I know that it adds a bit of pain on your side, however I'd also kindly ask to rework the dtsi. I'd really like to drop as much of the 'legacy parsing' as possible. The existing code is painful to handle already, it is redundant, self-duplicated, etc. See, how easier is to handle the DT cells + nvmem_cell API vs old shifts and masks code. > > > > Ignore that, guess we'll just have to implement it like there: > > https://lore.kernel.org/linux-arm-msm/20221204055909.1351895-9-dmitry.baryshkov@linaro.org/T/#m19cffb13114b6f4f153058e3e7a1943251acaf81 > > > >> Also, msm8939.dtsi was submitted once [1], > >> and if helps we could send a v2 this month... > >> > >> [1] https://lore.kernel.org/linux-arm-msm/20220419010903.3109514-1-bryan.odonoghue@linaro.org/ > > > > Offer still stands, the current community one is here: > > https://github.com/msm8916-mainline/linux/blob/msm8916/6.1-rc7/arch/arm64/boot/dts/qcom/msm8939.dtsi > > > > > > > > heh - here's my current > > https://git.linaro.org/landing-teams/working/qualcomm/kernel.git/log/?h=tracking-qcomlt-msm8939 > > I've been working on clearing out blockages in legacy yaml conversions > > phy > mdss-dsi-ctrl > > which thrown up errors on 8939 > > I took a good bunch of feedback from the list for v1 into that dtsi - > there's not much left blocking v2. > > I'll see if I can get that out this week > > --- > bod > >
Historically the tsens driver fetches the calibration data as a blob and then parses the blob on its own. This results in semi-duplicated code spreading over the platform-specific functions. This patch series changes tsens calibration code to per-value nvmem cells rather than parsing the blob in the driver. For backwards compatibility the old code is left in place for msm8916, msm8974 and qcs404, the platforms which have in-tree DT files. For all other affected platforms the old parsing code has been dropped as a part of this series. The code was tested on msm8916 and qcs404 only. Note: the DTs changes depend on driver changes. Tsens driver will not work if DT patches are merged, but the driver bits are not. As the thermal sense is critical for device safety, I'd suggest merging binding and driver during one merge window and then merging DT changes in the next merge window. Changes since the RFC: - Sorted out the msm8976/msm8956, custom slopes are used only for msm8956, - Implemented proper support for msm8974/apq8084, - Added tsens_calibrate_common() and ops_v0_1 which can be used in common cases, - Removed superfluous identity hw_ids - Fixed calibration calculation in tsens_calibrate_nvmem() for ONE_PT_CALIB case Dmitry Baryshkov (15): dt-bindings: thermal: tsens: add msm8956 compat dt-bindings: thermal: tsens: support per-sensor calibration cells dt-bindings: thermal: tsens: add per-sensor cells for msm8974 thermal/drivers/tsens: Drop unnecessary hw_ids thermal/drivers/tsens: Drop msm8976-specific defines thermal/drivers/tsens: Sort out msm8976 vs msm8956 data thermal/drivers/tsens: Support using nvmem cells for calibration data thermal/drivers/tsens: Drop single-cell code for msm8939 thermal/drivers/tsens: Drop single-cell code for mdm9607 thermal/drivers/tsens: Drop single-cell code for msm8976/msm8956 thermal/drivers/tsens: Support using nvmem cells for msm8974 calibration arm64: dts: qcom: msm8916: specify per-sensor calibration cells arm64: dts: qcom: qcs404: specify per-sensor calibration cells ARM: dts: qcom-msm8974: specify per-sensor calibration cells ARM: dts: qcom-apq8084: specify per-sensor calibration cells .../bindings/thermal/qcom-tsens.yaml | 123 +++++++- arch/arm/boot/dts/qcom-apq8084.dtsi | 262 ++++++++++++++++- arch/arm/boot/dts/qcom-msm8974.dtsi | 262 ++++++++++++++++- arch/arm64/boot/dts/qcom/msm8916.dtsi | 70 ++++- arch/arm64/boot/dts/qcom/qcs404.dtsi | 121 +++++++- drivers/thermal/qcom/tsens-v0_1.c | 267 ++++-------------- drivers/thermal/qcom/tsens-v1.c | 190 +++---------- drivers/thermal/qcom/tsens.c | 102 +++++++ drivers/thermal/qcom/tsens.h | 8 +- 9 files changed, 1002 insertions(+), 403 deletions(-)