mbox series

[V2,0/2] Add interconnect support for QCS8300 SoC

Message ID 20240906151534.6418-1-quic_rlaggysh@quicinc.com
Headers show
Series Add interconnect support for QCS8300 SoC | expand

Message

Raviteja Laggyshetty Sept. 6, 2024, 3:15 p.m. UTC 
Add interconnect dtbindings and driver support for Qualcomm QCS8300 SoC.

Changes since V1:
 - constify all the array of pointers to structures and provider
   descriptor structures.
 - Dropped all empty nodes.
 - Added reg as required property for all the providers excluding
   clk-virt and mc-virt in dt-bindings.

Raviteja Laggyshetty (2):
  dt-bindings: interconnect: Add compatibles for QCS8300 SoC
  interconnect: qcom: add QCS8300 interconnect provider driver

 .../interconnect/qcom,qcs8300-rpmh.yaml       |   72 +
 drivers/interconnect/qcom/Kconfig             |   11 +
 drivers/interconnect/qcom/Makefile            |    2 +
 drivers/interconnect/qcom/qcs8300.c           | 2088 +++++++++++++++++
 drivers/interconnect/qcom/qcs8300.h           |  177 ++
 .../interconnect/qcom,qcs8300-rpmh.h          |  189 ++
 6 files changed, 2539 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,qcs8300-rpmh.yaml
 create mode 100644 drivers/interconnect/qcom/qcs8300.c
 create mode 100644 drivers/interconnect/qcom/qcs8300.h
 create mode 100644 include/dt-bindings/interconnect/qcom,qcs8300-rpmh.h

Comments

Krzysztof Kozlowski Sept. 6, 2024, 4:49 p.m. UTC | #1 
On 06/09/2024 17:15, Raviteja Laggyshetty wrote:
> QCS8300 SoC has several bus fabrics that could be controlled
> and tuned dynamically according to the bandwidth demand.

You got quite precise review about subject, which you partially
implemented and then added something more redundant. Look, this is
supposed to be device name. Add QCS8300 RPMh NoC. Drop redundant
information.



> 
> Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com>
> ---
>  .../interconnect/qcom,qcs8300-rpmh.yaml       |  72 +++++++
>  .../interconnect/qcom,qcs8300-rpmh.h          | 189 ++++++++++++++++++
>  2 files changed, 261 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,qcs8300-rpmh.yaml
>  create mode 100644 include/dt-bindings/interconnect/qcom,qcs8300-rpmh.h
> 
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,qcs8300-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,qcs8300-rpmh.yaml
> new file mode 100644
> index 000000000000..2759b003ebcf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,qcs8300-rpmh.yaml
> @@ -0,0 +1,72 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interconnect/qcom,qcs8300-rpmh.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies, Inc. RPMh Network-On-Chip Interconnect on QCS8300

Isn't this just "Qualcomm"? How is in most of other bindings?

I asked not to send us your downstream stuff. I said it about driver,
though... so repeat here: Do not send downstream code, but work on
upstream and use upstream style. This applies to all patches: drivers,
DTS, bindings, everything. So which upstream binding was used as
template for this one here?

Best regards,
Krzysztof