From patchwork Fri Nov 21 09:29:51 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 41291 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f197.google.com (mail-lb0-f197.google.com [209.85.217.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id CE22A23C27 for ; Fri, 21 Nov 2014 09:30:10 +0000 (UTC) Received: by mail-lb0-f197.google.com with SMTP id b6sf2736943lbj.8 for ; Fri, 21 Nov 2014 01:30:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=FDhpuVT2SfK+Wc29xwTEwGHjZhy85D7bIdTKKiC0p3w=; b=UyD7ggBx8QJY4GJWDy43PEjVE2TvVyQ2O3yktM9hivRPlAwPLMalYjdj3tB/tVDlvx 5PgfYIFY3oNc7LJga5UJjqS8mmcW4zwX0eNcuMQ1jR9AENuaMt4P93xfCizRK86PWjSA oDg0eJDbxV9siAIaGJ/CqwmfJdbhYIp1j+3ey3FcHy3Kiydj/vCvFrDRepm88ZhJDFOR uAKMWWSGbeMtTPeYMZ4KGqYqC1uPv6iK/gDGjUuJrRB82pvKF1LAvuHeN/DTADAoYpBL AyCSLUdelHzVper1QYODcgpFj7gvWWErvw60Fvpb6gM9DsP/GGUO8IJy1LKWahQrnvvJ lV3g== X-Gm-Message-State: ALoCoQlEmWChPyFq6AtLtZFkOdUWCJDKJSYu8AsTHYgzJU/HLoV4KdiurgSYqCYXj+ecPAOopyDm X-Received: by 10.152.29.226 with SMTP id n2mr466744lah.9.1416562209831; Fri, 21 Nov 2014 01:30:09 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.42.137 with SMTP id o9ls142505lal.17.gmail; Fri, 21 Nov 2014 01:30:09 -0800 (PST) X-Received: by 10.152.204.70 with SMTP id kw6mr2090021lac.85.1416562209619; Fri, 21 Nov 2014 01:30:09 -0800 (PST) Received: from mail-la0-f48.google.com (mail-la0-f48.google.com. [209.85.215.48]) by mx.google.com with ESMTPS id c6si4529825laa.50.2014.11.21.01.30.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 21 Nov 2014 01:30:08 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.48 as permitted sender) client-ip=209.85.215.48; Received: by mail-la0-f48.google.com with SMTP id s18so3948681lam.35 for ; Fri, 21 Nov 2014 01:30:08 -0800 (PST) X-Received: by 10.112.14.69 with SMTP id n5mr3142034lbc.34.1416562208436; Fri, 21 Nov 2014 01:30:08 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp51950lbc; Fri, 21 Nov 2014 01:30:07 -0800 (PST) X-Received: by 10.66.169.209 with SMTP id ag17mr5227509pac.62.1416562206845; Fri, 21 Nov 2014 01:30:06 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ye3si7208436pab.141.2014.11.21.01.30.05 for ; Fri, 21 Nov 2014 01:30:06 -0800 (PST) Received-SPF: none (google.com: linux-acpi-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755073AbaKUJaE (ORCPT + 6 others); Fri, 21 Nov 2014 04:30:04 -0500 Received: from mail-wg0-f44.google.com ([74.125.82.44]:49020 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753610AbaKUJaB (ORCPT ); Fri, 21 Nov 2014 04:30:01 -0500 Received: by mail-wg0-f44.google.com with SMTP id b13so6007112wgh.31 for ; Fri, 21 Nov 2014 01:29:57 -0800 (PST) X-Received: by 10.180.228.37 with SMTP id sf5mr23845123wic.35.1416562197071; Fri, 21 Nov 2014 01:29:57 -0800 (PST) Received: from localhost.localdomain ([109.215.21.36]) by mx.google.com with ESMTPSA id pj4sm7259002wjb.16.2014.11.21.01.29.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 21 Nov 2014 01:29:56 -0800 (PST) From: Daniel Lezcano To: rjw@rjwysocki.net Cc: linux-pm@vger.kernel.org, linaro-kernel@lists.linaro.org, linux-acpi@vger.kernel.org Subject: [PATCH 1/2] cpuidle: acpi: Remove TIME_INVALID flag from acpi Date: Fri, 21 Nov 2014 10:29:51 +0100 Message-Id: <1416562192-14114-1-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 1.9.1 Sender: linux-acpi-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: daniel.lezcano@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.48 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The commit 8e92b6605d introduced the TIME_VALID flag for the C1 state if this one is a mwait state assuming the interrupt will be enabled before reading the end time of the idle state. The changelog of this commit mention a potential problem with the menu governor but not a real observation and I assume it described an old code as the commit is from 2008. I have been digging through the code and I didn't find any place where the interrupts are enabled before reading the time. Moreover with the changes in the meantime, we moved the time measurements in the cpuidle core as well as the interrupts enabling making sure the time is measured before the interrupt are enabled again in a single place. Remove this test as the time measurement is always valid for this state. Signed-off-by: Daniel Lezcano --- drivers/acpi/processor_idle.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c index 380b4b4..7afba40 100644 --- a/drivers/acpi/processor_idle.c +++ b/drivers/acpi/processor_idle.c @@ -985,8 +985,6 @@ static int acpi_processor_setup_cpuidle_states(struct acpi_processor *pr) state->flags = 0; switch (cx->type) { case ACPI_STATE_C1: - if (cx->entry_method != ACPI_CSTATE_FFH) - state->flags |= CPUIDLE_FLAG_TIME_INVALID; state->enter = acpi_idle_enter_c1; state->enter_dead = acpi_idle_play_dead;