From patchwork Wed Aug 28 13:03:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 172380 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp720698ily; Wed, 28 Aug 2019 06:03:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqx80z5LtHD12u1RpWnlA++zbw3RutqxsF4n0ExOvCzPQ/OU25VllyFh+KPQYenFoyhS9hzZ X-Received: by 2002:a17:902:8345:: with SMTP id z5mr4394308pln.29.1566997407434; Wed, 28 Aug 2019 06:03:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566997407; cv=none; d=google.com; s=arc-20160816; b=InaKQkZH8S5y8iPw7Ec6IiCmNoSB9RS3qZ8pHa4e+GlyyaJLe6ZitPZPQjoziVJqpQ zVYC9hFeuB7Q52gJeI8W9H8LaULiO2xTZVG+cf97Bq5fvj7MO8xCCeBvB0mMKdSlpNCA rqAI0AhM4xDN5w/ZoqwMaHp+9hn2ONx3dwKHX9v6zgu0iI9SQd8M5DGCySCMZXmaJxQP 9J0lZ4F8FhTi85sHsCmks3CEv/Zq39UpCq3Zfsa9kNKjzljz1N2/sjxscRjFwr0LYaxD daKskZSlKhd42TNLy2sQoNEqH11Za4TulfY+sR8iwcudXulZ9/vsdi8qgIT8LDN4osmD e8hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=nIsAD2jrdv3GWU+XpMnbWArsSUMuLPLW074MYJq6+hw=; b=ozpXHafgGa7i9zW1CsmoBG7MOl9ppH7+sn1TqQ+CRPRWMkHBs+Rv5/4gK0BKD18V4o UXzW7Wr2Y6ehQ2Pi6exc2YtFLXpFzCR8lQftPKX7LfHASYqYRU2a0D1dyJI+kplVw80q dSG6UQGWB6wgddlhsj077xMJoPuSanAPAVBIf+VoEBqc0G1nPfxK9M9WXBKaJ68+gR8z 2M57Kmv8ShnFeeqaS3tZJiwzFQDuLHwbC3xEWgUMQ8QGlYpENRu96ALJ3vSMMDYBeLcZ VOJFgwe1lDvjAUlN7srwRQkW159yLrBU4qimkEoaGthaCLwPFsXznP7Grhqt9YIFUMOz Fjyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rGcgVHgP; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c127si2110200pga.569.2019.08.28.06.03.27; Wed, 28 Aug 2019 06:03:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rGcgVHgP; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726382AbfH1ND0 (ORCPT + 11 others); Wed, 28 Aug 2019 09:03:26 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:45384 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726253AbfH1ND0 (ORCPT ); Wed, 28 Aug 2019 09:03:26 -0400 Received: by mail-lj1-f193.google.com with SMTP id l1so2449797lji.12 for ; Wed, 28 Aug 2019 06:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nIsAD2jrdv3GWU+XpMnbWArsSUMuLPLW074MYJq6+hw=; b=rGcgVHgPS6hX6E7/vevKgSLV51Zjxkke/x4aX8m7m+vhGoAH6PbZq6cYqLmUBrCfVh WntQvDQvER2jPYwo1T8VyHr2FHESFFvAdH7C8sQ70F8x6pU+G/E79fXAEP6c5BcIVC3t QQvPjPMkFdp1dw4sirIGBFpMehW3tiHdKpqscq1VDZcwTX2n4UswzRNCqnxEIeX5QeN3 XcPnJULKibvcLxgGQKSbX/mcRB2uChYHWRhsQOCRyQOdc31TvyqZZfFMoHCtgFeBEILG JkN0Qr8EBBXufMm/tM6hdDDsjADlzQdHy7uEPD3uwuzgROwk7IB5hInjJiSPuGYxdMhB ToXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nIsAD2jrdv3GWU+XpMnbWArsSUMuLPLW074MYJq6+hw=; b=NLcIstY5nrIqk9wJQHgVPZuShQqML56bhwvZEYn/8FhV5UGv4LOL0sysKvoLhve+S/ kk0eTWgVL5cKKXFVZTcK4RXK2GQkKKtOpz6a3dojTXx1xZ3S5JlSHpl9FZkm8KTboc9K +CWtQOx9+JiUkp9kdilYEO0szhQhfcCDiyFSZnsqnUJetI/iCgGtrZXOQ5AiL0dK6M3m o8bPA1qIQucokG645znB7viXG8RpyPkDjCxNEkxzqAZyB5sDhbPC/VEiVZTSCMpmAR+2 WijrkBCkB8dA6+ouvAO2ZMU2PieP1eG2Id6Qow1DrMvCdWQTs3lAYnXMKqXoRd1JpVUu hQzg== X-Gm-Message-State: APjAAAVGyn5rpCIaQUay9dnFdLCr9VzzRzXtSRqcUWu4yhcvHO8Z/gAQ AfnwFPojQpmKUMHyJydDgN3NEg== X-Received: by 2002:a2e:8ed2:: with SMTP id e18mr1977275ljl.82.1566997403181; Wed, 28 Aug 2019 06:03:23 -0700 (PDT) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id 18sm843611lfy.26.2019.08.28.06.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 06:03:22 -0700 (PDT) From: Linus Walleij To: Zhang Rui , Eduardo Valentin , Daniel Lezcano Cc: linux-pm@vger.kernel.org, Linus Walleij , Vincent Guittot , Lee Jones Subject: [PATCH 1/3 v4] thermal: db8500: Finalize device tree conversion Date: Wed, 28 Aug 2019 15:03:18 +0200 Message-Id: <20190828130320.6174-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org At some point there was an attempt to convert the DB8500 thermal sensor to device tree: a probe path was added and the device tree was augmented for the Snowball board. The switchover was never completed: instead the thermal devices came from from the PRCMU MFD device and the probe on the Snowball was confused as another set of configuration appeared from the device tree. Move over to a device-tree only approach, as we fixed up the device trees. Cc: Vincent Guittot Acked-by: Lee Jones Reviewed-by: Daniel Lezcano Signed-off-by: Linus Walleij --- ChangeLog v3->v4: - No change, resending with the rest of the patches ChangeLog v2->v3: - Collected Daniel's ACK. ChangeLog v1->v2: - No change, resending with the rest of the patches --- drivers/mfd/db8500-prcmu.c | 53 +------------------- drivers/thermal/Kconfig | 2 +- drivers/thermal/db8500_thermal.c | 30 +++++------ include/linux/platform_data/db8500_thermal.h | 29 ----------- 4 files changed, 17 insertions(+), 97 deletions(-) delete mode 100644 include/linux/platform_data/db8500_thermal.h -- 2.21.0 diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c index 3f21e26b8d36..a1e09bf06977 100644 --- a/drivers/mfd/db8500-prcmu.c +++ b/drivers/mfd/db8500-prcmu.c @@ -36,7 +36,6 @@ #include #include #include -#include #include "dbx500-prcmu-regs.h" /* Index of different voltages to be used when accessing AVSData */ @@ -2982,53 +2981,6 @@ static struct ux500_wdt_data db8500_wdt_pdata = { .timeout = 600, /* 10 minutes */ .has_28_bits_resolution = true, }; -/* - * Thermal Sensor - */ - -static struct resource db8500_thsens_resources[] = { - { - .name = "IRQ_HOTMON_LOW", - .start = IRQ_PRCMU_HOTMON_LOW, - .end = IRQ_PRCMU_HOTMON_LOW, - .flags = IORESOURCE_IRQ, - }, - { - .name = "IRQ_HOTMON_HIGH", - .start = IRQ_PRCMU_HOTMON_HIGH, - .end = IRQ_PRCMU_HOTMON_HIGH, - .flags = IORESOURCE_IRQ, - }, -}; - -static struct db8500_thsens_platform_data db8500_thsens_data = { - .trip_points[0] = { - .temp = 70000, - .type = THERMAL_TRIP_ACTIVE, - .cdev_name = { - [0] = "thermal-cpufreq-0", - }, - }, - .trip_points[1] = { - .temp = 75000, - .type = THERMAL_TRIP_ACTIVE, - .cdev_name = { - [0] = "thermal-cpufreq-0", - }, - }, - .trip_points[2] = { - .temp = 80000, - .type = THERMAL_TRIP_ACTIVE, - .cdev_name = { - [0] = "thermal-cpufreq-0", - }, - }, - .trip_points[3] = { - .temp = 85000, - .type = THERMAL_TRIP_CRITICAL, - }, - .num_trips = 4, -}; static const struct mfd_cell common_prcmu_devs[] = { { @@ -3052,10 +3004,7 @@ static const struct mfd_cell db8500_prcmu_devs[] = { }, { .name = "db8500-thermal", - .num_resources = ARRAY_SIZE(db8500_thsens_resources), - .resources = db8500_thsens_resources, - .platform_data = &db8500_thsens_data, - .pdata_size = sizeof(db8500_thsens_data), + .of_compatible = "stericsson,db8500-thermal", }, }; diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 9966364a6deb..001a21abcc28 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -310,7 +310,7 @@ config DOVE_THERMAL config DB8500_THERMAL tristate "DB8500 thermal management" - depends on MFD_DB8500_PRCMU + depends on MFD_DB8500_PRCMU && OF default y help Adds DB8500 thermal management implementation according to the thermal diff --git a/drivers/thermal/db8500_thermal.c b/drivers/thermal/db8500_thermal.c index b71a999d17d6..d650ae5fdf2a 100644 --- a/drivers/thermal/db8500_thermal.c +++ b/drivers/thermal/db8500_thermal.c @@ -13,13 +13,24 @@ #include #include #include -#include #include #include #include #define PRCMU_DEFAULT_MEASURE_TIME 0xFFF #define PRCMU_DEFAULT_LOW_TEMP 0 +#define COOLING_DEV_MAX 8 + +struct db8500_trip_point { + unsigned long temp; + enum thermal_trip_type type; + char cdev_name[COOLING_DEV_MAX][THERMAL_NAME_LENGTH]; +}; + +struct db8500_thsens_platform_data { + struct db8500_trip_point trip_points[THERMAL_MAX_TRIPS]; + int num_trips; +}; struct db8500_thermal_zone { struct thermal_zone_device *therm_dev; @@ -301,7 +312,6 @@ static void db8500_thermal_work(struct work_struct *work) dev_dbg(&pzone->therm_dev->device, "thermal work finished.\n"); } -#ifdef CONFIG_OF static struct db8500_thsens_platform_data* db8500_thermal_parse_dt(struct platform_device *pdev) { @@ -370,13 +380,6 @@ static struct db8500_thsens_platform_data* dev_err(&pdev->dev, "Parsing device tree data error.\n"); return NULL; } -#else -static inline struct db8500_thsens_platform_data* - db8500_thermal_parse_dt(struct platform_device *pdev) -{ - return NULL; -} -#endif static int db8500_thermal_probe(struct platform_device *pdev) { @@ -386,11 +389,10 @@ static int db8500_thermal_probe(struct platform_device *pdev) int low_irq, high_irq, ret = 0; unsigned long dft_low, dft_high; - if (np) - ptrips = db8500_thermal_parse_dt(pdev); - else - ptrips = dev_get_platdata(&pdev->dev); + if (!np) + return -EINVAL; + ptrips = db8500_thermal_parse_dt(pdev); if (!ptrips) return -EINVAL; @@ -498,13 +500,11 @@ static int db8500_thermal_resume(struct platform_device *pdev) return 0; } -#ifdef CONFIG_OF static const struct of_device_id db8500_thermal_match[] = { { .compatible = "stericsson,db8500-thermal" }, {}, }; MODULE_DEVICE_TABLE(of, db8500_thermal_match); -#endif static struct platform_driver db8500_thermal_driver = { .driver = { diff --git a/include/linux/platform_data/db8500_thermal.h b/include/linux/platform_data/db8500_thermal.h deleted file mode 100644 index 55e55750a165..000000000000 --- a/include/linux/platform_data/db8500_thermal.h +++ /dev/null @@ -1,29 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ -/* - * db8500_thermal.h - DB8500 Thermal Management Implementation - * - * Copyright (C) 2012 ST-Ericsson - * Copyright (C) 2012 Linaro Ltd. - * - * Author: Hongbo Zhang - */ - -#ifndef _DB8500_THERMAL_H_ -#define _DB8500_THERMAL_H_ - -#include - -#define COOLING_DEV_MAX 8 - -struct db8500_trip_point { - unsigned long temp; - enum thermal_trip_type type; - char cdev_name[COOLING_DEV_MAX][THERMAL_NAME_LENGTH]; -}; - -struct db8500_thsens_platform_data { - struct db8500_trip_point trip_points[THERMAL_MAX_TRIPS]; - int num_trips; -}; - -#endif /* _DB8500_THERMAL_H_ */