From patchwork Sat Jul 9 22:32:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 589119 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2755C43334 for ; Sat, 9 Jul 2022 22:32:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229537AbiGIWcq (ORCPT ); Sat, 9 Jul 2022 18:32:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229588AbiGIWcp (ORCPT ); Sat, 9 Jul 2022 18:32:45 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33E6D1759F for ; Sat, 9 Jul 2022 15:32:44 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id v67-20020a1cac46000000b003a1888b9d36so3043785wme.0 for ; Sat, 09 Jul 2022 15:32:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linexp-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7UKKS5f7QbJpxlk+iXwxbcq70b7aqG7EJc4B5ZEy8YU=; b=K3WpTj9IS4oPO/xbKdn90VqUsZ5OqorLd/R+V9gn4eVgJYfr7JCn1opHg3Yu3q2JKk CsZYAuRX31p6y6hWTAGpAWkTMDXLg3vVMgpMULT6TRcgbDuBDpxvoYfCKTaQzSVurlQH ZpwEZCaRrprG9k+X4XTjVVCya4BtHd8QSQtY79IL63j52rf9oiCd46ZK8kItgvOvfSjw hUlUSM8p04IA08iOp2WRa0+hxCSXm3VmDnIDeqkC/qCJjQqUeZd8M57ic8M+rQXjmq9z QFpqpnj6xuIRi4qejPwJL2MYkHMW2gKzZMEGMOZIzT9+3aFCAMw2Fxc3cOJVGZ6OQk5c V8iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7UKKS5f7QbJpxlk+iXwxbcq70b7aqG7EJc4B5ZEy8YU=; b=oZ/CFatwZE9/qhv9kWB4a5mxsA09Ps8JsPgqNIRLH4z+XzziMNL8WkzYRHThP9ELyd JKmKv+wxQlCnp7FqxqSZ1Ku48CU/BbRUCbcjBY/ZIF1bN5YWG2uMbB6XHxbNIsb8j/OC Gso139Osjyyi6p7tT+RXUfttmbgq+qGmqFVD62ttWLORE9LuGcLCL8+hUGxplEa2r8KZ O8MZU162/xpDFkMpGY0YyTSavP/8QI0G7O7aC/rkLrF1xhVePj4fGAA0ZqiyWT3rlX36 QKxU7Hm/hhGysWRxpzm6xr1+zBoerAjNcHoTtB0jOMMVftWmx4LgbSAQfykoktAwo90z 5hwA== X-Gm-Message-State: AJIora99y9RxAOnZpVnxcuo53n/c7OtGuB+/DodYBcT5CFF6hJCyaWvr C4yJEkSZfDolNwHbYEiPvplrRvRPy/A2Hw== X-Google-Smtp-Source: AGRyM1syNknWUeDtrb2zQ0mSXavdYoNhvvHnt/MZKAWdXrFo8uNvNeBGeUFitcifm5x9u5JPmkFmfg== X-Received: by 2002:a05:600c:4e8b:b0:3a0:5826:3321 with SMTP id f11-20020a05600c4e8b00b003a058263321mr7572674wmq.108.1657405962755; Sat, 09 Jul 2022 15:32:42 -0700 (PDT) Received: from localhost.localdomain (146725694.box.freepro.com. [130.180.211.218]) by smtp.gmail.com with ESMTPSA id w15-20020a1cf60f000000b003a2c7bf0497sm2525342wmc.16.2022.07.09.15.32.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Jul 2022 15:32:42 -0700 (PDT) From: Daniel Lezcano To: daniel.lezcano@linaro.org, rafael@kernel.org Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, khilman@baylibre.com, abailon@baylibre.com, lukasz.luba@arm.com, Amit Kucheria Subject: [PATCH v4 01/12] thermal/core: Remove duplicate information when an error occurs Date: Sun, 10 Jul 2022 00:32:18 +0200 Message-Id: <20220709223229.1619339-2-daniel.lezcano@linexp.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220709223229.1619339-1-daniel.lezcano@linexp.org> References: <20220709223229.1619339-1-daniel.lezcano@linexp.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The pr_err already tells it is an error, it is pointless to add the 'Error:' string in the messages. Remove them. Cc: Alexandre Bailon Cc: Kevin Hilman Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- drivers/thermal/thermal_core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index cdc0552e8c42..e22e7d939c54 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -1198,23 +1198,23 @@ thermal_zone_device_register(const char *type, int trips, int mask, struct thermal_governor *governor; if (!type || strlen(type) == 0) { - pr_err("Error: No thermal zone type defined\n"); + pr_err("No thermal zone type defined\n"); return ERR_PTR(-EINVAL); } if (type && strlen(type) >= THERMAL_NAME_LENGTH) { - pr_err("Error: Thermal zone name (%s) too long, should be under %d chars\n", + pr_err("Thermal zone name (%s) too long, should be under %d chars\n", type, THERMAL_NAME_LENGTH); return ERR_PTR(-EINVAL); } if (trips > THERMAL_MAX_TRIPS || trips < 0 || mask >> trips) { - pr_err("Error: Incorrect number of thermal trips\n"); + pr_err("Incorrect number of thermal trips\n"); return ERR_PTR(-EINVAL); } if (!ops) { - pr_err("Error: Thermal zone device ops not defined\n"); + pr_err("Thermal zone device ops not defined\n"); return ERR_PTR(-EINVAL); }