| Message ID | 20230106073313.1720029-2-dmitry.baryshkov@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | clk/interconnect: qcom: finish migration of IP0 to clocks | expand |
On 06/01/2023 15:39, Alex Elder wrote: > On 1/6/23 1:33 AM, Dmitry Baryshkov wrote: >> Follow the example of sc7180 and sdx55 and implement IP0 resource as >> clocks rather than interconnects. >> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > So this is simply adding these clocks? Were they not > defined/implemented as interconnects before? (It > isn't clear from your message above, and I just want > to be sure there's no duplication.) Well, that's the point of the patchset: to turn them from ICC to clock. I can change the order of the patches in the patchset, if you think it will make it more obvious. > > -Alex > >> --- >> drivers/clk/qcom/clk-rpmh.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c >> index 586a810c682c..5f914cf36b10 100644 >> --- a/drivers/clk/qcom/clk-rpmh.c >> +++ b/drivers/clk/qcom/clk-rpmh.c >> @@ -445,6 +445,7 @@ static struct clk_hw *sm8150_rpmh_clocks[] = { >> [RPMH_RF_CLK2_A] = &clk_rpmh_rf_clk2_a_ao.hw, >> [RPMH_RF_CLK3] = &clk_rpmh_rf_clk3_a.hw, >> [RPMH_RF_CLK3_A] = &clk_rpmh_rf_clk3_a_ao.hw, >> + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw, >> }; >> static const struct clk_rpmh_desc clk_rpmh_sm8150 = { >> @@ -484,6 +485,7 @@ static struct clk_hw *sc8180x_rpmh_clocks[] = { >> [RPMH_RF_CLK2_A] = &clk_rpmh_rf_clk2_d_ao.hw, >> [RPMH_RF_CLK3] = &clk_rpmh_rf_clk3_d.hw, >> [RPMH_RF_CLK3_A] = &clk_rpmh_rf_clk3_d_ao.hw, >> + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw, >> }; >> static const struct clk_rpmh_desc clk_rpmh_sc8180x = { >> @@ -504,6 +506,7 @@ static struct clk_hw *sm8250_rpmh_clocks[] = { >> [RPMH_RF_CLK1_A] = &clk_rpmh_rf_clk1_a_ao.hw, >> [RPMH_RF_CLK3] = &clk_rpmh_rf_clk3_a.hw, >> [RPMH_RF_CLK3_A] = &clk_rpmh_rf_clk3_a_ao.hw, >> + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw, >> }; >> static const struct clk_rpmh_desc clk_rpmh_sm8250 = { >> @@ -546,6 +549,7 @@ static struct clk_hw *sc8280xp_rpmh_clocks[] = { >> [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw, >> [RPMH_PKA_CLK] = &clk_rpmh_pka.hw, >> [RPMH_HWKM_CLK] = &clk_rpmh_hwkm.hw, >> + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw, >> }; >> static const struct clk_rpmh_desc clk_rpmh_sc8280xp = { >
diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c index 586a810c682c..5f914cf36b10 100644 --- a/drivers/clk/qcom/clk-rpmh.c +++ b/drivers/clk/qcom/clk-rpmh.c @@ -445,6 +445,7 @@ static struct clk_hw *sm8150_rpmh_clocks[] = { [RPMH_RF_CLK2_A] = &clk_rpmh_rf_clk2_a_ao.hw, [RPMH_RF_CLK3] = &clk_rpmh_rf_clk3_a.hw, [RPMH_RF_CLK3_A] = &clk_rpmh_rf_clk3_a_ao.hw, + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw, }; static const struct clk_rpmh_desc clk_rpmh_sm8150 = { @@ -484,6 +485,7 @@ static struct clk_hw *sc8180x_rpmh_clocks[] = { [RPMH_RF_CLK2_A] = &clk_rpmh_rf_clk2_d_ao.hw, [RPMH_RF_CLK3] = &clk_rpmh_rf_clk3_d.hw, [RPMH_RF_CLK3_A] = &clk_rpmh_rf_clk3_d_ao.hw, + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw, }; static const struct clk_rpmh_desc clk_rpmh_sc8180x = { @@ -504,6 +506,7 @@ static struct clk_hw *sm8250_rpmh_clocks[] = { [RPMH_RF_CLK1_A] = &clk_rpmh_rf_clk1_a_ao.hw, [RPMH_RF_CLK3] = &clk_rpmh_rf_clk3_a.hw, [RPMH_RF_CLK3_A] = &clk_rpmh_rf_clk3_a_ao.hw, + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw, }; static const struct clk_rpmh_desc clk_rpmh_sm8250 = { @@ -546,6 +549,7 @@ static struct clk_hw *sc8280xp_rpmh_clocks[] = { [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw, [RPMH_PKA_CLK] = &clk_rpmh_pka.hw, [RPMH_HWKM_CLK] = &clk_rpmh_hwkm.hw, + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw, }; static const struct clk_rpmh_desc clk_rpmh_sc8280xp = {
Follow the example of sc7180 and sdx55 and implement IP0 resource as clocks rather than interconnects. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/clk/qcom/clk-rpmh.c | 4 ++++ 1 file changed, 4 insertions(+)