From patchwork Tue May 30 11:42:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yi-ming Tseng X-Patchwork-Id: 688114 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81495C7EE23 for ; Tue, 30 May 2023 11:43:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229509AbjE3LnP (ORCPT ); Tue, 30 May 2023 07:43:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229980AbjE3LnI (ORCPT ); Tue, 30 May 2023 07:43:08 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF4EAF7 for ; Tue, 30 May 2023 04:42:40 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-babb53e6952so8543172276.0 for ; Tue, 30 May 2023 04:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685446960; x=1688038960; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=X9Fa1azB0PvxCnVWP8BiPunu4QSKYBQpUml6svSnRR4=; b=tBbXFhsb+KwoE9oe/RBk2v9mdJuTTIDySqRMyshEKtOzMZvFQaKqltj5sHLfNCbB7U DAAnKAtemaLVdaOI4iW473fBsrZybhyclZ+xr5O5b5ENY90G32ktqV0H86QR+iIXtzHZ OeZMWLokaN5xEqQJSKTtN5JZAGE0sJsN67LbpXNt3j89caN3+QHCC3fheu7jptCiaE1N zXmwIAk8D8alYIKgLnyC5NuPITFrGAqUPWD9shoJve99mTL4DpTjJD0+CZkCSk1p4Kn/ fzz2nq26+v2YkNnOA9jUr65xWuXorZL00/yxEw6yG9oS9pifrM1lHyzOIblXi11t1KVx mWcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685446960; x=1688038960; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=X9Fa1azB0PvxCnVWP8BiPunu4QSKYBQpUml6svSnRR4=; b=UZo/FSEDQCPCv+Y9xbQInDNFaZEOIqFTl1hUEQvX6AT4DLRIbbozv+RpxX1jCf/wO8 aAyUTWraQnwNlw/7zgCtu/cVGVMGZVyVhEd/XQGr+tyrfd1oZk72BQgF0ssmm6CxIjG/ yBzP66v7tKzOHUQJeQeK1sB+9O8EnHtPgCZusAY2kBH3R4eIubNDoQ9NXEl+8gKZhDXj P8oTTqutOzK+h44pVHXotNWe0Z3TdTteudsCjut07xxazyE/eajFRA6HutXFPNkC0mRD DcyIEVmOWwColy41JnsrhTm3M9FHHJiPdA/mAvJWmLajUveOy9/oMmUR9EzZ7EZATNEL 9sfw== X-Gm-Message-State: AC+VfDwwvHVXCh3NLP/8EnvbqD+9HyCpbca4FprjxE29JWEwObufc3Je J2TJ/0cZTW1HPtx/dBRBfSINEfd1lQw9nvXF9g== X-Google-Smtp-Source: ACHHUZ61DYYTIxHM9/yfJ8LhkISK/Pm2f97cTxhbRcqoigrVG6nrYMSvNoZa3zX10Nsp+ldtZk1OSPfsxu8uNWUMWw== X-Received: from yimingtseng2023.c.googlers.com ([fda3:e722:ac3:cc00:4f:4b78:c0a8:94c]) (user=yimingtseng job=sendgmr) by 2002:a25:d88:0:b0:ba8:373e:acf1 with SMTP id 130-20020a250d88000000b00ba8373eacf1mr1217056ybn.12.1685446959912; Tue, 30 May 2023 04:42:39 -0700 (PDT) Date: Tue, 30 May 2023 11:42:16 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.41.0.rc0.172.g3f132b7071-goog Message-ID: <20230530114216.1420790-1-yimingtseng@google.com> Subject: [PATCH] PM: domains: fix overflow in genpd_parse_state From: YiMing Tseng To: "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , Len Brown , Pavel Machek , Greg Kroah-Hartman Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, marscheng@google.com, YiMing Tseng Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Add type casters to prevent 32-bit overflow before assigning to s64 variables. It allows full 32-bit range support for latency and residency. Signed-off-by: YiMing Tseng --- drivers/base/power/domain.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 32084e38b73d..26a04cd8d8dc 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -2939,10 +2939,10 @@ static int genpd_parse_state(struct genpd_power_state *genpd_state, err = of_property_read_u32(state_node, "min-residency-us", &residency); if (!err) - genpd_state->residency_ns = 1000 * residency; + genpd_state->residency_ns = (s64)1000 * residency; - genpd_state->power_on_latency_ns = 1000 * exit_latency; - genpd_state->power_off_latency_ns = 1000 * entry_latency; + genpd_state->power_on_latency_ns = (s64)1000 * exit_latency; + genpd_state->power_off_latency_ns = (s64)1000 * entry_latency; genpd_state->fwnode = &state_node->fwnode; return 0;