| Message ID | 20230830-fp5-initial-v1-11-5a954519bbad@fairphone.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Initial support for the Fairphone 5 smartphone | expand |
On 30/08/2023 11:58, Luca Weiss wrote: > Add device tree for the Fairphone 5 smartphone which is based on > the QCM6490 SoC. > ... > + > +#include <dt-bindings/arm/qcom,ids.h> > +#include <dt-bindings/leds/common.h> > +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h> > +#include <dt-bindings/regulator/qcom,rpmh-regulator.h> > +#include "sc7280.dtsi" > +#include "pm7250b.dtsi" > +#include "pm7325.dtsi" > +#include "pm8350c.dtsi" /* PM7350C */ > +#include "pmk8350.dtsi" /* PMK7325 */ > + > +/ { > + model = "Fairphone 5"; > + compatible = "fairphone,fp5", "qcom,qcm6490"; > + chassis-type = "handset"; > + > + /* required for bootloader to select correct board */ > + qcom,msm-id = <QCOM_ID_QCM6490 0x10000>; > + qcom,board-id = <34 0>; Sorry, not allowed. This is not an old, legacy platform. > + > + aliases { > + serial0 = &uart5; > + serial1 = &uart7; > + }; > + > + chosen { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + framebuffer0: framebuffer@a000000 { > + compatible = "simple-framebuffer"; > + reg = <0 0xe1000000 0 (2700 * 1224 * 4)>; > + width = <1224>; > + height = <2700>; > + stride = <(1224 * 4)>; > + format = "a8r8g8b8"; > + panel = <&panel>; > + clocks = <&gcc GCC_DISP_HF_AXI_CLK>; > + }; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + pinctrl-0 = <&volume_down_default>, <&hall_sensor_default>; > + pinctrl-names = "default"; > + > + key-volume-up { > + label = "Volume up"; > + gpios = <&pm7325_gpios 6 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_VOLUMEUP>; > + }; > + > + /* Hall sensor uses vreg_l8c as VDD, it's being enabled using Use Linux style comments: /* * foo * bar... > + * always-on on the regulator > + */ > + event-hall-sensor { > + label = "Hall Effect Sensor"; > + gpios = <&tlmm 155 GPIO_ACTIVE_LOW>; > + linux,input-type = <EV_SW>; > + linux,code = <SW_LID>; > + linux,can-disable; > + wakeup-source; > + }; > + }; > + > + panel: panel { > + compatible = "boe,rm692e5"; Undocumented. You cannot add nodes with undocumented compatibles. Drop. > + > + width-mm = <68>; > + height-mm = <150>; > + }; Best regards, Krzysztof
On 30.08.2023 11:58, Luca Weiss wrote: > Add device tree for the Fairphone 5 smartphone which is based on > the QCM6490 SoC. > > Supported features are, as of now: > * Bluetooth > * Debug UART > * Display via simplefb > * Flash/torch LED > * Flip cover sensor > * Power & volume buttons > * RTC > * SD card > * USB > * Various plumbing like regulators, i2c, spi, etc > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 659 +++++++++++++++++++++ > 2 files changed, 660 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 2cca20563a1d..73c3be0f8872 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -81,6 +81,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-lilac.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-maple.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-poplar.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8998-xiaomi-sagit.dtb > +dtb-$(CONFIG_ARCH_QCOM) += qcm6490-fairphone-fp5.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb > dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > new file mode 100644 > index 000000000000..572b254d3af2 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > @@ -0,0 +1,659 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2023, Luca Weiss <luca.weiss@fairphone.com> > + */ > + > +/dts-v1/; > + > +/* PM7250B is configured to use SID8/9 instead of SID2/3 */ > +#define PM7250B_SID 8 > +#define PM7250B_SID1 9 > + > +#include <dt-bindings/arm/qcom,ids.h> > +#include <dt-bindings/leds/common.h> > +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h> > +#include <dt-bindings/regulator/qcom,rpmh-regulator.h> > +#include "sc7280.dtsi" > +#include "pm7250b.dtsi" > +#include "pm7325.dtsi" > +#include "pm8350c.dtsi" /* PM7350C */ > +#include "pmk8350.dtsi" /* PMK7325 */ > + > +/ { > + model = "Fairphone 5"; > + compatible = "fairphone,fp5", "qcom,qcm6490"; > + chassis-type = "handset"; > + > + /* required for bootloader to select correct board */ > + qcom,msm-id = <QCOM_ID_QCM6490 0x10000>; > + qcom,board-id = <34 0>; Try [1], it worked for me on a picky device. > + > + aliases { > + serial0 = &uart5; > + serial1 = &uart7; > + }; > + > + chosen { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + framebuffer0: framebuffer@a000000 { > + compatible = "simple-framebuffer"; > + reg = <0 0xe1000000 0 (2700 * 1224 * 4)>; 0x0? > + width = <1224>; > + height = <2700>; > + stride = <(1224 * 4)>; > + format = "a8r8g8b8"; > + panel = <&panel>; > + clocks = <&gcc GCC_DISP_HF_AXI_CLK>; > + }; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + pinctrl-0 = <&volume_down_default>, <&hall_sensor_default>; > + pinctrl-names = "default"; > + > + key-volume-up { > + label = "Volume up"; > + gpios = <&pm7325_gpios 6 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_VOLUMEUP>; > + }; > + > + /* Hall sensor uses vreg_l8c as VDD, it's being enabled using > + * always-on on the regulator > + */ /* Powered by the always-on vreg_l8c */ - fits in a single line > + event-hall-sensor { > + label = "Hall Effect Sensor"; > + gpios = <&tlmm 155 GPIO_ACTIVE_LOW>; > + linux,input-type = <EV_SW>; > + linux,code = <SW_LID>; > + linux,can-disable; > + wakeup-source; > + }; > + }; > + > + panel: panel { > + compatible = "boe,rm692e5"; Undocumented compatbile > + > + width-mm = <68>; > + height-mm = <150>; > + }; > + > + reserved-memory { > + cont_splash_mem: cont-splash@e1000000 { > + reg = <0 0xe1000000 0 0x2300000>; 0x0 [...] > + vreg_s1b: smps1 { > + regulator-min-microvolt = <1840000>; > + regulator-max-microvolt = <2040000>; No regulator-initial-mode on this pmic? [...] > + > + /* PM8008 PMIC @ 8 and 9 */ > + /* Pixelworks @ 26 */ > + /* FSA4480 USB audio switch @ 42 */ There's a driver for the fsa4480, you may wanna include a node here > + /* AW86927FCR haptics @ 5a */ > +}; [...] > + > + led-0 { > + function = LED_FUNCTION_FLASH; No dual-tone stuff? > + color = <LED_COLOR_ID_WHITE>; > + led-sources = <1>, <4>; > + led-max-microamp = <500000>; > + flash-max-microamp = <1500000>; > + flash-max-timeout-us = <1280000>; > + }; > +}; > + > +&pmk8350_rtc { > + status = "okay"; > +}; > + > +&pon_pwrkey { > + status = "okay"; > +}; > + > +&pon_resin { > + status = "okay"; > + linux,code = <KEY_VOLUMEDOWN>; status last [...] > +&rmtfs_mem { > + qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>, <QCOM_SCM_VMID_NAV>; > + reg = <0x0 0xf8500000 0x0 0x600000>; > +}; /delete-node/ + redefinition would probably be cleaner-looking [...] > +&uart7 { > + /delete-property/interrupts; > + interrupts-extended = <&intc GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>, > + <&tlmm 31 IRQ_TYPE_EDGE_FALLING>; > + > + pinctrl-names = "default", "sleep"; > + pinctrl-1 = <&qup_uart7_sleep_cts>, <&qup_uart7_sleep_rts>, <&qup_uart7_sleep_tx>, <&qup_uart7_sleep_rx>; property-n property-names > + > + status = "okay"; > + > + bluetooth: bluetooth { > + compatible = "qcom,wcn6750-bt"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&bluetooth_enable_default>, <&sw_ctrl_default>; property-n property-names Konrad [1] https://lore.kernel.org/linux-arm-msm/9db02015-2c41-40d6-bf35-69ef277e9ce4@linaro.org/
On Wed Aug 30, 2023 at 12:45 PM CEST, Konrad Dybcio wrote: > On 30.08.2023 11:58, Luca Weiss wrote: > > Add device tree for the Fairphone 5 smartphone which is based on > > the QCM6490 SoC. > > > > Supported features are, as of now: > > * Bluetooth > > * Debug UART > > * Display via simplefb > > * Flash/torch LED > > * Flip cover sensor > > * Power & volume buttons > > * RTC > > * SD card > > * USB > > * Various plumbing like regulators, i2c, spi, etc > > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > --- > > arch/arm64/boot/dts/qcom/Makefile | 1 + > > arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 659 +++++++++++++++++++++ > > 2 files changed, 660 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > > index 2cca20563a1d..73c3be0f8872 100644 > > --- a/arch/arm64/boot/dts/qcom/Makefile > > +++ b/arch/arm64/boot/dts/qcom/Makefile > > @@ -81,6 +81,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-lilac.dtb > > dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-maple.dtb > > dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-poplar.dtb > > dtb-$(CONFIG_ARCH_QCOM) += msm8998-xiaomi-sagit.dtb > > +dtb-$(CONFIG_ARCH_QCOM) += qcm6490-fairphone-fp5.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb > > dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > > new file mode 100644 > > index 000000000000..572b254d3af2 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > > @@ -0,0 +1,659 @@ > > +// SPDX-License-Identifier: BSD-3-Clause > > +/* > > + * Copyright (c) 2023, Luca Weiss <luca.weiss@fairphone.com> > > + */ > > + > > +/dts-v1/; > > + > > +/* PM7250B is configured to use SID8/9 instead of SID2/3 */ > > +#define PM7250B_SID 8 > > +#define PM7250B_SID1 9 > > + > > +#include <dt-bindings/arm/qcom,ids.h> > > +#include <dt-bindings/leds/common.h> > > +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h> > > +#include <dt-bindings/regulator/qcom,rpmh-regulator.h> > > +#include "sc7280.dtsi" > > +#include "pm7250b.dtsi" > > +#include "pm7325.dtsi" > > +#include "pm8350c.dtsi" /* PM7350C */ > > +#include "pmk8350.dtsi" /* PMK7325 */ > > + > > +/ { > > + model = "Fairphone 5"; > > + compatible = "fairphone,fp5", "qcom,qcm6490"; > > + chassis-type = "handset"; > > + > > + /* required for bootloader to select correct board */ > > + qcom,msm-id = <QCOM_ID_QCM6490 0x10000>; > > + qcom,board-id = <34 0>; > Try [1], it worked for me on a picky device. Yes, that works! Thanks! > > > + > > + aliases { > > + serial0 = &uart5; > > + serial1 = &uart7; > > + }; > > + > > + chosen { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + ranges; > > + > > + framebuffer0: framebuffer@a000000 { > > + compatible = "simple-framebuffer"; > > + reg = <0 0xe1000000 0 (2700 * 1224 * 4)>; > 0x0? Ack > > > + width = <1224>; > > + height = <2700>; > > + stride = <(1224 * 4)>; > > + format = "a8r8g8b8"; > > + panel = <&panel>; > > + clocks = <&gcc GCC_DISP_HF_AXI_CLK>; > > + }; > > + }; > > + > > + gpio-keys { > > + compatible = "gpio-keys"; > > + > > + pinctrl-0 = <&volume_down_default>, <&hall_sensor_default>; > > + pinctrl-names = "default"; > > + > > + key-volume-up { > > + label = "Volume up"; > > + gpios = <&pm7325_gpios 6 GPIO_ACTIVE_LOW>; > > + linux,code = <KEY_VOLUMEUP>; > > + }; > > + > > + /* Hall sensor uses vreg_l8c as VDD, it's being enabled using > > + * always-on on the regulator > > + */ > /* Powered by the always-on vreg_l8c */ - fits in a single line Ack > > > + event-hall-sensor { > > + label = "Hall Effect Sensor"; > > + gpios = <&tlmm 155 GPIO_ACTIVE_LOW>; > > + linux,input-type = <EV_SW>; > > + linux,code = <SW_LID>; > > + linux,can-disable; > > + wakeup-source; > > + }; > > + }; > > + > > + panel: panel { > > + compatible = "boe,rm692e5"; > Undocumented compatbile Not quite sure how to document this properly. This dummy panel node is used for the simplefb/simpledrm so that user space can get panel dimensions already. This approach of a separate panel node was apparently preferred when the functionality was upstreamed but of course as can be seen this panel node is very barebones where many properties are not present which would be needed with the full panel driver (once it's working). Also for example for the bindings I think width-mm and height-mm won't be needed anymore since that information will be provided by the driver then. Please let me know how/where to document this. > > > + > > + width-mm = <68>; > > + height-mm = <150>; > > + }; > > + > > + reserved-memory { > > + cont_splash_mem: cont-splash@e1000000 { > > + reg = <0 0xe1000000 0 0x2300000>; > 0x0 Ack > > [...] > > > + vreg_s1b: smps1 { > > + regulator-min-microvolt = <1840000>; > > + regulator-max-microvolt = <2040000>; > No regulator-initial-mode on this pmic? This specific regulator doesn't have one downstream, but it seems other pm7325 regulators do have this downstream so I'll add it in v2. > > [...] > > > + > > + /* PM8008 PMIC @ 8 and 9 */ > > + /* Pixelworks @ 26 */ > > + /* FSA4480 USB audio switch @ 42 */ > There's a driver for the fsa4480, you may wanna include a node here I'm aware, but will work on this later since it's not useful without USB-C role switching and working audio. > > > + /* AW86927FCR haptics @ 5a */ > > +}; > [...] > > > + > > + led-0 { > > + function = LED_FUNCTION_FLASH; > No dual-tone stuff? Nope. > > > + color = <LED_COLOR_ID_WHITE>; > > + led-sources = <1>, <4>; > > + led-max-microamp = <500000>; > > + flash-max-microamp = <1500000>; > > + flash-max-timeout-us = <1280000>; > > + }; > > +}; > > + > > +&pmk8350_rtc { > > + status = "okay"; > > +}; > > + > > +&pon_pwrkey { > > + status = "okay"; > > +}; > > + > > +&pon_resin { > > + status = "okay"; > > + linux,code = <KEY_VOLUMEDOWN>; > status last Ack > > [...] > > > +&rmtfs_mem { > > + qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>, <QCOM_SCM_VMID_NAV>; > > + reg = <0x0 0xf8500000 0x0 0x600000>; > > +}; > /delete-node/ + redefinition would probably be cleaner-looking Ack, looks better. > > [...] > > > +&uart7 { > > + /delete-property/interrupts; > > + interrupts-extended = <&intc GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>, > > + <&tlmm 31 IRQ_TYPE_EDGE_FALLING>; > > + > > + pinctrl-names = "default", "sleep"; > > + pinctrl-1 = <&qup_uart7_sleep_cts>, <&qup_uart7_sleep_rts>, <&qup_uart7_sleep_tx>, <&qup_uart7_sleep_rx>; > property-n > property-names Ack > > > + > > + status = "okay"; > > + > > + bluetooth: bluetooth { > > + compatible = "qcom,wcn6750-bt"; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&bluetooth_enable_default>, <&sw_ctrl_default>; > property-n > property-names Ack Regards Luca > > Konrad > > [1] https://lore.kernel.org/linux-arm-msm/9db02015-2c41-40d6-bf35-69ef277e9ce4@linaro.org/
On 1.09.2023 16:27, Luca Weiss wrote: > On Wed Aug 30, 2023 at 12:45 PM CEST, Konrad Dybcio wrote: >> On 30.08.2023 11:58, Luca Weiss wrote: >>> Add device tree for the Fairphone 5 smartphone which is based on >>> the QCM6490 SoC. >>> >>> Supported features are, as of now: >>> * Bluetooth >>> * Debug UART >>> * Display via simplefb >>> * Flash/torch LED >>> * Flip cover sensor >>> * Power & volume buttons >>> * RTC >>> * SD card >>> * USB >>> * Various plumbing like regulators, i2c, spi, etc >>> >>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> >>> --- [...] >>> + panel: panel { >>> + compatible = "boe,rm692e5"; >> Undocumented compatbile > > Not quite sure how to document this properly. This dummy panel node is > used for the simplefb/simpledrm so that user space can get panel > dimensions already. > > This approach of a separate panel node was apparently preferred when the > functionality was upstreamed but of course as can be seen this panel > node is very barebones where many properties are not present which would > be needed with the full panel driver (once it's working). > > Also for example for the bindings I think width-mm and height-mm won't > be needed anymore since that information will be provided by the driver > then. > > Please let me know how/where to document this. As discussed offline, the workflow here would be to oneOf: (wink) - wait until there's a proper driver and create a binding based on what you know (because you have a working driver and can test it) is necessary for it to function - create the binding for that display panel + driver ic combo in advance and pray that whatever you put there will be enough when you take upon yourself to write the driver I'd suggest dropping these properties (or keeping them downstream or something) for now, the display should not be terribly hard to bring up properly, let's hope that can be done soon! > I'm aware, but will work on this later since it's not useful without > USB-C role switching and working audio. You can still peek at it in like sysfs or so, but up to you. Konrad
On Sat Sep 2, 2023 at 1:45 PM CEST, Konrad Dybcio wrote: > On 1.09.2023 16:27, Luca Weiss wrote: > > On Wed Aug 30, 2023 at 12:45 PM CEST, Konrad Dybcio wrote: > >> On 30.08.2023 11:58, Luca Weiss wrote: > >>> Add device tree for the Fairphone 5 smartphone which is based on > >>> the QCM6490 SoC. > >>> > >>> Supported features are, as of now: > >>> * Bluetooth > >>> * Debug UART > >>> * Display via simplefb > >>> * Flash/torch LED > >>> * Flip cover sensor > >>> * Power & volume buttons > >>> * RTC > >>> * SD card > >>> * USB > >>> * Various plumbing like regulators, i2c, spi, etc > >>> > >>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > >>> --- > [...] > > >>> + panel: panel { > >>> + compatible = "boe,rm692e5"; > >> Undocumented compatbile > > > > Not quite sure how to document this properly. This dummy panel node is > > used for the simplefb/simpledrm so that user space can get panel > > dimensions already. > > > > This approach of a separate panel node was apparently preferred when the > > functionality was upstreamed but of course as can be seen this panel > > node is very barebones where many properties are not present which would > > be needed with the full panel driver (once it's working). > > > > Also for example for the bindings I think width-mm and height-mm won't > > be needed anymore since that information will be provided by the driver > > then. > > > > Please let me know how/where to document this. > As discussed offline, the workflow here would be to oneOf: (wink) > > - wait until there's a proper driver and create a binding based on > what you know (because you have a working driver and can test it) > is necessary for it to function > > - create the binding for that display panel + driver ic combo in > advance and pray that whatever you put there will be enough when > you take upon yourself to write the driver > > I'd suggest dropping these properties (or keeping them downstream or > something) for now, the display should not be terribly hard to bring > up properly, let's hope that can be done soon! Yeah that sounds like a solution for now. But for other devices I hope something can be figured out so that these dummy panels can go into upstream dts. Otherwise the functionality added in the simplefb driver is kinda useless for pure upstream if noone's allowed to have incomplete bindings for providing the panel dimensions. > > > I'm aware, but will work on this later since it's not useful without > > USB-C role switching and working audio. > You can still peek at it in like sysfs or so, but up to you. Yes, later ;) Regards Luca > > > Konrad
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index 2cca20563a1d..73c3be0f8872 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -81,6 +81,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-lilac.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-maple.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-poplar.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8998-xiaomi-sagit.dtb +dtb-$(CONFIG_ARCH_QCOM) += qcm6490-fairphone-fp5.dtb dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts new file mode 100644 index 000000000000..572b254d3af2 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts @@ -0,0 +1,659 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) 2023, Luca Weiss <luca.weiss@fairphone.com> + */ + +/dts-v1/; + +/* PM7250B is configured to use SID8/9 instead of SID2/3 */ +#define PM7250B_SID 8 +#define PM7250B_SID1 9 + +#include <dt-bindings/arm/qcom,ids.h> +#include <dt-bindings/leds/common.h> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h> +#include "sc7280.dtsi" +#include "pm7250b.dtsi" +#include "pm7325.dtsi" +#include "pm8350c.dtsi" /* PM7350C */ +#include "pmk8350.dtsi" /* PMK7325 */ + +/ { + model = "Fairphone 5"; + compatible = "fairphone,fp5", "qcom,qcm6490"; + chassis-type = "handset"; + + /* required for bootloader to select correct board */ + qcom,msm-id = <QCOM_ID_QCM6490 0x10000>; + qcom,board-id = <34 0>; + + aliases { + serial0 = &uart5; + serial1 = &uart7; + }; + + chosen { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + framebuffer0: framebuffer@a000000 { + compatible = "simple-framebuffer"; + reg = <0 0xe1000000 0 (2700 * 1224 * 4)>; + width = <1224>; + height = <2700>; + stride = <(1224 * 4)>; + format = "a8r8g8b8"; + panel = <&panel>; + clocks = <&gcc GCC_DISP_HF_AXI_CLK>; + }; + }; + + gpio-keys { + compatible = "gpio-keys"; + + pinctrl-0 = <&volume_down_default>, <&hall_sensor_default>; + pinctrl-names = "default"; + + key-volume-up { + label = "Volume up"; + gpios = <&pm7325_gpios 6 GPIO_ACTIVE_LOW>; + linux,code = <KEY_VOLUMEUP>; + }; + + /* Hall sensor uses vreg_l8c as VDD, it's being enabled using + * always-on on the regulator + */ + event-hall-sensor { + label = "Hall Effect Sensor"; + gpios = <&tlmm 155 GPIO_ACTIVE_LOW>; + linux,input-type = <EV_SW>; + linux,code = <SW_LID>; + linux,can-disable; + wakeup-source; + }; + }; + + panel: panel { + compatible = "boe,rm692e5"; + + width-mm = <68>; + height-mm = <150>; + }; + + reserved-memory { + cont_splash_mem: cont-splash@e1000000 { + reg = <0 0xe1000000 0 0x2300000>; + no-map; + }; + + adsp_mem: adsp@86700000 { + reg = <0x0 0x86700000 0x0 0x2800000>; + no-map; + }; + + cdsp_mem: cdsp@88f00000 { + reg = <0x0 0x88f00000 0x0 0x1e00000>; + no-map; + }; + + mpss_mem: mpss@8b800000 { + reg = <0x0 0x8b800000 0x0 0xf600000>; + no-map; + }; + + wpss_mem: wpss@9ae00000 { + reg = <0x0 0x9ae00000 0x0 0x1900000>; + no-map; + }; + }; + + ois_avdd0_1p8: regulator-ois-avdd0-1p8 { + compatible = "regulator-fixed"; + regulator-name = "OIS_AVDD0_1P8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + gpio = <&tlmm 157 GPIO_ACTIVE_HIGH>; + enable-active-high; + vin-supply = <&vreg_bob>; + }; + + ois_dvdd_1p1: regulator-ois-dvdd-1p1 { + compatible = "regulator-fixed"; + regulator-name = "OIS_DVDD_1P1"; + regulator-min-microvolt = <1100000>; + regulator-max-microvolt = <1100000>; + gpio = <&tlmm 97 GPIO_ACTIVE_HIGH>; + enable-active-high; + vin-supply = <&vreg_s8b>; + }; + + afvdd_2p8: regulator-afvdd-2p8 { + compatible = "regulator-fixed"; + regulator-name = "AFVDD_2P8"; + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; + gpio = <&tlmm 68 GPIO_ACTIVE_HIGH>; + enable-active-high; + vin-supply = <&vreg_bob>; + }; +}; + +&apps_rsc { + regulators-0 { + compatible = "qcom,pm7325-rpmh-regulators"; + qcom,pmic-id = "b"; + + vreg_s1b: smps1 { + regulator-min-microvolt = <1840000>; + regulator-max-microvolt = <2040000>; + }; + + vreg_s7b: smps7 { + regulator-min-microvolt = <535000>; + regulator-max-microvolt = <1120000>; + }; + + vreg_s8b: smps8 { + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1500000>; + }; + + vreg_l1b: ldo1 { + regulator-min-microvolt = <825000>; + regulator-max-microvolt = <925000>; + }; + + vreg_l2b: ldo2 { + regulator-min-microvolt = <2700000>; + regulator-max-microvolt = <3544000>; + }; + + vreg_l3b: ldo3 { + regulator-min-microvolt = <312000>; + regulator-max-microvolt = <910000>; + }; + + vreg_l6b: ldo6 { + regulator-min-microvolt = <1140000>; + regulator-max-microvolt = <1260000>; + }; + + vreg_l7b: ldo7 { + regulator-min-microvolt = <2400000>; + regulator-max-microvolt = <3544000>; + }; + + vreg_l8b: ldo8 { + regulator-min-microvolt = <870000>; + regulator-max-microvolt = <970000>; + }; + + vreg_l9b: ldo9 { + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1304000>; + }; + + vreg_l11b: ldo11 { + regulator-min-microvolt = <1504000>; + regulator-max-microvolt = <2000000>; + }; + + vreg_l12b: ldo12 { + regulator-min-microvolt = <751000>; + regulator-max-microvolt = <824000>; + }; + + vreg_l13b: ldo13 { + regulator-min-microvolt = <530000>; + regulator-max-microvolt = <824000>; + }; + + vreg_l14b: ldo14 { + regulator-min-microvolt = <1080000>; + regulator-max-microvolt = <1304000>; + }; + + vreg_l15b: ldo15 { + regulator-min-microvolt = <765000>; + regulator-max-microvolt = <1020000>; + }; + + vreg_l16b: ldo16 { + regulator-min-microvolt = <1100000>; + regulator-max-microvolt = <1300000>; + }; + + vreg_l17b: ldo17 { + regulator-min-microvolt = <1700000>; + regulator-max-microvolt = <1900000>; + }; + + vreg_l18b: ldo18 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <2000000>; + }; + + vreg_l19b: ldo19 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <2000000>; + }; + }; + + regulators-1 { + compatible = "qcom,pm8350c-rpmh-regulators"; + qcom,pmic-id = "c"; + + vreg_s1c: smps1 { + regulator-min-microvolt = <2190000>; + regulator-max-microvolt = <2210000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_s9c: smps9 { + regulator-min-microvolt = <1010000>; + regulator-max-microvolt = <1170000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_l1c: ldo1 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1980000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_l2c: ldo2 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1950000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_l3c: ldo3 { + regulator-min-microvolt = <3000000>; + regulator-max-microvolt = <3400000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_l4c: ldo4 { + regulator-min-microvolt = <1620000>; + regulator-max-microvolt = <3300000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_l5c: ldo5 { + regulator-min-microvolt = <1620000>; + regulator-max-microvolt = <3300000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_l6c: ldo6 { + regulator-min-microvolt = <1650000>; + regulator-max-microvolt = <3544000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_l7c: ldo7 { + regulator-min-microvolt = <3000000>; + regulator-max-microvolt = <3544000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_l8c: ldo8 { + regulator-min-microvolt = <1620000>; + regulator-max-microvolt = <2000000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + /* Hall sensor VDD */ + regulator-always-on; + }; + + vreg_l9c: ldo9 { + regulator-min-microvolt = <2700000>; + regulator-max-microvolt = <3544000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_l10c: ldo10 { + regulator-min-microvolt = <720000>; + regulator-max-microvolt = <1050000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_l11c: ldo11 { + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <3544000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_l12c: ldo12 { + regulator-min-microvolt = <1650000>; + regulator-max-microvolt = <2000000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_l13c: ldo13 { + regulator-min-microvolt = <2700000>; + regulator-max-microvolt = <3544000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_bob: bob { + regulator-min-microvolt = <3008000>; + regulator-max-microvolt = <3960000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_AUTO>; + }; + }; +}; + +&dispcc { + /* Disable for now so simple-framebuffer continues working */ + status = "disabled"; +}; + +&gcc { + protected-clocks = <GCC_CFG_NOC_LPASS_CLK>, + <GCC_EDP_CLKREF_EN>, + <GCC_MSS_CFG_AHB_CLK>, + <GCC_MSS_GPLL0_MAIN_DIV_CLK_SRC>, + <GCC_MSS_OFFLINE_AXI_CLK>, + <GCC_MSS_Q6SS_BOOT_CLK_SRC>, + <GCC_MSS_Q6_MEMNOC_AXI_CLK>, + <GCC_MSS_SNOC_AXI_CLK>, + <GCC_QSPI_CNOC_PERIPH_AHB_CLK>, + <GCC_QSPI_CORE_CLK>, + <GCC_QSPI_CORE_CLK_SRC>, + <GCC_SEC_CTRL_CLK_SRC>, + <GCC_WPSS_AHB_BDG_MST_CLK>, + <GCC_WPSS_AHB_CLK>, + <GCC_WPSS_RSCP_CLK>; +}; + +&gpi_dma0 { + status = "okay"; +}; + +&gpi_dma1 { + status = "okay"; +}; + +&i2c1 { + status = "okay"; + + /* PM8008 PMIC @ 8 and 9 */ + /* Pixelworks @ 26 */ + /* FSA4480 USB audio switch @ 42 */ + /* AW86927FCR haptics @ 5a */ +}; + +&i2c2 { + status = "okay"; + + /* AW88261FCR amplifier @ 34 */ + /* AW88261FCR amplifier @ 35 */ +}; + +&i2c4 { + status = "okay"; + + /* PTN36502 USB redriver @ 1a */ +}; + +&i2c9 { + status = "okay"; + + /* ST21NFC NFC @ 28 */ + /* VL53L3 ToF @ 29 */ +}; + +&ipa { + qcom,gsi-loader = "self"; + memory-region = <&ipa_fw_mem>; + firmware-name = "qcom/qcm6490/fairphone5/ipa_fws.mdt"; + status = "okay"; +}; + +&pm7325_gpios { + volume_down_default: volume-down-default-state { + pins = "gpio6"; + function = PMIC_GPIO_FUNC_NORMAL; + power-source = <1>; + bias-pull-up; + input-enable; + }; +}; + +&pm8350c_flash { + status = "okay"; + + led-0 { + function = LED_FUNCTION_FLASH; + color = <LED_COLOR_ID_WHITE>; + led-sources = <1>, <4>; + led-max-microamp = <500000>; + flash-max-microamp = <1500000>; + flash-max-timeout-us = <1280000>; + }; +}; + +&pmk8350_rtc { + status = "okay"; +}; + +&pon_pwrkey { + status = "okay"; +}; + +&pon_resin { + status = "okay"; + linux,code = <KEY_VOLUMEDOWN>; +}; + +&qup_spi13_cs { + drive-strength = <6>; + bias-disable; +}; + +&qup_spi13_data_clk { + drive-strength = <6>; + bias-disable; +}; + +&qup_uart5_rx { + drive-strength = <2>; + bias-disable; +}; + +&qup_uart5_tx { + drive-strength = <2>; + bias-disable; +}; + +&qupv3_id_0 { + status = "okay"; +}; + +&qupv3_id_1 { + status = "okay"; +}; + +&rmtfs_mem { + qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>, <QCOM_SCM_VMID_NAV>; + reg = <0x0 0xf8500000 0x0 0x600000>; +}; + +&sdc2_clk { + drive-strength = <16>; + bias-disable; +}; + +&sdc2_cmd { + drive-strength = <10>; + bias-pull-up; +}; + +&sdc2_data { + drive-strength = <10>; + bias-pull-up; +}; + +&sdhc_2 { + vmmc-supply = <&vreg_l9c>; + vqmmc-supply = <&vreg_l6c>; + + pinctrl-0 = <&sdc2_clk>, <&sdc2_cmd>, <&sdc2_data>; + pinctrl-1 = <&sdc2_clk_sleep>, <&sdc2_cmd_sleep>, <&sdc2_data_sleep>; + + status = "okay"; +}; + +&spi13 { + status = "okay"; + + /* Goodix touchscreen @ 0 */ +}; + +&tlmm { + /* + * 32-33: SMB1394 (SPMI) + * 56-59: fingerprint reader (SPI) + */ + gpio-reserved-ranges = <32 2>, <56 4>; + + bluetooth_enable_default: bluetooth-enable-default-state { + pins = "gpio85"; + function = "gpio"; + output-low; + bias-disable; + }; + + hall_sensor_default: hall-sensor-default-state { + pins = "gpio155"; + function = "gpio"; + drive-strength = <2>; + bias-pull-up; + }; + + qup_uart7_sleep_cts: qup-uart7-sleep-cts-state { + pins = "gpio28"; + function = "gpio"; + /* + * Configure a bias-bus-hold on CTS to lower power + * usage when Bluetooth is turned off. Bus hold will + * maintain a low power state regardless of whether + * the Bluetooth module drives the pin in either + * direction or leaves the pin fully unpowered. + */ + bias-bus-hold; + }; + + qup_uart7_sleep_rts: qup-uart7-sleep-rts-state { + pins = "gpio29"; + function = "gpio"; + /* + * Configure pull-down on RTS. As RTS is active low + * signal, pull it low to indicate the BT SoC that it + * can wakeup the system anytime from suspend state by + * pulling RX low (by sending wakeup bytes). + */ + bias-pull-down; + }; + + qup_uart7_sleep_tx: qup-uart7-sleep-tx-state { + pins = "gpio30"; + function = "gpio"; + /* + * Configure pull-up on TX when it isn't actively driven + * to prevent BT SoC from receiving garbage during sleep. + */ + bias-pull-up; + }; + + qup_uart7_sleep_rx: qup-uart7-sleep-rx-state { + pins = "gpio31"; + function = "gpio"; + /* + * Configure a pull-up on RX. This is needed to avoid + * garbage data when the TX pin of the Bluetooth module + * is floating which may cause spurious wakeups. + */ + bias-pull-up; + }; + + sw_ctrl_default: sw-ctrl-default-state { + pins = "gpio86"; + function = "gpio"; + bias-pull-down; + }; +}; + +&uart5 { + compatible = "qcom,geni-debug-uart"; + status = "okay"; +}; + +&uart7 { + /delete-property/interrupts; + interrupts-extended = <&intc GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>, + <&tlmm 31 IRQ_TYPE_EDGE_FALLING>; + + pinctrl-names = "default", "sleep"; + pinctrl-1 = <&qup_uart7_sleep_cts>, <&qup_uart7_sleep_rts>, <&qup_uart7_sleep_tx>, <&qup_uart7_sleep_rx>; + + status = "okay"; + + bluetooth: bluetooth { + compatible = "qcom,wcn6750-bt"; + + pinctrl-names = "default"; + pinctrl-0 = <&bluetooth_enable_default>, <&sw_ctrl_default>; + + enable-gpios = <&tlmm 85 GPIO_ACTIVE_HIGH>; + swctrl-gpios = <&tlmm 86 GPIO_ACTIVE_HIGH>; + + vddio-supply = <&vreg_l19b>; + vddaon-supply = <&vreg_s7b>; + vddbtcxmx-supply = <&vreg_s7b>; + vddrfacmn-supply = <&vreg_s7b>; + vddrfa0p8-supply = <&vreg_s7b>; + vddrfa1p7-supply = <&vreg_s1b>; + vddrfa1p2-supply = <&vreg_s8b>; + vddrfa2p2-supply = <&vreg_s1c>; + vddasd-supply = <&vreg_l11c>; + + max-speed = <3200000>; + }; +}; + +&usb_1 { + status = "okay"; +}; + +&usb_1_dwc3 { + dr_mode = "peripheral"; +}; + +&usb_1_hsphy { + vdda-pll-supply = <&vreg_l10c>; + vdda18-supply = <&vreg_l1c>; + vdda33-supply = <&vreg_l2b>; + + qcom,hs-crossover-voltage-microvolt = <28000>; + qcom,hs-output-impedance-micro-ohms = <2600000>; + qcom,hs-rise-fall-time-bp = <5430>; + qcom,hs-disconnect-bp = <1743>; + qcom,hs-amplitude-bp = <2430>; + + qcom,pre-emphasis-amplitude-bp = <20000>; + qcom,pre-emphasis-duration-bp = <20000>; + + qcom,squelch-detector-bp = <(-2090)>; + + status = "okay"; +}; + +&usb_1_qmpphy { + vdda-phy-supply = <&vreg_l6b>; + vdda-pll-supply = <&vreg_l1b>; + + status = "okay"; +};
Add device tree for the Fairphone 5 smartphone which is based on the QCM6490 SoC. Supported features are, as of now: * Bluetooth * Debug UART * Display via simplefb * Flash/torch LED * Flip cover sensor * Power & volume buttons * RTC * SD card * USB * Various plumbing like regulators, i2c, spi, etc Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> --- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 659 +++++++++++++++++++++ 2 files changed, 660 insertions(+)