mbox series

[v5.15,0/4] Backport MEMCG changes from v5.16

Message ID 20220622110506.10534-1-richard@nod.at
Headers show
Series Backport MEMCG changes from v5.16 | expand

Message

Richard Weinberger June 22, 2022, 11:05 a.m. UTC
This is a backport of Sebastian's MEMCG changes to v5.15, with these patches applied,
it is possible to use memory cgroups together with PREEMPT_RT on v5.15, just like on v5.16.

Richard Weinberger (1):
  Allow MEMCG on PREEMPT_RT

Sebastian Andrzej Siewior (3):
  mm/memcg: Disable threshold event handlers on PREEMPT_RT
  mm/memcg: Protect per-CPU counter by disabling preemption on
    PREEMPT_RT where needed.
  mm/memcg: Add a local_lock_t for IRQ and TASK object.

 init/Kconfig    |    1 -
 mm/memcontrol.c | 1257 +++++++++++++++++++++++++----------------------
 2 files changed, 672 insertions(+), 586 deletions(-)

Comments

Sebastian Andrzej Siewior June 23, 2022, 11:23 a.m. UTC | #1
On 2022-06-22 13:05:02 [+0200], Richard Weinberger wrote:
> This is a backport of Sebastian's MEMCG changes to v5.15, with these patches applied,
> it is possible to use memory cgroups together with PREEMPT_RT on v5.15, just like on v5.16.
> 
> Richard Weinberger (1):
>   Allow MEMCG on PREEMPT_RT
> 
> Sebastian Andrzej Siewior (3):
>   mm/memcg: Disable threshold event handlers on PREEMPT_RT
>   mm/memcg: Protect per-CPU counter by disabling preemption on
>     PREEMPT_RT where needed.
>   mm/memcg: Add a local_lock_t for IRQ and TASK object.

So you took the four patches from v5.16 and added it to v5.15.
I would prefer taking what ended up in v5.17 as of v5.17.1-rt17

- 0001-mm-memcg-Revert-mm-memcg-optimize-user-context-objec.patch
- 0002-mm-memcg-Disable-threshold-event-handlers-on-PREEMPT.patch
- 0003-mm-memcg-Protect-per-CPU-counter-by-disabling-preemp.patch
- 0004-mm-memcg-Opencode-the-inner-part-of-obj_cgroup_uncha.patch
- 0005-mm-memcg-Protect-memcg_stock-with-a-local_lock_t.patch
- 0006-mm-memcg-Disable-migration-instead-of-preemption-in-.patch
- 0007-mm-memcg-Add-missing-counter-index-which-are-not-upd.patch
- 0008-mm-memcg-Add-a-comment-regarding-the-release-obj.patch
- mm-memcg-Only-perform-the-debug-checks-on-PREEMPT_RT.patch

since this is what finally landed upstream. So we don't have an
intermediate step from an not supported kernel in a supported one.

Sebastian
Richard Weinberger June 23, 2022, 12:02 p.m. UTC | #2
Sebastian,

----- Ursprüngliche Mail -----
> Von: "bigeasy" <bigeasy@linutronix.de>
> An: "richard" <richard@nod.at>
> CC: linux-rt-users@vger.kernel.org, williams@redhat.com
> Gesendet: Donnerstag, 23. Juni 2022 13:23:18
> Betreff: Re: [v5.15 0/4] Backport MEMCG changes from v5.16

> On 2022-06-22 13:05:02 [+0200], Richard Weinberger wrote:
>> This is a backport of Sebastian's MEMCG changes to v5.15, with these patches
>> applied,
>> it is possible to use memory cgroups together with PREEMPT_RT on v5.15, just
>> like on v5.16.
>> 
>> Richard Weinberger (1):
>>   Allow MEMCG on PREEMPT_RT
>> 
>> Sebastian Andrzej Siewior (3):
>>   mm/memcg: Disable threshold event handlers on PREEMPT_RT
>>   mm/memcg: Protect per-CPU counter by disabling preemption on
>>     PREEMPT_RT where needed.
>>   mm/memcg: Add a local_lock_t for IRQ and TASK object.
> 
> So you took the four patches from v5.16 and added it to v5.15.

Exactly.

> I would prefer taking what ended up in v5.17 as of v5.17.1-rt17
> 
> - 0001-mm-memcg-Revert-mm-memcg-optimize-user-context-objec.patch
> - 0002-mm-memcg-Disable-threshold-event-handlers-on-PREEMPT.patch
> - 0003-mm-memcg-Protect-per-CPU-counter-by-disabling-preemp.patch
> - 0004-mm-memcg-Opencode-the-inner-part-of-obj_cgroup_uncha.patch
> - 0005-mm-memcg-Protect-memcg_stock-with-a-local_lock_t.patch
> - 0006-mm-memcg-Disable-migration-instead-of-preemption-in-.patch
> - 0007-mm-memcg-Add-missing-counter-index-which-are-not-upd.patch
> - 0008-mm-memcg-Add-a-comment-regarding-the-release-obj.patch
> - mm-memcg-Only-perform-the-debug-checks-on-PREEMPT_RT.patch
> 
> since this is what finally landed upstream. So we don't have an
> intermediate step from an not supported kernel in a supported one.

Okay. 

Thanks,
//richard