From patchwork Fri Feb 21 21:24:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Zanussi X-Patchwork-Id: 213208 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D289C35669 for ; Fri, 21 Feb 2020 21:26:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB39924650 for ; Fri, 21 Feb 2020 21:26:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582320409; bh=BodMjiPO1I2v3+3ZzPoqraWPFok3/J5zp6BF7XhVlKs=; h=From:To:Subject:Date:In-Reply-To:References:In-Reply-To: References:List-ID:From; b=D0sdGrFZmMck/u/JSvvwNQNmE/Byh3MXYO5Wov32bwJKugF8zDm9Z/BWV2wYDCE1K kfGHKaJ51G4+yf02DDZOW8T/DmTR8hGT0gBEYRp6bBsEe4aFjGeQMKSeZ+C3iHYvmJ op2seHUiNUkRHolr/heJua96KApEjKj0zit+bikg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729205AbgBUV0o (ORCPT ); Fri, 21 Feb 2020 16:26:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:39142 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729066AbgBUVZX (ORCPT ); Fri, 21 Feb 2020 16:25:23 -0500 Received: from localhost.localdomain (c-98-220-238-81.hsd1.il.comcast.net [98.220.238.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 37E6124676; Fri, 21 Feb 2020 21:25:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582320322; bh=BodMjiPO1I2v3+3ZzPoqraWPFok3/J5zp6BF7XhVlKs=; h=From:To:Subject:Date:In-Reply-To:References:In-Reply-To: References:From; b=YTQDf/c7eZQB+xA0PPAl+2ykyp0ZaqYS2zvHOt1LMNkr4TTXkMOHBezmCOZl/x7qy 7GWNau/jznJLjpjB0DU3ppNCSZsJgXLExK9BP8M59l1v3EUCY0NnZBDhHia0oPDN1h 9Cx55J7YV74WubMTylnpEoIk6+hPfosKBywGKr8o= From: zanussi@kernel.org To: LKML , linux-rt-users , Steven Rostedt , Thomas Gleixner , Carsten Emde , John Kacur , Sebastian Andrzej Siewior , Daniel Wagner , Tom Zanussi Subject: [PATCH RT 08/25] sched: Remove dead __migrate_disabled() check Date: Fri, 21 Feb 2020 15:24:36 -0600 Message-Id: <6560961cbc09e41f13267a26f5f0951af292d59d.1582320278.git.zanussi@kernel.org> X-Mailer: git-send-email 2.14.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-rt-users-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rt-users@vger.kernel.org From: Scott Wood v4.14.170-rt75-rc1 stable review patch. If anyone has any objections, please let me know. ----------- [ Upstream commit 14d9272d534ea91262e15db99443fc5995c7c016 ] This code was unreachable given the __migrate_disabled() branch to "out" immediately beforehand. Signed-off-by: Scott Wood Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Tom Zanussi Conflicts: kernel/sched/core.c --- kernel/sched/core.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 8d6badac9225..4708129e8df1 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -1217,13 +1217,6 @@ static int __set_cpus_allowed_ptr(struct task_struct *p, if (cpumask_test_cpu(task_cpu(p), new_mask) || __migrate_disabled(p)) goto out; -#if defined(CONFIG_SMP) && defined(CONFIG_PREEMPT_RT_BASE) - if (__migrate_disabled(p)) { - p->migrate_disable_update = 1; - goto out; - } -#endif - if (task_running(rq, p) || p->state == TASK_WAKING) { struct migration_arg arg = { p, dest_cpu }; /* Need help from migration thread: drop lock and wait. */