| Message ID | 20230708084027.18352-1-paul@crapouillou.net |
|---|---|
| Headers | show |
| Series | Galaxy S2 (i9100) panel updates v2 | expand |
Hi Paul. On Sat, Jul 08, 2023 at 10:40:24AM +0200, Paul Cercueil wrote: > Hi, > > Follow-up on my patchset that fixes the display of the Samsung Galaxy S2 > when running PostmarketOS. > > The first two patches update the LD9040 panel driver so that it looks > much better, and supports setting the backlight. > > The third patch fixes the size of the panel in the Device Tree. The > previous values were completely bogus and caused Phosh (PmOS' UI) to > display tiny icons and text as it thought the DPI was much lower. > > Changes since V1: > [1/3]: Remove spurious new line > [2/3]: Remove .get_brightness() callback, use bl_get_data() and > backlight_get_brightness() > > Cheers, > -Paul > > Paul Cercueil (3): > drm/panel: ld9040: Use better magic values > drm/panel: ld9040: Register a backlight device > ARM: dts: exynos/i9100: Fix LCD screen's physical size The series looks good. The first two patches are: Reviewed-by: Sam Ravnborg <sam@ravnborg.org> The third patch are: Acked-by: Sam Ravnborg <sam@ravnborg.org> (I was not sure if I could/should stamp it r-b, so decided for the a-b). Sam
On 10/07/2023 09:35, Paul Cercueil wrote: > Hi Krzysztof, > > Le lundi 10 juillet 2023 à 08:59 +0200, Krzysztof Kozlowski a écrit : >> On 08/07/2023 10:40, Paul Cercueil wrote: >>> The previous values were completely bogus, and resulted in the >>> computed >>> DPI ratio being much lower than reality, causing applications and >>> UIs to >>> misbehave. >>> >>> The new values were measured by myself with a ruler. >>> >>> Signed-off-by: Paul Cercueil <paul@crapouillou.net> >>> Fixes: 8620cc2f99b7 ("ARM: dts: exynos: Add devicetree file for the >>> Galaxy S2") >>> Cc: <stable@vger.kernel.org> # v5.8+ >>> --- >> >> This does not apply. You rebased your work on some older >> version/tree, >> without new layout. Please work on linux-next. > > This patchset was based on drm-misc-next, because that's where I was > planning to apply it; and it was extremely unlikely (but not > impossible, apparently) that the i9100.dts would be modified in the > meantime. > > I can rebase on linux-next, the problem then is that I then don't know > how/where to apply the patchset. DTS cannot go via drm-misc-next, so if that's your intention please always split the patchset into separate ones. *Always*. Best regards, Krzysztof
Le lundi 10 juillet 2023 à 09:45 +0200, Krzysztof Kozlowski a écrit : > On 10/07/2023 09:35, Paul Cercueil wrote: > > Hi Krzysztof, > > > > Le lundi 10 juillet 2023 à 08:59 +0200, Krzysztof Kozlowski a > > écrit : > > > On 08/07/2023 10:40, Paul Cercueil wrote: > > > > The previous values were completely bogus, and resulted in the > > > > computed > > > > DPI ratio being much lower than reality, causing applications > > > > and > > > > UIs to > > > > misbehave. > > > > > > > > The new values were measured by myself with a ruler. > > > > > > > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > > > > Fixes: 8620cc2f99b7 ("ARM: dts: exynos: Add devicetree file for > > > > the > > > > Galaxy S2") > > > > Cc: <stable@vger.kernel.org> # v5.8+ > > > > --- > > > > > > This does not apply. You rebased your work on some older > > > version/tree, > > > without new layout. Please work on linux-next. > > > > This patchset was based on drm-misc-next, because that's where I > > was > > planning to apply it; and it was extremely unlikely (but not > > impossible, apparently) that the i9100.dts would be modified in the > > meantime. > > > > I can rebase on linux-next, the problem then is that I then don't > > know > > how/where to apply the patchset. > > DTS cannot go via drm-misc-next, so if that's your intention please > always split the patchset into separate ones. *Always*. Noted. Then I'll apply the patches [1/3] and [2/3] to drm-misc-next since I have my ACKs, and re-send patch [3/3] as standalone and rebased on linux-next. Cheers, -Paul
Patches 1/3 and 2/3 applied to drm-misc-next. I'll resend patch 3/3 as standalone. Cheers, -Paul Le samedi 08 juillet 2023 à 10:40 +0200, Paul Cercueil a écrit : > Hi, > > Follow-up on my patchset that fixes the display of the Samsung Galaxy > S2 > when running PostmarketOS. > > The first two patches update the LD9040 panel driver so that it looks > much better, and supports setting the backlight. > > The third patch fixes the size of the panel in the Device Tree. The > previous values were completely bogus and caused Phosh (PmOS' UI) to > display tiny icons and text as it thought the DPI was much lower. > > Changes since V1: > [1/3]: Remove spurious new line > [2/3]: Remove .get_brightness() callback, use bl_get_data() and > backlight_get_brightness() > > Cheers, > -Paul > > Paul Cercueil (3): > drm/panel: ld9040: Use better magic values > drm/panel: ld9040: Register a backlight device > ARM: dts: exynos/i9100: Fix LCD screen's physical size > > arch/arm/boot/dts/exynos4210-i9100.dts | 4 +- > drivers/gpu/drm/panel/panel-samsung-ld9040.c | 42 +++++++++++++++++- > -- > 2 files changed, 38 insertions(+), 8 deletions(-) >
Hi, Follow-up on my patchset that fixes the display of the Samsung Galaxy S2 when running PostmarketOS. The first two patches update the LD9040 panel driver so that it looks much better, and supports setting the backlight. The third patch fixes the size of the panel in the Device Tree. The previous values were completely bogus and caused Phosh (PmOS' UI) to display tiny icons and text as it thought the DPI was much lower. Changes since V1: [1/3]: Remove spurious new line [2/3]: Remove .get_brightness() callback, use bl_get_data() and backlight_get_brightness() Cheers, -Paul Paul Cercueil (3): drm/panel: ld9040: Use better magic values drm/panel: ld9040: Register a backlight device ARM: dts: exynos/i9100: Fix LCD screen's physical size arch/arm/boot/dts/exynos4210-i9100.dts | 4 +- drivers/gpu/drm/panel/panel-samsung-ld9040.c | 42 +++++++++++++++++--- 2 files changed, 38 insertions(+), 8 deletions(-)