From patchwork Fri Jan 26 17:15:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 767124 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9855E1EB24 for ; Fri, 26 Jan 2024 17:15:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706289352; cv=none; b=Vh8jJF2hZFEYEcfc4bApH0PYNlnOZiUHLuXqvWTJI4bFGeXjV+BkTsYQ9+HqRwbnrXUpYKb0C6QIW3tWr83Q1ZkoA+AUuC/Opz9bSkvrhLbs1DK6UZBlqZ1wMXxhkYti6HLLH2j0DPqZSN5t4P/0c6Cg6rLKe3K8RoAlUgTnI6A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706289352; c=relaxed/simple; bh=rydS2tXXKitlQ9ghWn8wXSHPCF7jrvQvSqSu0kQ0T3M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pxhA82SaiHu3IhmwdhHWjBYXnP6TNoH9FB1p1d3yziD1AwlZI/wVArJv1vMNPvrSekCDL9pbrBEJRw7GRbnZST2b3mvYnjBeK5T6zU5D84HivoPlsLcj5Xm4ZRyZwTsCGrvEfc5cUsAHwpEGF0HyucSvSvQ0HZdbGDWfxZmyerY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wYcGaIIv; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wYcGaIIv" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-40eccf4a91dso9314505e9.2 for ; Fri, 26 Jan 2024 09:15:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706289349; x=1706894149; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hBQadJTQmd+rp5iQVTCEPm0E+5bcMf5aFRFa6IDttrs=; b=wYcGaIIvFmyjnSYHxdTH/QCG9gYPfHFIuREZ93By7qny8de7z2A6glFU3V/mT+G247 VHh1XvUW/ALFxRmWleCS2M54cJNqLZASDZhGqIdJu9rptiEdUCfE6c2vvwpRUHnS3ANZ /dxV2VswlW89LBHg4yMyDB6VJ/IYK6IifMu9WUoRDnzEgAcgNhBt/qeQkA7JECy4OE1R m9FNkEZiSnjHIU1+FG7bPkvdoKD5MhgG3SMKsqA4IP20fmTqvOTWDmutwUm8W6wT58+z PMO7dJSWwpZxd1Y131fnrK/i9Tr8dvdQbfiENBSCHav6P8pCCvf3Vp0Hnq2FnqJM3MF2 3Ijg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706289349; x=1706894149; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hBQadJTQmd+rp5iQVTCEPm0E+5bcMf5aFRFa6IDttrs=; b=veOvrIs96QUFcFHBNV84dPYr5oDbMtYH5w6dDVZ9HARK/5urISKmekx9rGrIlAa+W9 7XqGrHjne5uz740nE8z6zBIbNCw5nEjzm2ip9WA4e0VXTPWrGR4AAMnonzkg2uF/Fva1 GFAiyeZq9CMQeLBssi0zUKgrpY8BnaSGDWIBhNg8ukGQRNLEUkdby3zFOb+K3gaQRt30 wJbWgdQHppJyf0pSZl4bNaTT8iQSAqMgLl0z9DbMy0xY7b9D82cv9BoKJiVeHsxKXGKu +/GxGZYaUijdRlZ4dKB2ejkrqoES33O92gMUuPfBCWSOTNmX4wUAt7osSmNlUmEzW/Fc OPUQ== X-Gm-Message-State: AOJu0YyKJ9Q0ZjCVRYRpO7d9lveYVjHRtrXCkL+vWwhteDIRGnuZtWVx hedTb6trpX2ee6D6wZKSEyIvXSKFgiDBVxpYY6EU42dz0izFE2Qu22CLw2TYeUgBJMcIyEbx8gB 2 X-Google-Smtp-Source: AGHT+IGRkC4wroA/6kPAgQvjykcxN7dPJ1nl0UjHKakeWfw1B7pvhfAxB8IyBSSZAdHdlBym1L3+0Q== X-Received: by 2002:a05:600c:45c5:b0:40e:e025:8d4e with SMTP id s5-20020a05600c45c500b0040ee0258d4emr91907wmo.27.1706289348701; Fri, 26 Jan 2024 09:15:48 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id k10-20020a05600c1c8a00b0040e451fd602sm6287286wms.33.2024.01.26.09.15.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 09:15:48 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, jassi.brar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v3 00/17] spi: s3c64xx: straightforward cleanup Date: Fri, 26 Jan 2024 17:15:28 +0000 Message-ID: <20240126171546.1233172-1-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Straightforward patches that clean the driver. Just compiled tested. Stands up just the patch that updates the driver to use the bitfield access macros. The bit operations shall be identical after the patch. Sam and Andi have some concerns on whether using the bitfield access macros are just a matter of taste, or they are actually necessary. I think they are necessary. Here are the concerns/discussions: https://lore.kernel.org/linux-arm-kernel/ee4107c3-1141-45ab-874c-03474d8ec18d@linaro.org/ https://lore.kernel.org/linux-arm-kernel/ri7gerw4ov4jnmmkhtumhhtgfgxtr6kpsopdxjlx6fylbqznna@3qgvejyhjirw/ Cheers, ta v3: - reworked the bitfied access macros patch so that the bit operations are the same as before the patch. Fix S3C64XX_SPI_PSR_MASK value, drop S3C64XX_SPI_CS_NSC_CNT_MASK. - add a new patches to explicitly remove a duplicated definition and to drop a superfluous bitwise NOT operation. - collect R-b tags v2: https://lore.kernel.org/linux-arm-kernel/36a664b1-666d-4fc4-90d9-35b42e56973d@linaro.org/ Tudor Ambarus (17): spi: s3c64xx: explicitly include spi: s3c64xx: explicitly include spi: s3c64xx: avoid possible negative array index spi: s3c64xx: fix typo, s/configuartion/configuration spi: s3c64xx: sort headers alphabetically spi: s3c64xx: remove unneeded (void *) casts in of_match_table spi: s3c64xx: remove else after return spi: s3c64xx: move common code outside if else spi: s3c64xx: check return code of dmaengine_slave_config() spi: s3c64xx: propagate the dma_submit_error() error code spi: s3c64xx: rename prepare_dma() to s3c64xx_prepare_dma() spi: s3c64xx: return ETIMEDOUT for wait_for_completion_timeout() spi: s3c64xx: drop blank line between declarations spi: s3c64xx: downgrade dev_warn to dev_dbg for optional dt props spi: s3c64xx: remove duplicated definition spi: s3c64xx: drop a superfluous bitwise NOT operation spi: s3c64xx: use bitfield access macros drivers/spi/spi-s3c64xx.c | 298 ++++++++++++++++++++------------------ 1 file changed, 158 insertions(+), 140 deletions(-)