From patchwork Tue Jul 10 05:57:40 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 9916 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 53B2C23E4F for ; Tue, 10 Jul 2012 05:58:01 +0000 (UTC) Received: from mail-ob0-f180.google.com (mail-ob0-f180.google.com [209.85.214.180]) by fiordland.canonical.com (Postfix) with ESMTP id 0F1B7A180D9 for ; Tue, 10 Jul 2012 05:58:00 +0000 (UTC) Received: by obbuo19 with SMTP id uo19so22053864obb.11 for ; Mon, 09 Jul 2012 22:58:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:mime-version:content-type :content-transfer-encoding:x-gm-message-state; bh=dzVOtVF48N8z42XU0nrytLFCt1iJytADaLNLikjearI=; b=fxjzMhd+KySd5vAAJ6MLSWnv4r6eJ5gD//zBd/CaIMLumCNbBYTKwR9NHka5mAesl9 c83wksWJ6/I65QVKr+wk92TmYwajGjKAyWNeDk4hYcLaAJ+pMKdQad93t30jZqN6h2RH 0CkHms5t4G9PeKtqxAPMe7r/2RvFaMGCKFJFDdXTYomVu0ATGz/wATtkGGMWJdCihFQv h17hAptmUur1pUjWpAwe/0Bcwp1du0f1mdDv6BPkOAIPs2iW92n2CYp5TN+A1Gn721IZ F99ueYUx/Deq4+Y+b9IdJGYVQl1CokMwHcVG0rBu7LWndFvmiDWu0uQUer7dvNRia718 bwAw== Received: by 10.50.40.193 with SMTP id z1mr10537335igk.0.1341899880184; Mon, 09 Jul 2012 22:58:00 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.231.24.148 with SMTP id v20csp45358ibb; Mon, 9 Jul 2012 22:57:59 -0700 (PDT) Received: by 10.236.165.102 with SMTP id d66mr48269396yhl.54.1341899879541; Mon, 09 Jul 2012 22:57:59 -0700 (PDT) Received: from mail-gh0-f178.google.com (mail-gh0-f178.google.com [209.85.160.178]) by mx.google.com with ESMTPS id o41si28828601yhl.35.2012.07.09.22.57.59 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 09 Jul 2012 22:57:59 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.178 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.160.178; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.178 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by ghbf1 with SMTP id f1so12723034ghb.37 for ; Mon, 09 Jul 2012 22:57:59 -0700 (PDT) Received: by 10.66.82.2 with SMTP id e2mr70936635pay.67.1341899878804; Mon, 09 Jul 2012 22:57:58 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id qd10sm29193957pbb.38.2012.07.09.22.57.55 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 09 Jul 2012 22:57:58 -0700 (PDT) From: Sachin Kamat To: linux-samsung-soc@vger.kernel.org Cc: kgene.kim@samsung.com, arnd@arndb.de, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/1] ARM: EXYNOS: Fix compilation warning in setup-usb-phy.c file Date: Tue, 10 Jul 2012 11:27:40 +0530 Message-Id: <1341899860-17979-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 MIME-Version: 1.0 X-Gm-Message-State: ALoCoQkThpKZA+8U0wlI0F22wkg0JXHqkYtP0fSjd/AfF1qsNjoq1muw1Vw0bLvrV0FAzySWRS24 Fixes the following warning: arch/arm/mach-exynos/setup-usb-phy.c: In function ‘exynos4210_usb_phy_clkset’: arch/arm/mach-exynos/setup-usb-phy.c:83:2: warning: ‘phyclk’ may be used uninitialized in this function [-Wuninitialized] Signed-off-by: Sachin Kamat --- arch/arm/mach-exynos/setup-usb-phy.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-exynos/setup-usb-phy.c b/arch/arm/mach-exynos/setup-usb-phy.c index d26deb7..1eaa0b0 100644 --- a/arch/arm/mach-exynos/setup-usb-phy.c +++ b/arch/arm/mach-exynos/setup-usb-phy.c @@ -31,7 +31,6 @@ static void exynos4210_usb_phy_clkset(struct platform_device *pdev) struct clk *xusbxti_clk; u32 phyclk; - xusbxti_clk = clk_get(&pdev->dev, "xusbxti"); if (xusbxti_clk && !IS_ERR(xusbxti_clk)) { if (soc_is_exynos4210()) { @@ -50,6 +49,8 @@ static void exynos4210_usb_phy_clkset(struct platform_device *pdev) phyclk |= EXYNOS4210_CLKSEL_48M; break; } + clk_put(xusbxti_clk); + writel(phyclk, EXYNOS4_PHYCLK); } else if (soc_is_exynos4212() || soc_is_exynos4412()) { /* set clock frequency for PLL */ phyclk = readl(EXYNOS4_PHYCLK) & ~EXYNOS4X12_CLKSEL_MASK; @@ -76,11 +77,10 @@ static void exynos4210_usb_phy_clkset(struct platform_device *pdev) phyclk |= EXYNOS4X12_CLKSEL_24M; break; } + clk_put(xusbxti_clk); + writel(phyclk, EXYNOS4_PHYCLK); } - clk_put(xusbxti_clk); } - - writel(phyclk, EXYNOS4_PHYCLK); } static int exynos4210_usb_phy0_init(struct platform_device *pdev)