From patchwork Wed Nov 19 11:15:31 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 41129 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f71.google.com (mail-ee0-f71.google.com [74.125.83.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 3C7CE20CBB for ; Wed, 19 Nov 2014 11:16:32 +0000 (UTC) Received: by mail-ee0-f71.google.com with SMTP id c13sf540482eek.10 for ; Wed, 19 Nov 2014 03:16:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=ywtBrjkiVRck8Opn5o22VpVxHJNf2583D2+yBY/u+Rg=; b=TDwLKzk5E/l6avlOKGEtIUUYNgvowToV+HRStHsxogf9rkFRqE/QxUBTN77aTeP3q+ NsPU+gGI6oiXi8zP5leGNlIdYulpzA1rZ6XvwhQSpaGfw8jSu6zw4U7xeP4oL5K8Gl2s 5VP0ghKDlhbkDYVb+/i5pejcCQnUczi3KBa6NIe6HnyC80qLVrP1uc1QTOPgw4SFiFtB U9q3u+uY0GRyFl1YMMaCyhU5iXRf9RH2Gr/cC77m66CxCKxZoJCXM1dnx88MCoUvFyE6 2qWTY9cboutJljk8qilMM11EsFbOx/vSpi23vE0engxgtrgYkYEyqmSS36sqGuwHXG0P uDAA== X-Gm-Message-State: ALoCoQnoVHT+B/M8nx4fO1+74gqw8qXEwK5lUVQq6zRISG+EJGzjlgouJSKTMlDJbokJ7PVGwj9Z X-Received: by 10.112.204.71 with SMTP id kw7mr333630lbc.13.1416395791524; Wed, 19 Nov 2014 03:16:31 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.42.170 with SMTP id p10ls297588lal.35.gmail; Wed, 19 Nov 2014 03:16:31 -0800 (PST) X-Received: by 10.152.45.1 with SMTP id i1mr41825114lam.7.1416395791154; Wed, 19 Nov 2014 03:16:31 -0800 (PST) Received: from mail-la0-f41.google.com (mail-la0-f41.google.com. [209.85.215.41]) by mx.google.com with ESMTPS id jr4si1496069lab.19.2014.11.19.03.16.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 19 Nov 2014 03:16:30 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) client-ip=209.85.215.41; Received: by mail-la0-f41.google.com with SMTP id gf13so311358lab.0 for ; Wed, 19 Nov 2014 03:16:30 -0800 (PST) X-Received: by 10.152.8.170 with SMTP id s10mr4715488laa.56.1416395790691; Wed, 19 Nov 2014 03:16:30 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp64264lbc; Wed, 19 Nov 2014 03:16:29 -0800 (PST) X-Received: by 10.68.234.202 with SMTP id ug10mr19640507pbc.134.1416395787560; Wed, 19 Nov 2014 03:16:27 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id xo9si2087857pbc.210.2014.11.19.03.16.26 for ; Wed, 19 Nov 2014 03:16:27 -0800 (PST) Received-SPF: none (google.com: linux-samsung-soc-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754080AbaKSLQ0 (ORCPT + 4 others); Wed, 19 Nov 2014 06:16:26 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:24992 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754004AbaKSLQZ (ORCPT ); Wed, 19 Nov 2014 06:16:25 -0500 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NFA00LO6A44IR40@mailout1.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Wed, 19 Nov 2014 11:19:16 +0000 (GMT) X-AuditID: cbfec7f4-b7f6c6d00000120b-81-546c7c060cb9 Received: from eusync1.samsung.com ( [203.254.199.211]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 3A.E6.04619.60C7C645; Wed, 19 Nov 2014 11:16:22 +0000 (GMT) Received: from amdc1339.digital.local ([106.116.147.30]) by eusync1.samsung.com (Oracle Communications Messaging Server 7u4-23.01 (7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0NFA00GC59YMTL30@eusync1.samsung.com>; Wed, 19 Nov 2014 11:16:22 +0000 (GMT) From: Marek Szyprowski To: iommu@lists.linux-foundation.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Marek Szyprowski , linaro-mm-sig@lists.linaro.org, Arnd Bergmann , Shaik Ameer Basha , Cho KyongHo , Joerg Roedel , Thierry Reding , Olof Johansson , Laurent Pinchart , Rob Herring , Will Deacon , David Wodhouse , Inki Dae , Kukjin Kim , Tomasz Figa , Kyungmin Park Subject: [PATCH v3 02/19] iommu: fix initialization without 'add_device' callback Date: Wed, 19 Nov 2014 12:15:31 +0100 Message-id: <1416395748-10731-3-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.2 In-reply-to: <1416395748-10731-1-git-send-email-m.szyprowski@samsung.com> References: <1416395748-10731-1-git-send-email-m.szyprowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJLMWRmVeSWpSXmKPExsVy+t/xy7psNTkhBuu3W1j8nXSM3WLiysnM FpPuT2CxWLDf2qJz9gZ2i94FV9kszja9YbfonLiE3eLLlYdMFpseX2O1mHF+H5PF2iN32S1O Xf/MZvGv9yCjxf89O9gtjjzczW6xatcfRovbv/ksXn48weIg7PHk4DwmjzXz1jB6/P41idFj 56y77B6zO2ayemxeoeWxaVUnm8fmJfUet/89ZvaYfGM5o8eVE02sHr3N79g8+rasYvT4vEku gC+KyyYlNSezLLVI3y6BK2NCy0nGgjesFbO29rI1ML5g6WLk5JAQMJE4efoZO4QtJnHh3nq2 LkYuDiGBpYwSy4/8Z4Rw+pgkpnSdYQWpYhMwlOh628UGYosI5Eu82PsXbBKzwBsWiXubDEFs YYFgif/TlgM1c3CwCKhKXFmqAxLmFfCQmNewBGqZnMT/lyuYQEo4BTwlrkPcIwRU0jR9HesE Rt4FjAyrGEVTS5MLipPScw31ihNzi0vz0vWS83M3MUKi48sOxsXHrA4xCnAwKvHwNhTnhAix JpYVV+YeYpTgYFYS4S0uBArxpiRWVqUW5ccXleakFh9iZOLglGpgLG63tBBe0PHm7LftBRUJ mXW5Ujs882eULvBLKy1p2Gs9gWvCseUfeyTOSaa8T1IP6DY4/KfwGpdi9BPr5mV2u3YqMFba bPY29XApCyt+8FIu7Pk38TWnJ7RmX6hc4DXh4beCBpvIubUX0k8u2nM96H5lr0Wy3Go2ZZfW kvPqEute3t3yU3mGEktxRqKhFnNRcSIAp8ft6GwCAAA= Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: m.szyprowski@samsung.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , IOMMU drivers can be initialized from of_iommu helpers. Such drivers don't need to provide device_add callbacks to operate properly, so there is no need to fail initialization if the callback is missing. Signed-off-by: Marek Szyprowski --- drivers/iommu/iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index ed8b04867b1f..02f798b7e295 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -737,7 +737,7 @@ static int add_iommu_group(struct device *dev, void *data) const struct iommu_ops *ops = cb->ops; if (!ops->add_device) - return -ENODEV; + return 0; WARN_ON(dev->iommu_group);