From patchwork Wed Sep 14 12:44:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 76175 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp1854600qgf; Wed, 14 Sep 2016 05:44:56 -0700 (PDT) X-Received: by 10.98.73.202 with SMTP id r71mr4231528pfi.36.1473857095866; Wed, 14 Sep 2016 05:44:55 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id fx20si4617353pab.220.2016.09.14.05.44.55; Wed, 14 Sep 2016 05:44:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756072AbcINMoy (ORCPT + 4 others); Wed, 14 Sep 2016 08:44:54 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:31044 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755879AbcINMox (ORCPT ); Wed, 14 Sep 2016 08:44:53 -0400 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0ODH0033XVEQK6A0@mailout2.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Wed, 14 Sep 2016 13:44:50 +0100 (BST) Received: from eusmges1.samsung.com (unknown [203.254.199.239]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20160914124449eucas1p27f20a85a479007638f2e2900c6224772~0MTbaxszx1196711967eucas1p2z; Wed, 14 Sep 2016 12:44:49 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1.samsung.com (EUCPMTA) with SMTP id 2B.68.23383.14649D75; Wed, 14 Sep 2016 13:44:49 +0100 (BST) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20160914124448eucas1p2b5d1cac9d4af5dc594c012007b21c3c4~0MTang4zG1604616046eucas1p2t; Wed, 14 Sep 2016 12:44:48 +0000 (GMT) X-AuditID: cbfec7ef-f79e76d000005b57-3a-57d946411b0a Received: from eusync2.samsung.com ( [203.254.199.212]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 01.64.10494.01649D75; Wed, 14 Sep 2016 13:44:00 +0100 (BST) Received: from AMDC2765.digital.local ([106.116.147.25]) by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0ODH0089AVELWO60@eusync2.samsung.com>; Wed, 14 Sep 2016 13:44:48 +0100 (BST) From: Marek Szyprowski To: iommu@lists.linux-foundation.org, linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski Subject: [PATCH] iommu/exynos: Improve page fault debug message Date: Wed, 14 Sep 2016 14:44:43 +0200 Message-id: <1473857083-1078-1-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJIsWRmVeSWpSXmKPExsWy7djPc7qObjfDDbq/Wlss2G9tMeP8PiaL tUfusjswe0y+sZzRo2/LKkaPz5vkApijuGxSUnMyy1KL9O0SuDJ+nn/HXnCTu+L8pi0sDYwf OLsYOTgkBEwk5q4L6WLkBDLFJC7cW88GYgsJLGOUaLvA3sXIBWR/ZpTYPm8aC0SRicSpk/+Y IRJARX9mT2aC6GhgkvhzSQPEZhMwlOh62wU2SUTAXeL6n+dgzcwC+hLrFm4FqxcWsJc4930D WA2LgKrErSf/wOK8QPUXfjxih1gmJ3Hy2GRWkGUSAivYJI79bmGEuFpWYtMBZogaF4nLlx+w QtjCEq+Ob4HqlZG4PLkb6uh+RommVm0IewajxLm3vBC2tcTh4xdZIW7jk5i0bTozxHheiY42 IYgSD4nduyYwQdiOEhMOvAIrERKIlTh0U34Co/QCRoZVjCKppcW56anFhnrFibnFpXnpesn5 uZsYgRF2+t/x9zsYnzaHHGIU4GBU4uEN+HE9XIg1say4MvcQowQHs5II7zuXm+FCvCmJlVWp RfnxRaU5qcWHGKU5WJTEefcuuBIuJJCeWJKanZpakFoEk2Xi4JRqYBSbP39+VbV/5zkhqY36 4al7jOW9I7fc/b0lhdFp5t0/xq/2uxf5rr+w+Gy9RNOyOauj/iv/XXJBlHEOl2zyy+kXzYv0 d+2M/bfGSfP5roaNr5qXV88X3sma9S18rvmvre49YhMaGp/H8G2YMaHhbu/H85xTgpSDTT8s D3eOF2Vw4w/TDPqe7qvEUpyRaKjFXFScCABD1rLKrAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrELMWRmVeSWpSXmKPExsVy+t/xK7oCbjfDDTZvlrdYsN/aYsb5fUwW a4/cZXdg9ph8YzmjR9+WVYwenzfJBTBHudlkpCampBYppOYl56dk5qXbKoWGuOlaKCnkJeam 2ipF6PqGBCkplCXmlAJ5RgZowME5wD1YSd8uwS3j5/l37AU3uSvOb9rC0sD4gbOLkZNDQsBE 4tTJf8wQtpjEhXvr2boYuTiEBJYwSrztPM8M4TQxSUx+vYQRpIpNwFCi620XG4gtIuAucf3P cxYQm1lAX2Ldwq1MILawgL3Eue8bwGpYBFQlbj35BxbnBaq/8OMRO8Q2OYmTxyazTmDkXsDI sIpRJLW0ODc9t9hIrzgxt7g0L10vOT93EyMwvLYd+7llB2PXu+BDjAIcjEo8vAE/rocLsSaW FVfmHmKU4GBWEuF953IzXIg3JbGyKrUoP76oNCe1+BCjKdDyicxSosn5wNDPK4k3NDE0tzQ0 MrawMDcyUhLnnfrhSriQQHpiSWp2ampBahFMHxMHp1QDo8t7/nUWlya+6xW6/FtW9rZyG5fT Xqv3RuqaBltXv1NeEcrx4/T763kbD8vL3bmv5Xvw8FnWb/YHGtQz2JqPJDz4dzKv/5VOgvrR KWXsqae6s5/9vyMsGh1i0Z2y5b26dKzPov1Lrssl+tZIBmood0+LWbX5+7N9++bqbPM5KsjT /jZr6cqNAkosxRmJhlrMRcWJAIxLWIxFAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20160914124448eucas1p2b5d1cac9d4af5dc594c012007b21c3c4 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRs=?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRtT?= =?UTF-8?B?YW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20160914124448eucas1p2b5d1cac9d4af5dc594c012007b21c3c4 X-RootMTR: 20160914124448eucas1p2b5d1cac9d4af5dc594c012007b21c3c4 References: Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Add master device name to default IOMMU fault message to make easier to find which device triggered the fault. While at it, move printing some information (like page table base and first level entry addresses) to dev_dbg(), because those are typically not very useful for typical device driver user/developer not equipped with hardware debugging tools. Signed-off-by: Marek Szyprowski --- drivers/iommu/exynos-iommu.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index 30808e9..47f0d67 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -368,13 +368,14 @@ static void show_fault_information(struct sysmmu_drvdata *data, { sysmmu_pte_t *ent; - dev_err(data->sysmmu, "%s FAULT occurred at %#x (page table base: %pa)\n", - finfo->name, fault_addr, &data->pgtable); + dev_err(data->sysmmu, "%s: %s FAULT occurred at %#x\n", + dev_name(data->master), finfo->name, fault_addr); + dev_dbg(data->sysmmu, "Page table base: %pa\n", &data->pgtable); ent = section_entry(phys_to_virt(data->pgtable), fault_addr); - dev_err(data->sysmmu, "\tLv1 entry: %#x\n", *ent); + dev_dbg(data->sysmmu, "\tLv1 entry: %#x\n", *ent); if (lv1ent_page(ent)) { ent = page_entry(ent, fault_addr); - dev_err(data->sysmmu, "\t Lv2 entry: %#x\n", *ent); + dev_dbg(data->sysmmu, "\t Lv2 entry: %#x\n", *ent); } }