From patchwork Fri Jul 30 14:49:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Protsenko X-Patchwork-Id: 489321 Delivered-To: patch@linaro.org Received: by 2002:a05:6638:1185:0:0:0:0 with SMTP id f5csp3221690jas; Fri, 30 Jul 2021 07:49:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCm9hU9AF65Dz25aY8YK8Q68z15O3aO81xtylQLUwBOwzCLBKydfQHMdWmgnCqyJjoE1je X-Received: by 2002:a02:cc19:: with SMTP id n25mr2455080jap.140.1627656572685; Fri, 30 Jul 2021 07:49:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627656572; cv=none; d=google.com; s=arc-20160816; b=tzBNT5BSwlNMo0607NW1ykOwP5byws0qlWUGphBHW+OxO2TV40jhK16aNycu0Xj2u9 7NfVXh+96C16Lt9hIOJP5jtn/2SxOdLmhl6DNXI+m+acYfahH5yFCqm0OsTAGgy5h3gK 5X6pbUqn+0/Ztoxj5V32ECwKEyyTrVSCHHGhAf02XcfROzQs0d5zCfuE2j/UnRFQWGu9 Nqh43VJhAxcV10fhXmsqQUoERPsohiVLEqhxpHdtdRtlc/SCSirVrkLbtxiGSz3i82nR ZObbp6kpBkUCD+VX+WFpB+cky+62TgAYXUlzr2WZZI5PVAyD03JFLCHCMw7AdpBNtiy9 ovWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VTDgPgWodE/cSRF6bHIc6D1D5Dn1jvPwRYXuY/lAMLo=; b=g+J8v/B2IE+mzq02mCahlCzr6Q6Zk4xpaP9uglC2V7lqxcFgquLUmQfKWOj6Sk7/mf GsjB/MwW6+Uh8W1P3FkVTNMnW9qU8y0+ncC3s/dZ7gFJ8w9800VT+shOyrdSQYfBLViY UaMnY1m/GZWbLCE3qnJursW+qR+mcv2XRIpyQ/ST8CCl3es+S3+6FOqD0Lk6Ab36syDx vttGlu4TtvyVgEM6WjrsA/Lu8x3D5MFNctXsWADdEfGmoEE3XhMosjKUyoQjEyMmL/EF hyvhQln+qEKuLBU/YwfSS882oN3vrGvMaB1Id4SEHDjZPAztSA/7pSiSv85InPxcz7Af eihA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TkueiDTd; spf=pass (google.com: domain of linux-samsung-soc-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x1si1842506jan.58.2021.07.30.07.49.32; Fri, 30 Jul 2021 07:49:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-samsung-soc-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TkueiDTd; spf=pass (google.com: domain of linux-samsung-soc-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239352AbhG3Otd (ORCPT + 4 others); Fri, 30 Jul 2021 10:49:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239340AbhG3Otc (ORCPT ); Fri, 30 Jul 2021 10:49:32 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B961C0613C1 for ; Fri, 30 Jul 2021 07:49:27 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id d6so5910046edt.7 for ; Fri, 30 Jul 2021 07:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VTDgPgWodE/cSRF6bHIc6D1D5Dn1jvPwRYXuY/lAMLo=; b=TkueiDTdOMqYTmTxIiWclFQDmAoJQIi9pKg/pDn4T1rA2VjfILkGJNRgYCunu870MP qypWhzFqenbxNDZV4QPpZvTBiL0T6ZzwAkBRHMaovinMWM8mTUwcZ1jc6pskjFipGKIM IXhUOo6SBJYFp2Yht0rWwR6rKjHOixSLarchv5uf56EVbCILFXRb+G0Y547em6aa4I8/ BqZr3+joyNVs85IjpkswpDcIjciP+mlO9g6EoGxO1/d3NIEJTlZbuskA5bb08gAkGtd4 2oFBaMMAzmc1lYRJdhu9xkPqeQH6gQLUdBaAq+YpDbbvFgnFduiJnZeySi1IBccyGB81 Sgjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VTDgPgWodE/cSRF6bHIc6D1D5Dn1jvPwRYXuY/lAMLo=; b=OjM0a/RvTUfVSmkIrJk5GDZeDW09VjYOjbf74/CMbjhZFtNxWzJW4RlUgWQ26Cxmlu 5EmV3LLSAZxBk32MlmnQdY4DSWDkpC+UXUqpasPra2na8Js2QI9s7A4HKLQPe2oLJE8G s7bUGjEBeDuy4Hy1Fb+Owbh7dy8yyDkYpUgNkp6YNtDuC7qfdy/w9aMQi5XvEYaH2/oe Q/XhWqxN/UYPKMNpr8HfcegTAIEoXdUwywyuxOkXXzyd4T/Gh5TEhl/8QLxsfT3kBeje Mw1s7iD0u5Tr1zAlNHt1rhCD5sMkvw/bq5Io3K0tXw8ZwOMvWsKggwokvmsZZ9ap/sPj x13A== X-Gm-Message-State: AOAM533pCovxoGeGR1AbcLbGhs00W0LU8kcMr0Bj8pUfMi3qx0HVQ2Fa t/hLMpRYvodLz8nhXcNHrZCqIA== X-Received: by 2002:a05:6402:31ba:: with SMTP id dj26mr3436625edb.252.1627656565567; Fri, 30 Jul 2021 07:49:25 -0700 (PDT) Received: from localhost ([31.134.121.151]) by smtp.gmail.com with ESMTPSA id o17sm629581ejb.84.2021.07.30.07.49.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jul 2021 07:49:25 -0700 (PDT) From: Sam Protsenko To: Sylwester Nawrocki , Chanwoo Choi , Krzysztof Kozlowski , Linus Walleij , Tomasz Figa Cc: Rob Herring , Stephen Boyd , Michael Turquette , Jiri Slaby , Greg Kroah-Hartman , Charles Keepax , Ryu Euiyoul , Tom Gall , Sumit Semwal , John Stultz , Amit Pundir , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org Subject: [PATCH 01/12] pinctrl: samsung: Fix pinctrl bank pin count Date: Fri, 30 Jul 2021 17:49:11 +0300 Message-Id: <20210730144922.29111-2-semen.protsenko@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210730144922.29111-1-semen.protsenko@linaro.org> References: <20210730144922.29111-1-semen.protsenko@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org From: Jaehyoung Choi Commit 1abd18d1a51a ("pinctrl: samsung: Register pinctrl before GPIO") changes the order of GPIO and pinctrl registration: now pinctrl is registered before GPIO. That means gpio_chip->ngpio is not set when samsung_pinctrl_register() called, and one cannot rely on that value anymore. Use `pin_bank->nr_pins' instead of `pin_bank->gpio_chip.ngpio' to fix mentioned inconsistency. Fixes: 1abd18d1a51a ("pinctrl: samsung: Register pinctrl before GPIO") Signed-off-by: Jaehyoung Choi Signed-off-by: Sam Protsenko --- drivers/pinctrl/samsung/pinctrl-samsung.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.30.2 diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c index 376876bd6605..2975b4369f32 100644 --- a/drivers/pinctrl/samsung/pinctrl-samsung.c +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c @@ -918,7 +918,7 @@ static int samsung_pinctrl_register(struct platform_device *pdev, pin_bank->grange.pin_base = drvdata->pin_base + pin_bank->pin_base; pin_bank->grange.base = pin_bank->grange.pin_base; - pin_bank->grange.npins = pin_bank->gpio_chip.ngpio; + pin_bank->grange.npins = pin_bank->nr_pins; pin_bank->grange.gc = &pin_bank->gpio_chip; pinctrl_add_gpio_range(drvdata->pctl_dev, &pin_bank->grange); }