| Message ID | 20220523064252.11938-3-juergh@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: s3c: Kconfig: Style cleanups | expand |
Thanks Juerg for your patch. >-----Original Message----- >From: Juerg Haefliger [mailto:juerg.haefliger@canonical.com] >Sent: Monday, May 23, 2022 12:13 PM >To: krzysztof.kozlowski@linaro.org; alim.akhtar@samsung.com; >linux@armlinux.org.uk; linux-arm-kernel@lists.infradead.org; linux-samsung- >soc@vger.kernel.org >Cc: linux-kernel@vger.kernel.org; Juerg Haefliger <juergh@canonical.com> >Subject: [PATCH 2/3] ARM: s3c: Kconfig.s3c24xx: Fix indentation and replace >some tabs > >The convention for indentation seems to be a single tab. Help text is further >indented by an additional two whitespaces. Fix the lines that violate these >rules. > >While add it, replace tabs before comments with whitespaces and squeeze >multiple empty lines. > >Signed-off-by: Juerg Haefliger <juergh@canonical.com> >--- > arch/arm/mach-s3c/Kconfig.s3c24xx | 26 ++++++++++++-------------- > 1 file changed, 12 insertions(+), 14 deletions(-) > >diff --git a/arch/arm/mach-s3c/Kconfig.s3c24xx b/arch/arm/mach- >s3c/Kconfig.s3c24xx >index 000e3e234f71..a7625e772905 100644 >--- a/arch/arm/mach-s3c/Kconfig.s3c24xx >+++ b/arch/arm/mach-s3c/Kconfig.s3c24xx >@@ -17,8 +17,6 @@ config PLAT_S3C24XX > help > Base platform code for any Samsung S3C24XX device > >- >- > menu "Samsung S3C24XX SoCs Support" > > comment "S3C24XX SoCs" >@@ -268,7 +266,7 @@ config MACH_VR1000 > help > Say Y here if you are using the Thorcom VR1000 board. > >-endif # CPU_S3C2410 >+endif # CPU_S3C2410 > > config S3C2412_PM_SLEEP > bool >@@ -342,7 +340,7 @@ config MACH_VSTMS > help > Say Y here if you are using an VSTMS board > >-endif # CPU_S3C2412 >+endif # CPU_S3C2412 > > if CPU_S3C2416 > >@@ -390,7 +388,7 @@ config MACH_S3C2416_DT > Note: This is under development and not all peripherals can be >supported > with this machine file. > >-endif # CPU_S3C2416 >+endif # CPU_S3C2416 > > if CPU_S3C2440 || CPU_S3C2442 > >@@ -419,7 +417,7 @@ config S3C2440_PLL_16934400 > default y if S3C24XX_PLL > help > PLL tables for S3C2440 or S3C2442 CPUs with 16.934MHz crystals. >-endif >+endif # CPU_S3C2440 || CPU_S3C2442 > This change is more then what commit message tells, so please mention these in the commit message as well Rest looks fine to me. > if CPU_S3C2440 > >@@ -515,7 +513,7 @@ config SMDK2440_CPU2440 > default y if ARCH_S3C2440 > select S3C2440_XTAL_16934400 > >-endif # CPU_S3C2440 >+endif # CPU_S3C2440 > > if CPU_S3C2442 > >@@ -535,7 +533,7 @@ config MACH_NEO1973_GTA02 > select S3C24XX_PWM > select S3C_DEV_USB_HOST > help >- Say Y here if you are using the Openmoko GTA02 / Freerunner GSM >Phone >+ Say Y here if you are using the Openmoko GTA02 / Freerunner GSM >+Phone > > config MACH_RX1950 > bool "HP iPAQ rx1950" >@@ -547,9 +545,9 @@ config MACH_RX1950 > select S3C24XX_PWM > select S3C_DEV_NAND > help >- Say Y here if you're using HP iPAQ rx1950 >+ Say Y here if you're using HP iPAQ rx1950 > >-endif # CPU_S3C2442 >+endif # CPU_S3C2442 > > if CPU_S3C2443 || CPU_S3C2416 > >@@ -558,7 +556,7 @@ config S3C2443_SETUP_SPI > help > Common setup code for SPI GPIO configurations > >-endif # CPU_S3C2443 || CPU_S3C2416 >+endif # CPU_S3C2443 || CPU_S3C2416 > > if CPU_S3C2443 > >@@ -571,13 +569,13 @@ config MACH_SMDK2443 > help > Say Y here if you are using an SMDK2443 > >-endif # CPU_S3C2443 >+endif # CPU_S3C2443 > > config PM_H1940 > bool > help > Internal node for H1940 and related PM > >-endmenu # Samsung S3C24XX SoCs Support >+endmenu # "Samsung S3C24XX SoCs Support" > >-endif # ARCH_S3C24XX >+endif # ARCH_S3C24XX >-- >2.32.0
diff --git a/arch/arm/mach-s3c/Kconfig.s3c24xx b/arch/arm/mach-s3c/Kconfig.s3c24xx index 000e3e234f71..a7625e772905 100644 --- a/arch/arm/mach-s3c/Kconfig.s3c24xx +++ b/arch/arm/mach-s3c/Kconfig.s3c24xx @@ -17,8 +17,6 @@ config PLAT_S3C24XX help Base platform code for any Samsung S3C24XX device - - menu "Samsung S3C24XX SoCs Support" comment "S3C24XX SoCs" @@ -268,7 +266,7 @@ config MACH_VR1000 help Say Y here if you are using the Thorcom VR1000 board. -endif # CPU_S3C2410 +endif # CPU_S3C2410 config S3C2412_PM_SLEEP bool @@ -342,7 +340,7 @@ config MACH_VSTMS help Say Y here if you are using an VSTMS board -endif # CPU_S3C2412 +endif # CPU_S3C2412 if CPU_S3C2416 @@ -390,7 +388,7 @@ config MACH_S3C2416_DT Note: This is under development and not all peripherals can be supported with this machine file. -endif # CPU_S3C2416 +endif # CPU_S3C2416 if CPU_S3C2440 || CPU_S3C2442 @@ -419,7 +417,7 @@ config S3C2440_PLL_16934400 default y if S3C24XX_PLL help PLL tables for S3C2440 or S3C2442 CPUs with 16.934MHz crystals. -endif +endif # CPU_S3C2440 || CPU_S3C2442 if CPU_S3C2440 @@ -515,7 +513,7 @@ config SMDK2440_CPU2440 default y if ARCH_S3C2440 select S3C2440_XTAL_16934400 -endif # CPU_S3C2440 +endif # CPU_S3C2440 if CPU_S3C2442 @@ -535,7 +533,7 @@ config MACH_NEO1973_GTA02 select S3C24XX_PWM select S3C_DEV_USB_HOST help - Say Y here if you are using the Openmoko GTA02 / Freerunner GSM Phone + Say Y here if you are using the Openmoko GTA02 / Freerunner GSM Phone config MACH_RX1950 bool "HP iPAQ rx1950" @@ -547,9 +545,9 @@ config MACH_RX1950 select S3C24XX_PWM select S3C_DEV_NAND help - Say Y here if you're using HP iPAQ rx1950 + Say Y here if you're using HP iPAQ rx1950 -endif # CPU_S3C2442 +endif # CPU_S3C2442 if CPU_S3C2443 || CPU_S3C2416 @@ -558,7 +556,7 @@ config S3C2443_SETUP_SPI help Common setup code for SPI GPIO configurations -endif # CPU_S3C2443 || CPU_S3C2416 +endif # CPU_S3C2443 || CPU_S3C2416 if CPU_S3C2443 @@ -571,13 +569,13 @@ config MACH_SMDK2443 help Say Y here if you are using an SMDK2443 -endif # CPU_S3C2443 +endif # CPU_S3C2443 config PM_H1940 bool help Internal node for H1940 and related PM -endmenu # Samsung S3C24XX SoCs Support +endmenu # "Samsung S3C24XX SoCs Support" -endif # ARCH_S3C24XX +endif # ARCH_S3C24XX
The convention for indentation seems to be a single tab. Help text is further indented by an additional two whitespaces. Fix the lines that violate these rules. While add it, replace tabs before comments with whitespaces and squeeze multiple empty lines. Signed-off-by: Juerg Haefliger <juergh@canonical.com> --- arch/arm/mach-s3c/Kconfig.s3c24xx | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-)