mbox series

[v2,0/2] target: Introduce dummy devices

Message ID 20210322200938.53300-1-k.shelekhin@yadro.com
Headers show
Series target: Introduce dummy devices | expand

Message

Konstantin Shelekhin March 22, 2021, 8:09 p.m. UTC 
This patch series (inspired by SCST) adds support for the dummy devices
via the new DUMMY flag of rd_mcp. The rationale behind the change is to
give a user the ability to create conifgurable devices for LUN 0 with
custom WWN values (like vendor, product or revision) as some tools like
QConvergeGUI use LUN 0 to identify the whole storage.

The advantage over simply creating a NULLIO rd_mcp device is that the
DUMMY device will not be seen as a block device, hence less confusion
for the system administrator.

Konstantin Shelekhin (2):
  target: Add the DUMMY flag to rd_mcp
  target: Make the virtual LUN 0 device dummy

 drivers/target/target_core_device.c |  2 +-
 drivers/target/target_core_rd.c     | 27 +++++++++++++++++++++++----
 drivers/target/target_core_rd.h     |  1 +
 drivers/target/target_core_spc.c    |  6 +-----
 4 files changed, 26 insertions(+), 10 deletions(-)

Comments

Mike Christie April 2, 2021, 3:09 p.m. UTC | #1 
On 3/22/21 3:09 PM, Konstantin Shelekhin wrote:
> This patch series (inspired by SCST) adds support for the dummy devices

> via the new DUMMY flag of rd_mcp. The rationale behind the change is to

> give a user the ability to create conifgurable devices for LUN 0 with

> custom WWN values (like vendor, product or revision) as some tools like

> QConvergeGUI use LUN 0 to identify the whole storage.

> 

> The advantage over simply creating a NULLIO rd_mcp device is that the

> DUMMY device will not be seen as a block device, hence less confusion

> for the system administrator.

> 

> Konstantin Shelekhin (2):

>   target: Add the DUMMY flag to rd_mcp

>   target: Make the virtual LUN 0 device dummy

> 

>  drivers/target/target_core_device.c |  2 +-

>  drivers/target/target_core_rd.c     | 27 +++++++++++++++++++++++----

>  drivers/target/target_core_rd.h     |  1 +

>  drivers/target/target_core_spc.c    |  6 +-----

>  4 files changed, 26 insertions(+), 10 deletions(-)

> 


Patches look ok and tested ok for me.

Reviewed-by: Mike Christie <michael.christie@oracle.com>
Martin K. Petersen April 13, 2021, 5:48 a.m. UTC | #2 
On Mon, 22 Mar 2021 23:09:36 +0300, Konstantin Shelekhin wrote:

> This patch series (inspired by SCST) adds support for the dummy devices

> via the new DUMMY flag of rd_mcp. The rationale behind the change is to

> give a user the ability to create conifgurable devices for LUN 0 with

> custom WWN values (like vendor, product or revision) as some tools like

> QConvergeGUI use LUN 0 to identify the whole storage.

> 

> The advantage over simply creating a NULLIO rd_mcp device is that the

> DUMMY device will not be seen as a block device, hence less confusion

> for the system administrator.

> 

> [...]


Applied to 5.13/scsi-queue, thanks!

[1/2] target: Add the DUMMY flag to rd_mcp
      https://git.kernel.org/mkp/scsi/c/0aecfa662e43
[2/2] target: Make the virtual LUN 0 device dummy
      https://git.kernel.org/mkp/scsi/c/1b5ad814af5e

-- 
Martin K. Petersen	Oracle Linux Engineering