| Message ID | 20220214021747.4976-1-damien.lemoal@opensource.wdc.com |
|---|---|
| Headers | show |
| Series | libsas and pm8001 fixes | expand |
On 2/15/22 03:06, John Garry wrote: > On 14/02/2022 02:17, Damien Le Moal wrote: >> This first part of this series (patches 1 to 24) fixes handling of NCQ >> NON DATA commands in libsas and many bugs in the pm8001 driver. >> >> The fixes for the pm8001 driver include: >> * Suppression of all sparse warnings, fixing along the way many le32 >> handling bugs for big-endian architectures >> * Fix handling of NCQ NON DATA commands >> * Fix of tag values handling (0*is* a valid tag value) >> * Fix many tag iand memory leaks in error path >> * Fix NCQ error recovery (abort all task execution) that was causing a >> crash >> >> The second part of the series (patches 25 to 31) iadd a small cleanup of >> libsas code and many simplifications of the pm8001 driver code. >> >> With these fixes, libzbc test suite passes all test case. This test >> suite was used with an SMR drive for testing because it generates many >> NCQ NON DATA commands (for zone management commands) and also generates >> many NCQ command errors to check ASC/ASCQ returned by the device. With >> the test suite, the error recovery path was extensively exercised. The >> same tests were also executed with a SAS SMR drives to exercise the >> error path. >> >> The patches are based on the 5.18/scsi-staging tree. > > Hi Damien, > > jfyi, I still see the hang with this series. I don't think that the tag > fixes were relevant unfortunately. As mentioned above, I did test with a SAS drive too (an SMR one to heavily test the error path) and it worked perfectly. Note that using Martin's rc1 based scsi-staging tree, I did see a lot of KASAN complaints on boot regarding MSI/PCI setup. These warnings are gone with rc3/4. What kernel version base are you using ? I could not find the ARM board I have in the lab yesterday. Will try again to find it and test with it. > > btw, how about add guys from get_maintainers.pl to lighten the review > workload (and we should have the official maintainer anyway)? There are > quite a few patches now... I did that... I will check again. I may have made mistake creating the distribution list. > > Thanks, > John
Hi Damien! > Note that there is a conflict between 5.18/scsi-staging and 5.17-rc3/4 > in the pm8001 driver. And I need to touch rc3/rc4 code too. Could you > rebase scsi-staging ? I pulled in 5.17/scsi-fixes and fixed up the conflicts. I suggest you merge your -rc of choice when testing. That's what I do if the baseline kernel has problems on my lab systems.
On 2/15/22 12:18, Martin K. Petersen wrote: > > Hi Damien! > >> Note that there is a conflict between 5.18/scsi-staging and 5.17-rc3/4 >> in the pm8001 driver. And I need to touch rc3/rc4 code too. Could you >> rebase scsi-staging ? > > I pulled in 5.17/scsi-fixes and fixed up the conflicts. Thanks ! > I suggest you merge your -rc of choice when testing. That's what I do if > the baseline kernel has problems on my lab systems. That is what I normally do, but for some reason, this time, I kept ending up with a non working kernel... I must have done something very wrong :)