mbox series

[v4,0/4] Prepare for constifying SCSI host templates

Message ID 20220913195716.3966875-1-bvanassche@acm.org
Headers show
Series Prepare for constifying SCSI host templates | expand

Message

Bart Van Assche Sept. 13, 2022, 7:57 p.m. UTC
Hi Martin,

This patch series prepares for constifying SCSI host templates by moving the
members that are not constant out of the SCSI host template. Please consider
this patch series for the next merge window.

Thanks,

Bart.

Changes compared to v3:
- Changed the 'present' counter from 8 to 32 bits.
- Fixed a bug in an error path (reported by John Garry).
- Changed EXPORT_SYMBOL() into EXPORT_SYMBOL_GPL().
- Split patch 1/3 into two patches.

Changes compared to v2:
- Optimized the show_info == NULL case.
- Added a patch that removes the code that clears the module pointer in the host
  template.

Changes compared to v1:
- Fix the CONFIG_SCSI_PROC_FS=n build.

Bart Van Assche (4):
  scsi: esas2r: Initialize two host template members implicitly
  scsi: esas2r: Introduce scsi_template_proc_dir()
  scsi: core: Introduce a new list for SCSI proc directory entries
  scsi: core: Rework the code for dropping the LLD module reference

 drivers/scsi/esas2r/esas2r_main.c |  19 +++--
 drivers/scsi/scsi_priv.h          |   4 +-
 drivers/scsi/scsi_proc.c          | 120 ++++++++++++++++++++++++++----
 drivers/scsi/scsi_sysfs.c         |   7 +-
 include/scsi/scsi_device.h        |   1 +
 include/scsi/scsi_host.h          |  18 ++---
 6 files changed, 127 insertions(+), 42 deletions(-)

Comments

John Garry Sept. 14, 2022, 9:21 a.m. UTC | #1
On 13/09/2022 20:57, Bart Van Assche wrote:
> Hi Martin,
> 
> This patch series prepares for constifying SCSI host templates by moving the
> members that are not constant out of the SCSI host template. Please consider
> this patch series for the next merge window.
> 
> Thanks,
> 

note: I find that this series does not apply cleanly to mkp-scsi 6.1 
staging (which I guess it should), but ok for v6.0-c5

Thanks,
John

> Bart.
> 
> Changes compared to v3:
> - Changed the 'present' counter from 8 to 32 bits.
> - Fixed a bug in an error path (reported by John Garry).
> - Changed EXPORT_SYMBOL() into EXPORT_SYMBOL_GPL().
> - Split patch 1/3 into two patches.
> 
> Changes compared to v2:
> - Optimized the show_info == NULL case.
> - Added a patch that removes the code that clears the module pointer in the host
>    template.
> 
> Changes compared to v1:
> - Fix the CONFIG_SCSI_PROC_FS=n build.
> 
> Bart Van Assche (4):
>    scsi: esas2r: Initialize two host template members implicitly
>    scsi: esas2r: Introduce scsi_template_proc_dir()
>    scsi: core: Introduce a new list for SCSI proc directory entries
>    scsi: core: Rework the code for dropping the LLD module reference
> 
>   drivers/scsi/esas2r/esas2r_main.c |  19 +++--
>   drivers/scsi/scsi_priv.h          |   4 +-
>   drivers/scsi/scsi_proc.c          | 120 ++++++++++++++++++++++++++----
>   drivers/scsi/scsi_sysfs.c         |   7 +-
>   include/scsi/scsi_device.h        |   1 +
>   include/scsi/scsi_host.h          |  18 ++---
>   6 files changed, 127 insertions(+), 42 deletions(-)
> 
> 
> .
Bart Van Assche Sept. 14, 2022, 5:06 p.m. UTC | #2
On 9/14/22 02:21, John Garry wrote:
> note: I find that this series does not apply cleanly to mkp-scsi 6.1 
> staging (which I guess it should), but ok for v6.0-c5

Hi John,

A few reverts have been sent to Linus and are present in his tree but 
not in Martin's for-next branch. Hence the choice to base this patch 
series on Linus' master branch.

Thanks,

Bart.