diff mbox series

[4/8] scsi: FlashPoint: Remove unused variable 'TID' from 'FlashPoint_AbortCCB()'

Message ID 20210317091125.2910058-5-lee.jones@linaro.org
State New
Headers show
Series Rid W=1 warnings in SCSI | expand

Commit Message

Lee Jones March 17, 2021, 9:11 a.m. UTC
Fixes the following W=1 kernel build warning(s):

 drivers/scsi/FlashPoint.c: In function ‘FlashPoint_AbortCCB’:
 drivers/scsi/FlashPoint.c:1618:16: warning: variable ‘TID’ set but not used [-Wunused-but-set-variable]

Cc: Khalid Aziz <khalid@gonehiking.org>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/scsi/FlashPoint.c | 4 ----
 1 file changed, 4 deletions(-)

-- 
2.27.0

Comments

Khalid Aziz March 17, 2021, 5:02 p.m. UTC | #1
On 3/17/21 3:11 AM, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):

> 

>  drivers/scsi/FlashPoint.c: In function ‘FlashPoint_AbortCCB’:

>  drivers/scsi/FlashPoint.c:1618:16: warning: variable ‘TID’ set but not used [-Wunused-but-set-variable]

> 

> Cc: Khalid Aziz <khalid@gonehiking.org>

> Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>

> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>

> Cc: linux-scsi@vger.kernel.org

> Signed-off-by: Lee Jones <lee.jones@linaro.org>

> ---

>  drivers/scsi/FlashPoint.c | 4 ----

>  1 file changed, 4 deletions(-)

> 

> diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c

> index f479c542e787c..0464e37c806a4 100644

> --- a/drivers/scsi/FlashPoint.c

> +++ b/drivers/scsi/FlashPoint.c

> @@ -1615,7 +1615,6 @@ static int FlashPoint_AbortCCB(void *pCurrCard, struct sccb *p_Sccb)

>  

>  	unsigned char thisCard;

>  	CALL_BK_FN callback;

> -	unsigned char TID;

>  	struct sccb *pSaveSCCB;

>  	struct sccb_mgr_tar_info *currTar_Info;

>  

> @@ -1652,9 +1651,6 @@ static int FlashPoint_AbortCCB(void *pCurrCard, struct sccb *p_Sccb)

>  			}

>  

>  			else {

> -

> -				TID = p_Sccb->TargID;

> -

>  				if (p_Sccb->Sccb_tag) {

>  					MDISABLE_INT(ioport);

>  					if (((struct sccb_card *)pCurrCard)->

> 


Acked-by: Khalid Aziz <khalid@gonehiking.org>
diff mbox series

Patch

diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c
index f479c542e787c..0464e37c806a4 100644
--- a/drivers/scsi/FlashPoint.c
+++ b/drivers/scsi/FlashPoint.c
@@ -1615,7 +1615,6 @@  static int FlashPoint_AbortCCB(void *pCurrCard, struct sccb *p_Sccb)
 
 	unsigned char thisCard;
 	CALL_BK_FN callback;
-	unsigned char TID;
 	struct sccb *pSaveSCCB;
 	struct sccb_mgr_tar_info *currTar_Info;
 
@@ -1652,9 +1651,6 @@  static int FlashPoint_AbortCCB(void *pCurrCard, struct sccb *p_Sccb)
 			}
 
 			else {
-
-				TID = p_Sccb->TargID;
-
 				if (p_Sccb->Sccb_tag) {
 					MDISABLE_INT(ioport);
 					if (((struct sccb_card *)pCurrCard)->