[05/10] qla2xxx: Error code did not return to upper layer

Message ID	20230801114057.27039-6-njavali@marvell.com
State	Superseded
Headers	show Return-Path: <linux-scsi-owner@vger.kernel.org> From: Nilesh Javali <njavali@marvell.com> To: <martin.petersen@oracle.com> CC: <linux-scsi@vger.kernel.org>, <GR-QLogic-Storage-Upstream@marvell.com>, <agurumurthy@marvell.com>, <sdeodhar@marvell.com> Subject: [PATCH 05/10] qla2xxx: Error code did not return to upper layer Date: Tue, 1 Aug 2023 17:10:52 +0530 Message-ID: <20230801114057.27039-6-njavali@marvell.com> In-Reply-To: <20230801114057.27039-1-njavali@marvell.com> References: <20230801114057.27039-1-njavali@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk
Series	qla2xxx driver misc features \| expand [00/10] qla2xxx driver misc features [01/10] qla2xxx: Add NVMe Disconnect support [02/10] qla2xxx: Flush mailbox commands on chip reset [03/10] qla2xxx: Fix fw resource tracking [04/10] qla2xxx: Add logs for SFP temperature monitoring [05/10] qla2xxx: Error code did not return to upper layer [06/10] qla2xxx: Remove unsupported ql2xenabledif option. [07/10] qla2xxx: Observed call trace in smp_processor_id() [08/10] qla2xxx: fix smatch warn for qla_init_iocb_limit [09/10] Revert "scsi: qla2xxx: Fix buffer overrun" [10/10] qla2xxx: Update version to 10.02.09.100-k

Message ID

20230801114057.27039-6-njavali@marvell.com

State

Superseded

Headers

From: Nilesh Javali <njavali@marvell.com>
To: <martin.petersen@oracle.com>
CC: <linux-scsi@vger.kernel.org>,
        <GR-QLogic-Storage-Upstream@marvell.com>,
        <agurumurthy@marvell.com>, <sdeodhar@marvell.com>
Subject: [PATCH 05/10] qla2xxx: Error code did not return to upper layer
Date: Tue, 1 Aug 2023 17:10:52 +0530
Message-ID: <20230801114057.27039-6-njavali@marvell.com>
In-Reply-To: <20230801114057.27039-1-njavali@marvell.com>
References: <20230801114057.27039-1-njavali@marvell.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk

Series

qla2xxx driver misc features | expand

Commit Message

Nilesh Javali Aug. 1, 2023, 11:40 a.m. UTC

From: Quinn Tran <qutran@marvell.com>

TMF was returned with an error code. The error code was not
preserved to be returned to upper layer. Instead, the error code
from the Marker was returned.

Preserve error code from TMF and return it to upper layer.

Cc: stable@vger.kernel.org
Fixes: da7c21b72aa8 ("scsi: qla2xxx: Fix command flush during TMF")
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
---
 drivers/scsi/qla2xxx/qla_init.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index 7faf2109228e..3ab90c159034 100644
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -2223,6 +2223,8 @@  __qla2x00_async_tm_cmd(struct tmf_arg *arg)
 			rval = QLA_FUNCTION_FAILED;
 		}
 	}
+	if (tm_iocb->u.tmf.data)
+		rval = tm_iocb->u.tmf.data;
 
 done_free_sp:
 	/* ref: INIT */

[05/10] qla2xxx: Error code did not return to upper layer

Commit Message

Patch