mbox series

[PATCHv5,0/2] Fix imx53-ppd UART configuration

Message ID 20210430175038.103226-1-sebastian.reichel@collabora.com
Headers show
Series Fix imx53-ppd UART configuration | expand

Message

Sebastian Reichel April 30, 2021, 5:50 p.m. UTC
Hi,

IMHO PATCHv4 was better, but in the end I don't have strong feelings
about this. Btw. I think this patchset is a good demonstration of
frustrating upstream kernel development can be considering PATCHv5
is basically the same as PATCHv1. Thanks for making us go in
circles :(

Changes since PATCHv4:
 * https://lore.kernel.org/lkml/20210305115058.92284-1-sebastian.reichel@collabora.com/
 * use DT property instead of sysfs config option, like the initial patch
   version did as requested by Greg.

Changes since PATCHv3:
 * https://lore.kernel.org/lkml/1539249903-6316-1-git-send-email-fabien.lahoudere@collabora.com/
 * rewrote commit message to provide a lot more details why this is needed
 * rebased to torvalds/master (5.12-rc1-dontuse), also applies on top of linux-next
 * use sysfs_emit() instead of sprintf

-- Sebastian

Fabien Lahoudere (2):
  serial: imx: Add DMA buffer configuration via DT
  ARM: dts: imx53-ppd: add dma-info nodes

 .../bindings/serial/fsl-imx-uart.yaml         | 12 +++++++++
 arch/arm/boot/dts/imx53-ppd.dts               |  2 ++
 drivers/tty/serial/imx.c                      | 25 +++++++++++++------
 3 files changed, 32 insertions(+), 7 deletions(-)

Comments

Sebastian Reichel May 28, 2021, 12:49 a.m. UTC | #1
Hi Greg,

On Sat, May 01, 2021 at 08:11:52AM +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 30, 2021 at 07:50:36PM +0200, Sebastian Reichel wrote:

> > IMHO PATCHv4 was better, but in the end I don't have strong feelings

> > about this. Btw. I think this patchset is a good demonstration of

> > frustrating upstream kernel development can be considering PATCHv5

> > is basically the same as PATCHv1. Thanks for making us go in

> > circles :(

> > 

> > Changes since PATCHv4:

> >  * https://lore.kernel.org/lkml/20210305115058.92284-1-sebastian.reichel@collabora.com/

> >  * use DT property instead of sysfs config option, like the initial patch

> >    version did as requested by Greg.

> > 

> > Changes since PATCHv3:

> >  * https://lore.kernel.org/lkml/1539249903-6316-1-git-send-email-fabien.lahoudere@collabora.com/

> >  * rewrote commit message to provide a lot more details why this is needed

> >  * rebased to torvalds/master (5.12-rc1-dontuse), also applies on top of linux-next

> >  * use sysfs_emit() instead of sprintf

> > 

> > -- Sebastian

> > 

> > Fabien Lahoudere (2):

> >   serial: imx: Add DMA buffer configuration via DT

> >   ARM: dts: imx53-ppd: add dma-info nodes

> > 

> >  .../bindings/serial/fsl-imx-uart.yaml         | 12 +++++++++

> >  arch/arm/boot/dts/imx53-ppd.dts               |  2 ++

> >  drivers/tty/serial/imx.c                      | 25 +++++++++++++------

> >  3 files changed, 32 insertions(+), 7 deletions(-)

>

> This is the friendly semi-automated patch-bot of Greg Kroah-Hartman.

> You have sent him a patch that has triggered this response.

> 

> Right now, the development tree you have sent a patch for is "closed"

> due to the timing of the merge window.  Don't worry, the patch(es) you

> have sent are not lost, and will be looked at after the merge window is

> over (after the -rc1 kernel is released by Linus).

> 

> So thank you for your patience and your patches will be reviewed at this

> later time, you do not have to do anything further, this is just a short

> note to let you know the patch status and so you don't worry they didn't

> make it through.

> 

> thanks,

> 

> greg k-h's patch email bot


Any update on this? :)

-- Sebastian
Greg Kroah-Hartman May 28, 2021, 9:03 a.m. UTC | #2
On Fri, May 28, 2021 at 02:49:52AM +0200, Sebastian Reichel wrote:
> Hi Greg,

> 

> On Sat, May 01, 2021 at 08:11:52AM +0200, Greg Kroah-Hartman wrote:

> > On Fri, Apr 30, 2021 at 07:50:36PM +0200, Sebastian Reichel wrote:

> > > IMHO PATCHv4 was better, but in the end I don't have strong feelings

> > > about this. Btw. I think this patchset is a good demonstration of

> > > frustrating upstream kernel development can be considering PATCHv5

> > > is basically the same as PATCHv1. Thanks for making us go in

> > > circles :(

> > > 

> > > Changes since PATCHv4:

> > >  * https://lore.kernel.org/lkml/20210305115058.92284-1-sebastian.reichel@collabora.com/

> > >  * use DT property instead of sysfs config option, like the initial patch

> > >    version did as requested by Greg.

> > > 

> > > Changes since PATCHv3:

> > >  * https://lore.kernel.org/lkml/1539249903-6316-1-git-send-email-fabien.lahoudere@collabora.com/

> > >  * rewrote commit message to provide a lot more details why this is needed

> > >  * rebased to torvalds/master (5.12-rc1-dontuse), also applies on top of linux-next

> > >  * use sysfs_emit() instead of sprintf

> > > 

> > > -- Sebastian

> > > 

> > > Fabien Lahoudere (2):

> > >   serial: imx: Add DMA buffer configuration via DT

> > >   ARM: dts: imx53-ppd: add dma-info nodes

> > > 

> > >  .../bindings/serial/fsl-imx-uart.yaml         | 12 +++++++++

> > >  arch/arm/boot/dts/imx53-ppd.dts               |  2 ++

> > >  drivers/tty/serial/imx.c                      | 25 +++++++++++++------

> > >  3 files changed, 32 insertions(+), 7 deletions(-)

> >

> > This is the friendly semi-automated patch-bot of Greg Kroah-Hartman.

> > You have sent him a patch that has triggered this response.

> > 

> > Right now, the development tree you have sent a patch for is "closed"

> > due to the timing of the merge window.  Don't worry, the patch(es) you

> > have sent are not lost, and will be looked at after the merge window is

> > over (after the -rc1 kernel is released by Linus).

> > 

> > So thank you for your patience and your patches will be reviewed at this

> > later time, you do not have to do anything further, this is just a short

> > note to let you know the patch status and so you don't worry they didn't

> > make it through.

> > 

> > thanks,

> > 

> > greg k-h's patch email bot

> 

> Any update on this? :)


I'm waiting for the DT maintainers to review the new changes before I
can take the driver changes.

thanks,

greg k-h
Krzysztof Kozlowski Dec. 8, 2023, 12:14 p.m. UTC | #3
On 08/12/2023 11:32, Greg Kroah-Hartman wrote:
> On Fri, Dec 08, 2023 at 10:07:54AM +0100, Uwe Kleine-König wrote:
>> [Cc += dt maintainers]
>>
>> On Fri, Apr 30, 2021 at 07:50:36PM +0200, Sebastian Reichel wrote:
> 
> You are responding to a message from 2021???
> 
> I can't remember what I wrote in an email last week, let alone years
> ago, are you sure any of this is relevant still?
> 

Also, adding DT maintainers as Cc, does not magically allow us to
understand the discussion. Please shortly summarize what do you
need/expect from us.

Best regards,
Krzysztof
Ian Ray Dec. 14, 2023, 12:49 p.m. UTC | #4
On Fri, Dec 08, 2023 at 01:14:50PM +0100, Krzysztof Kozlowski wrote:
> 
> On 08/12/2023 11:32, Greg Kroah-Hartman wrote:
> > On Fri, Dec 08, 2023 at 10:07:54AM +0100, Uwe Kleine-K??nig wrote:
> >> [Cc += dt maintainers]
> >>
> >> On Fri, Apr 30, 2021 at 07:50:36PM +0200, Sebastian Reichel wrote:
> > 
> > You are responding to a message from 2021???
> > 
> > I can't remember what I wrote in an email last week, let alone years
> > ago, are you sure any of this is relevant still?
> > 
> 
> Also, adding DT maintainers as Cc, does not magically allow us to
> understand the discussion. Please shortly summarize what do you
> need/expect from us.

This thread is indeed old, but we are remain interested in getting
this resolved.


The topic itself is about the tuning of DMA buffers for the i.MX53
platform.

DMA is required (for the 4M baud UART case), and a specific buffer
configuration is required, too.


Two approaches have been attempted:

"V4" sysfs
https://lore.kernel.org/lkml/20210305115058.92284-1-sebastian.reichel@collabora.com/

"V5" DT
https://lore.kernel.org/lkml/20210430175038.103226-1-sebastian.reichel@collabora.com/
(this thread)


Uwe recently commented to [1], and (hoping to avoid any further
confusion) let's continue in that thread.

[1] https://lore.kernel.org/lkml/20231208090205.ioc76sych3snjiwb@pengutronix.de/


> 
> Best regards,
> Krzysztof
> 
>