| Message ID | 20210730144922.29111-4-semen.protsenko@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add minimal support for Exynos850 SoC | expand |
On 30/07/2021 16:49, Sam Protsenko wrote: > Document compatible string for Exynos850 SoC. Nothing else is changed, > as Exynos850 SoC uses already existing samsung pinctrl driver. > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > --- > Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt | 1 + > 1 file changed, 1 insertion(+) > The patch should be first in the series - dt-bindings go at beginning. Although no need to resend just for this. If the resend happens, the fix ("pinctrl: samsung: Fix pinctrl bank pin count") should be sent separately (no mixing fixes and new features) because they are independent and usually easier for review. Best regards, Krzysztof
On Fri, 30 Jul 2021 at 18:25, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > On 30/07/2021 16:49, Sam Protsenko wrote: > > Document compatible string for Exynos850 SoC. Nothing else is changed, > > as Exynos850 SoC uses already existing samsung pinctrl driver. > > > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > > --- > > Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > The patch should be first in the series - dt-bindings go at beginning. > Although no need to resend just for this. > If the resend happens, the fix ("pinctrl: samsung: Fix pinctrl bank pin > count") should be sent separately (no mixing fixes and new features) > because they are independent and usually easier for review. > Thanks, will be done in v2. Also, just re-sent ("pinctrl: samsung: Fix pinctrl bank pin count") fix separately, as you recommended. > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt index 38a1416fd2cd..e7a1b1880375 100644 --- a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt +++ b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt @@ -22,6 +22,7 @@ Required Properties: - "samsung,exynos5420-pinctrl": for Exynos5420 compatible pin-controller. - "samsung,exynos5433-pinctrl": for Exynos5433 compatible pin-controller. - "samsung,exynos7-pinctrl": for Exynos7 compatible pin-controller. + - "samsung,exynos850-pinctrl": for Exynos850 compatible pin-controller. - reg: Base address of the pin controller hardware module and length of the address space it occupies.
Document compatible string for Exynos850 SoC. Nothing else is changed, as Exynos850 SoC uses already existing samsung pinctrl driver. Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> --- Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt | 1 + 1 file changed, 1 insertion(+) -- 2.30.2