| Message ID | 1f39432b-84e2-e6dc-a6b8-c48ad5cf2210@gmail.com |
|---|---|
| Headers | show |
| Series | auxdisplay: Add support for the Titanmec TM1628 7 segment display controller | expand |
On 21.02.2022 23:10, Miguel Ojeda wrote: > On Mon, Feb 21, 2022 at 9:19 PM Heiner Kallweit <hkallweit1@gmail.com> wrote: >> >> v2: >> - (re-)add Andreas' SoB to two patches > > But those were also developed by you too, right? i.e. it should have a > Co-developed-by too, otherwise it looks like you only handled the > patch: > Right, about half of the original code was reworked. Let's see whether and which feedback comes for v2. If a v3 should be needed, I'll follow your suggestion. > ``` > Example of a patch submitted by the From: author:: > > <changelog> > > Co-developed-by: First Co-Author <first@coauthor.example.org> > Signed-off-by: First Co-Author <first@coauthor.example.org> > Co-developed-by: Second Co-Author <second@coauthor.example.org> > Signed-off-by: Second Co-Author <second@coauthor.example.org> > Signed-off-by: From Author <from@author.example.org> > ``` > > Cheers, > Miguel Heiner
On 21.02.22 23:57, Heiner Kallweit wrote: > On 21.02.2022 23:10, Miguel Ojeda wrote: >> On Mon, Feb 21, 2022 at 9:19 PM Heiner Kallweit <hkallweit1@gmail.com> wrote: >>> >>> v2: >>> - (re-)add Andreas' SoB to two patches >> >> But those were also developed by you too, right? i.e. it should have a >> Co-developed-by too, otherwise it looks like you only handled the >> patch: >> > > Right, about half of the original code was reworked. Let's see whether and > which feedback comes for v2. If a v3 should be needed, I'll follow your > suggestion. The dispute is that he apparently only looked at my RFC but didn't ask me or check himself for newer code, which there was. Regards, Andreas
This series adds support for the Titanmec TM1628 7 segment display controller. It's based on previous RFC work from Andreas Färber. The RFC version placed the driver in the LED subsystem, but this was NAK'ed by the LED maintainer. Therefore I moved the driver to /drivers/auxdisplay what seems most reasonable to me. To be decided is through which tree this series should go. I'd think SPI would be most suited, but that's a decision I leave up to the respective maintainers. Further changes to the RFC version: - Driver can be built also w/o LED class support, for displays that don't have any symbols to be exposed as LED's. - Simplified the code and rewrote a lot of it. - Driver is now kind of a MVP, but functionality should be sufficient for most use cases. - Use the existing 7 segment support in uapi/linux/map_to_7segment.h as suggested by Geert Uytterhoeven. Note: There's a number of chips from other manufacturers that are almost identical, e.g. FD628, SM1628. Only difference I saw so far is that they partially support other display modes. TM1628: 6x12, 7x11 SM1628C: 4x13, 5x12, 6x11, 7x10 For typical displays on devices using these chips this difference shouldn't matter. Successfully tested on a TX3 Mini TV box that has an SM1628C and a display with 4 digits and 7 symbols. v2: - (re-)add Andreas' SoB to two patches - fix YAML issues - include ctype.h explicitly - add info message in probe() Andreas Färber (2): spi: gpio: Implement LSB First bitbang support dt-bindings: vendor-prefixes: Add Titan Micro Electronics Heiner Kallweit (4): dt-bindings: auxdisplay: Add Titan Micro Electronics TM1628 docs: ABI: document tm1628 attribute display-text auxdisplay: add support for Titanmec TM1628 7 segment display controller arm64: dts: meson-gxl-s905w-tx3-mini: add support for the 7 segment display .../testing/sysfs-devices-auxdisplay-tm1628 | 7 + .../bindings/auxdisplay/titanmec,tm1628.yaml | 88 ++++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + .../dts/amlogic/meson-gxl-s905w-tx3-mini.dts | 59 +++ drivers/auxdisplay/Kconfig | 10 + drivers/auxdisplay/Makefile | 1 + drivers/auxdisplay/tm1628.c | 376 ++++++++++++++++++ drivers/spi/spi-bitbang-txrx.h | 66 +++ drivers/spi/spi-gpio.c | 42 +- 9 files changed, 642 insertions(+), 9 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-devices-auxdisplay-tm1628 create mode 100644 Documentation/devicetree/bindings/auxdisplay/titanmec,tm1628.yaml create mode 100644 drivers/auxdisplay/tm1628.c