| Message ID | 20230307211426.2331483-1-u.kleine-koenig@pengutronix.de |
|---|---|
| Headers | show |
| Series | spi: sprd: Convert to platform remove callback returning void | expand |
On Tue, 07 Mar 2023 22:14:24 +0100, Uwe Kleine-König wrote: > An early error return from a remove callback is usally wrong. In the > case of the spi-sprd driver it's not that critical because the skipped > steps are mainly undoing the things that a successful runtime-resume > would have done. > > Still it's cleaner to not exit early and not return an (mostly ignored) > error value. The second patch converts to .remove_new (which is the > motivation for this series). > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/2] spi: sprd: Don't skip cleanup in remove's error path commit: 5cb79889a0bab6832662ec5b8f7d1f0e6e7c25ed [2/2] spi: sprd: Convert to platform remove callback returning void commit: 3b74dc8acd5c2e59d4a1988a87d64b08fba56d5f All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
From: Uwe Kleine-König <uwe@kleine-koenig.org> Hello, An early error return from a remove callback is usally wrong. In the case of the spi-sprd driver it's not that critical because the skipped steps are mainly undoing the things that a successful runtime-resume would have done. Still it's cleaner to not exit early and not return an (mostly ignored) error value. The second patch converts to .remove_new (which is the motivation for this series). Best regards Uwe Uwe Kleine-König (2): spi: sprd: Don't skip cleanup in remove's error path spi: sprd: Convert to platform remove callback returning void drivers/spi/spi-sprd.c | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6