diff mbox series

[v5,1/9] dt-bindings: clock: tegra: Add clock ID TEGRA210_CLK_QSPI_PM

Message ID 1608585459-17250-2-git-send-email-skomatineni@nvidia.com
State Accepted
Commit 88893986338beebcf5317bda80d43d4f6f7f7c7c
Headers show
Series Add Tegra Quad SPI driver | expand

Commit Message

Sowjanya Komatineni Dec. 21, 2020, 9:17 p.m. UTC
Tegra210 QSPI clock output has divider DIV2_SEL which will be enabled
when using DDR interface mode.

This patch adds clock ID for this to dt-binding.

Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
---
 include/dt-bindings/clock/tegra210-car.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thierry Reding Jan. 26, 2021, 10:03 a.m. UTC | #1
On Mon, Dec 21, 2020 at 01:17:31PM -0800, Sowjanya Komatineni wrote:
> Tegra210 QSPI clock output has divider DIV2_SEL which will be enabled

> when using DDR interface mode.

> 

> This patch adds clock ID for this to dt-binding.

> 

> Acked-by: Rob Herring <robh@kernel.org>

> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>

> ---

>  include/dt-bindings/clock/tegra210-car.h | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)


Hi Mark,

It looks like you applied this patch along with the driver patches.
Unfortunately, if I apply the DT updates without this patch, the DT
files will fail to build because this symbol is missing.

Since the TEGRA210_CLK_QSPI_PM symbol isn't used by the driver patches
directly, would you mind dropping this so that I can pick it up into the
Tegra tree along with the DT updates?

I realize this is completely unobvious, so sorry for not noticing and
bringing this up earlier.

Thanks,
Thierry
Mark Brown Jan. 26, 2021, 12:23 p.m. UTC | #2
On Tue, Jan 26, 2021 at 11:03:42AM +0100, Thierry Reding wrote:

> Since the TEGRA210_CLK_QSPI_PM symbol isn't used by the driver patches

> directly, would you mind dropping this so that I can pick it up into the

> Tegra tree along with the DT updates?


Sure, can you send me a revert commit dropping it?  Or it might be fine
just to double commit it, I suspect git will work things out when
merging.
diff mbox series

Patch

diff --git a/include/dt-bindings/clock/tegra210-car.h b/include/dt-bindings/clock/tegra210-car.h
index ab8b8a7..9cfcc3b 100644
--- a/include/dt-bindings/clock/tegra210-car.h
+++ b/include/dt-bindings/clock/tegra210-car.h
@@ -307,7 +307,7 @@ 
 #define TEGRA210_CLK_AUDIO4 275
 #define TEGRA210_CLK_SPDIF 276
 /* 277 */
-/* 278 */
+#define TEGRA210_CLK_QSPI_PM 278
 /* 279 */
 /* 280 */
 #define TEGRA210_CLK_SOR0_LVDS 281 /* deprecated */