| Message ID | 20220406233648.21644-5-brad@pensando.io |
|---|---|
| State | New |
| Headers | show |
| Series | Support Pensando Elba SoC | expand |
> [PATCH 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC I think you need to be more specific in the patch title to what bindings you are adding the new compatible string. Something like this "dt-bindings: spi: cdns: ..." The same concerns the patch "[PATCH 03/11] dt-bindings: mmc: Add Pensando Elba SoC binding". Otherwise it isn't clear to what schema you are adding the Elba SoC support to. -Sergey On Wed, Apr 06, 2022 at 04:36:41PM -0700, Brad Larson wrote: > Document the cadence qspi controller compatible for Pensando Elba SoC > boards. The Elba qspi fifo size is 1024. > > Signed-off-by: Brad Larson <brad@pensando.io> > --- > Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > index 0a537fa3a641..bc298e413842 100644 > --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > @@ -30,6 +30,7 @@ properties: > - intel,lgm-qspi > - xlnx,versal-ospi-1.0 > - intel,socfpga-qspi > + - pensando,elba-qspi > - const: cdns,qspi-nor > - const: cdns,qspi-nor > > @@ -48,7 +49,7 @@ properties: > description: > Size of the data FIFO in words. > $ref: "/schemas/types.yaml#/definitions/uint32" > - enum: [ 128, 256 ] > + enum: [ 128, 256, 1024 ] > default: 128 > > cdns,fifo-width: > -- > 2.17.1 >
Hi Krzysztof, On Thu, Apr 7, 2022 at 11:59 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 07/04/2022 01:36, Brad Larson wrote: > > Document the cadence qspi controller compatible for Pensando Elba SoC > > boards. The Elba qspi fifo size is 1024. > > > > @@ -48,7 +49,7 @@ properties: > > description: > > Size of the data FIFO in words. > > $ref: "/schemas/types.yaml#/definitions/uint32" > > - enum: [ 128, 256 ] > > + enum: [ 128, 256, 1024 ] > > Is 1024 valid for other controllers? If not, then probably this should > be further constraint in allOf:if:then... I'll change this to allOf:if:then so that the 1024 deep FIFO is specific to Elba SoC. Regards, Brad
Hi Sergey, On Tue, Apr 12, 2022 at 4:37 AM Serge Semin <fancer.lancer@gmail.com> wrote: > > > [PATCH 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC > > I think you need to be more specific in the patch title to what bindings > you are adding the new compatible string. Something like this > "dt-bindings: spi: cdns: ..." > The same concerns the patch "[PATCH 03/11] dt-bindings: mmc: Add Pensando > Elba SoC binding". > Otherwise it isn't clear to what schema you are adding the Elba SoC > support to. Thanks for the review, I'll add more specifics to the bindings patch title. Regards, Brad
diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml index 0a537fa3a641..bc298e413842 100644 --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml @@ -30,6 +30,7 @@ properties: - intel,lgm-qspi - xlnx,versal-ospi-1.0 - intel,socfpga-qspi + - pensando,elba-qspi - const: cdns,qspi-nor - const: cdns,qspi-nor @@ -48,7 +49,7 @@ properties: description: Size of the data FIFO in words. $ref: "/schemas/types.yaml#/definitions/uint32" - enum: [ 128, 256 ] + enum: [ 128, 256, 1024 ] default: 128 cdns,fifo-width:
Document the cadence qspi controller compatible for Pensando Elba SoC boards. The Elba qspi fifo size is 1024. Signed-off-by: Brad Larson <brad@pensando.io> --- Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)