mbox series

[00/30] Fix a bunch of W=1 issues in USB

Message ID 20200702144625.2533530-1-lee.jones@linaro.org
Headers show
Series Fix a bunch of W=1 issues in USB | expand

Message

Lee Jones July 2, 2020, 2:45 p.m. UTC 
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

Lee Jones (30):
  usb: phy: phy: Fix-up a whole bunch of formatting issues
  usb: host: pci-quirks: Demote function header from kerneldoc to
    comment block
  usb: common: debug: Demote comment blocks which are obviously not
    kerneldoc
  usb: common: usb-conn-gpio: Demote comment block which is clearly not
    kerneldoc
  usb: dwc3: drd: File headers are not doc headers
  usb: dwc3: ulpi: File headers are not doc headers
  usb: common: ulpi: Fix a few kerneldoc related issues
  usb: dwc3: dwc3-omap: Do not read DMA status
  usb: dwc2: gadget: Do not read GINTMSK2
  usb: dwc2: gadget: Remove assigned but never used 'maxsize'
  usb: dwc2: gadget: Avoid pointless read of EP control register
  usb: host: ehci-omap: Provide documentation for
    ehci_hcd_omap_probe()'s arg 'pdev'
  usb: cdns3: core: Fix incorrect formatting and misspelled function arg
    docs
  usb: cdns3: ep0: Fix a bunch of kerneldoc issues
  usb: dwc3: dwc3-haps: Function headers are not suitable for kerneldoc
  usb: mtu3: mtu3_trace: Function headers are not suitable for kerneldoc
  usb: cdns3: gadget: Fix a bunch of kernel doc issues
  usb: dwc3: dwc3-of-simple: Function headers are not good candidates
    for kerneldoc
  usb: host: isp1362: Mark the many unused ISP1362_REG entries as
    __maybe_unused
  usb: host: ohci-at91: Demote kerneldoc headers down to basic comment
    blocks
  usb: host: ohci: Mark cc_to_error as __maybe_unused
  usb: cdns3: ep0: Move 'zlp' description to appropriate function header
  usb: host: oxu210hp-hcd: Move declaration of 'qtd' into 'ifdef
    OXU_URB_TRACE'
  usb: mtu3: mtu3_trace: Supply missing mtu3_debug.h include file
  usb: mtu3: mtu3_core: Demote obvious misuse of kerneldoc to standard
    comment block
  usb: c67x00: c67x00-ll-hpi: Demote obvious misuse of kerneldoc to
    standard comment blocks
  usb: class: cdc-wdm: Provide description for usb_cdc_wdm_register()'s
    manage_power arg
  usb: c67x00: c67x00-hcd: Demote obvious misuse of kerneldoc to
    standard comment blocks
  usb: class: usbtmc: File headers are not good candidates for kerneldoc
  usb: c67x00: c67x00-sched: Demote obvious misuse of kerneldoc to
    standard comment blocks

 drivers/usb/c67x00/c67x00-hcd.c    |  6 ++--
 drivers/usb/c67x00/c67x00-ll-hpi.c |  6 ++--
 drivers/usb/c67x00/c67x00-sched.c  | 26 ++++++++--------
 drivers/usb/cdns3/core.c           |  8 ++---
 drivers/usb/cdns3/ep0.c            | 12 ++++++--
 drivers/usb/cdns3/gadget.c         | 11 ++++---
 drivers/usb/class/cdc-wdm.c        |  3 +-
 drivers/usb/class/usbtmc.c         |  2 +-
 drivers/usb/common/debug.c         |  4 +--
 drivers/usb/common/ulpi.c          |  5 +--
 drivers/usb/common/usb-conn-gpio.c |  2 +-
 drivers/usb/dwc2/gadget.c          |  7 +----
 drivers/usb/dwc3/drd.c             |  2 +-
 drivers/usb/dwc3/dwc3-haps.c       |  2 +-
 drivers/usb/dwc3/dwc3-of-simple.c  |  2 +-
 drivers/usb/dwc3/dwc3-omap.c       |  7 +----
 drivers/usb/dwc3/ulpi.c            |  2 +-
 drivers/usb/host/ehci-omap.c       |  1 +
 drivers/usb/host/isp1362.h         |  2 +-
 drivers/usb/host/ohci-at91.c       |  5 ++-
 drivers/usb/host/ohci.h            |  2 +-
 drivers/usb/host/oxu210hp-hcd.c    |  7 ++---
 drivers/usb/host/pci-quirks.c      |  2 +-
 drivers/usb/mtu3/mtu3_core.c       |  2 +-
 drivers/usb/mtu3/mtu3_trace.c      |  3 +-
 drivers/usb/phy/phy.c              | 49 +++++++++++++++---------------
 26 files changed, 90 insertions(+), 90 deletions(-)

-- 
2.25.1

Comments

Greg Kroah-Hartman July 3, 2020, 7:37 a.m. UTC | #1 
On Thu, Jul 02, 2020 at 03:45:55PM +0100, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1

> kernel builds, which are currently overwhelmingly riddled with

> niggly little warnings.

> 

> Lee Jones (30):

>   usb: phy: phy: Fix-up a whole bunch of formatting issues

>   usb: host: pci-quirks: Demote function header from kerneldoc to

>     comment block

>   usb: common: debug: Demote comment blocks which are obviously not

>     kerneldoc

>   usb: common: usb-conn-gpio: Demote comment block which is clearly not

>     kerneldoc

>   usb: dwc3: drd: File headers are not doc headers

>   usb: dwc3: ulpi: File headers are not doc headers

>   usb: common: ulpi: Fix a few kerneldoc related issues

>   usb: dwc3: dwc3-omap: Do not read DMA status

>   usb: dwc2: gadget: Do not read GINTMSK2

>   usb: dwc2: gadget: Remove assigned but never used 'maxsize'

>   usb: dwc2: gadget: Avoid pointless read of EP control register

>   usb: host: ehci-omap: Provide documentation for

>     ehci_hcd_omap_probe()'s arg 'pdev'

>   usb: cdns3: core: Fix incorrect formatting and misspelled function arg

>     docs

>   usb: cdns3: ep0: Fix a bunch of kerneldoc issues

>   usb: dwc3: dwc3-haps: Function headers are not suitable for kerneldoc

>   usb: mtu3: mtu3_trace: Function headers are not suitable for kerneldoc

>   usb: cdns3: gadget: Fix a bunch of kernel doc issues

>   usb: dwc3: dwc3-of-simple: Function headers are not good candidates

>     for kerneldoc

>   usb: host: isp1362: Mark the many unused ISP1362_REG entries as

>     __maybe_unused

>   usb: host: ohci-at91: Demote kerneldoc headers down to basic comment

>     blocks

>   usb: host: ohci: Mark cc_to_error as __maybe_unused

>   usb: cdns3: ep0: Move 'zlp' description to appropriate function header

>   usb: host: oxu210hp-hcd: Move declaration of 'qtd' into 'ifdef

>     OXU_URB_TRACE'

>   usb: mtu3: mtu3_trace: Supply missing mtu3_debug.h include file

>   usb: mtu3: mtu3_core: Demote obvious misuse of kerneldoc to standard

>     comment block

>   usb: c67x00: c67x00-ll-hpi: Demote obvious misuse of kerneldoc to

>     standard comment blocks

>   usb: class: cdc-wdm: Provide description for usb_cdc_wdm_register()'s

>     manage_power arg

>   usb: c67x00: c67x00-hcd: Demote obvious misuse of kerneldoc to

>     standard comment blocks

>   usb: class: usbtmc: File headers are not good candidates for kerneldoc

>   usb: c67x00: c67x00-sched: Demote obvious misuse of kerneldoc to

>     standard comment blocks


I've applied 25 of these, if you could rebase and resend the remaining
ones, after fixing up the review comments made on them, that would be
wonderful.

thanks,

greg k-h
Lee Jones July 3, 2020, 5:21 p.m. UTC | #2 
On Fri, 03 Jul 2020, Greg KH wrote:

> On Thu, Jul 02, 2020 at 03:45:55PM +0100, Lee Jones wrote:

> > This set is part of a larger effort attempting to clean-up W=1

> > kernel builds, which are currently overwhelmingly riddled with

> > niggly little warnings.

> > 

> > Lee Jones (30):

> >   usb: phy: phy: Fix-up a whole bunch of formatting issues

> >   usb: host: pci-quirks: Demote function header from kerneldoc to

> >     comment block

> >   usb: common: debug: Demote comment blocks which are obviously not

> >     kerneldoc

> >   usb: common: usb-conn-gpio: Demote comment block which is clearly not

> >     kerneldoc

> >   usb: dwc3: drd: File headers are not doc headers

> >   usb: dwc3: ulpi: File headers are not doc headers

> >   usb: common: ulpi: Fix a few kerneldoc related issues

> >   usb: dwc3: dwc3-omap: Do not read DMA status

> >   usb: dwc2: gadget: Do not read GINTMSK2

> >   usb: dwc2: gadget: Remove assigned but never used 'maxsize'

> >   usb: dwc2: gadget: Avoid pointless read of EP control register

> >   usb: host: ehci-omap: Provide documentation for

> >     ehci_hcd_omap_probe()'s arg 'pdev'

> >   usb: cdns3: core: Fix incorrect formatting and misspelled function arg

> >     docs

> >   usb: cdns3: ep0: Fix a bunch of kerneldoc issues

> >   usb: dwc3: dwc3-haps: Function headers are not suitable for kerneldoc

> >   usb: mtu3: mtu3_trace: Function headers are not suitable for kerneldoc

> >   usb: cdns3: gadget: Fix a bunch of kernel doc issues

> >   usb: dwc3: dwc3-of-simple: Function headers are not good candidates

> >     for kerneldoc

> >   usb: host: isp1362: Mark the many unused ISP1362_REG entries as

> >     __maybe_unused

> >   usb: host: ohci-at91: Demote kerneldoc headers down to basic comment

> >     blocks

> >   usb: host: ohci: Mark cc_to_error as __maybe_unused

> >   usb: cdns3: ep0: Move 'zlp' description to appropriate function header

> >   usb: host: oxu210hp-hcd: Move declaration of 'qtd' into 'ifdef

> >     OXU_URB_TRACE'

> >   usb: mtu3: mtu3_trace: Supply missing mtu3_debug.h include file

> >   usb: mtu3: mtu3_core: Demote obvious misuse of kerneldoc to standard

> >     comment block

> >   usb: c67x00: c67x00-ll-hpi: Demote obvious misuse of kerneldoc to

> >     standard comment blocks

> >   usb: class: cdc-wdm: Provide description for usb_cdc_wdm_register()'s

> >     manage_power arg

> >   usb: c67x00: c67x00-hcd: Demote obvious misuse of kerneldoc to

> >     standard comment blocks

> >   usb: class: usbtmc: File headers are not good candidates for kerneldoc

> >   usb: c67x00: c67x00-sched: Demote obvious misuse of kerneldoc to

> >     standard comment blocks

> 

> I've applied 25 of these, if you could rebase and resend the remaining

> ones, after fixing up the review comments made on them, that would be

> wonderful.


Will do.  Thanks Greg.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog