From patchwork Tue Sep 9 08:44:11 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Baldyga X-Patchwork-Id: 37055 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qg0-f71.google.com (mail-qg0-f71.google.com [209.85.192.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 8B73220C93 for ; Tue, 9 Sep 2014 08:51:58 +0000 (UTC) Received: by mail-qg0-f71.google.com with SMTP id a108sf15325194qge.2 for ; Tue, 09 Sep 2014 01:51:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=LR8QMsRnmooeQRTZG2O8IE3Tn3zFBGuuyvRCS18GKU8=; b=PSbEiaA1gvagWO/XjRXYJLFeb7Rwacgl4D0UAW5FBc69DQnSZQgEHMPzwh2EMWl134 V7R+uXObc4IXWUgqhNcJQu2LENxKnJ2MvWUCaNDs9QJR9buirlu5Ed+KX8CAst6+1ivN Xh135TAQHhMLQ2Bm0QjHIIMWIkB5om6enECzKXLBgLvCsIzlSxKvO8x5jGKSfzsf4eLk VTxHcrbDXpSBtjPt+niz0fJhbk6b9lQatXAfS4w1sjc4ZcLcxm0/s9/peUabSSoMHJJ8 lBo5yB++wgtZMOV8nb/dOxRen1WZJMM8jw5SSrOuFZ3lSfEQsaQ8v3H8DyzZP/yUD9L0 eqBg== X-Gm-Message-State: ALoCoQm2jGoZ016NJEzA2+P87fNsOyzq8esGr3Zu1suWgfIbhd6wrMEodeOJZczbB8ZmR23ovEhr X-Received: by 10.236.31.129 with SMTP id m1mr7313020yha.47.1410252718428; Tue, 09 Sep 2014 01:51:58 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.107.70 with SMTP id g64ls2154960qgf.85.gmail; Tue, 09 Sep 2014 01:51:58 -0700 (PDT) X-Received: by 10.52.83.227 with SMTP id t3mr23731830vdy.20.1410252718313; Tue, 09 Sep 2014 01:51:58 -0700 (PDT) Received: from mail-vc0-f175.google.com (mail-vc0-f175.google.com [209.85.220.175]) by mx.google.com with ESMTPS id cj7si4959348vcb.44.2014.09.09.01.51.58 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 09 Sep 2014 01:51:58 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.175 as permitted sender) client-ip=209.85.220.175; Received: by mail-vc0-f175.google.com with SMTP id lf12so16491187vcb.20 for ; Tue, 09 Sep 2014 01:51:58 -0700 (PDT) X-Received: by 10.52.245.101 with SMTP id xn5mr12050139vdc.32.1410252718239; Tue, 09 Sep 2014 01:51:58 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp251876vcb; Tue, 9 Sep 2014 01:51:57 -0700 (PDT) X-Received: by 10.69.31.139 with SMTP id km11mr2722507pbd.67.1410252716787; Tue, 09 Sep 2014 01:51:56 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id yw3si16441520pac.41.2014.09.09.01.51.56 for ; Tue, 09 Sep 2014 01:51:56 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932424AbaIIIvq (ORCPT + 26 others); Tue, 9 Sep 2014 04:51:46 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:65014 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932152AbaIIIok (ORCPT ); Tue, 9 Sep 2014 04:44:40 -0400 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NBM00IX8LMEEXB0@mailout2.samsung.com>; Tue, 09 Sep 2014 17:44:38 +0900 (KST) X-AuditID: cbfee61a-f79e46d00000134f-ca-540ebdf65372 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 30.9B.04943.6FDBE045; Tue, 09 Sep 2014 17:44:38 +0900 (KST) Received: from AMDC2122.DIGITAL.local ([106.120.53.17]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NBM00GF4LLTCSA0@mmp2.samsung.com>; Tue, 09 Sep 2014 17:44:38 +0900 (KST) From: Robert Baldyga To: Paul.Zimmerman@synopsys.com Cc: gregkh@linuxfoundation.org, balbi@ti.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Szyprowski , Robert Baldyga Subject: [PATCH 4/6] usb: dwc2/gadget: do not call disconnect method in pullup Date: Tue, 09 Sep 2014 10:44:11 +0200 Message-id: <1410252253-13687-5-git-send-email-r.baldyga@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1410252253-13687-1-git-send-email-r.baldyga@samsung.com> References: <1410252253-13687-1-git-send-email-r.baldyga@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCLMWRmVeSWpSXmKPExsVy+t9jQd1ve/lCDM7+17Q4eL/eonnxejaL y7vmsFksWtbKbLH2yF12i0cPt7JaPDi8k92B3WP/3DXsHn1bVjF6bNn/mdHj+I3tTB6fN8kF sEZx2aSk5mSWpRbp2yVwZfzYMJe1YB5bxe5nE1kaGBexdjFyckgImEgcnX0ayhaTuHBvPVsX IxeHkMB0RonjL74wQTjtTBK9y7pZQKrYBHQktnyfwAhiiwjIS1zfeJMFpIhZYB+jxPRP29hB EsICfhLn+leAFbEIqEpsO/6GGcTmFXCVOPNhAhPEOjmJk8cmg63mFHCTmN/bzwZiCwHVdD5Z yziBkXcBI8MqRtHUguSC4qT0XEO94sTc4tK8dL3k/NxNjOCweia1g3Flg8UhRgEORiUe3oxg vhAh1sSy4srcQ4wSHMxKIrxXdgOFeFMSK6tSi/Lji0pzUosPMUpzsCiJ8x5otQ4UEkhPLEnN Tk0tSC2CyTJxcEo1MC5wcizmLj/sG3bjwr/r0hdr9n1W+pn5ffI1jxP8d5g7/OKTWs68OLTc WYsrYqXyTrvtWwp/pievrPPOL9gUFrDuheOV1V8fqblfvj13/sGnpeGV64tfMjeVqrMV9Ly+ vXrHs9VKh9bzHlQ7qz1to2/KtKlb0ie9vtGQ9SDWOHR79o6Kg+9Dj0opsRRnJBpqMRcVJwIA oq4FGCcCAAA= Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: linux-kernel-owner@vger.kernel.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.175 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Marek Szyprowski This leads to potential spinlock recursion in composite framework, other udc drivers also don't call it directly from pullup method. Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index a451eef..474eae2 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -2942,7 +2942,6 @@ static int s3c_hsotg_pullup(struct usb_gadget *gadget, int is_on) s3c_hsotg_phy_enable(hsotg); s3c_hsotg_core_init(hsotg); } else { - s3c_hsotg_disconnect(hsotg); s3c_hsotg_phy_disable(hsotg); }