From patchwork Sat Oct 18 01:23:26 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 39003 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f70.google.com (mail-ee0-f70.google.com [74.125.83.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 873722054E for ; Sat, 18 Oct 2014 01:24:08 +0000 (UTC) Received: by mail-ee0-f70.google.com with SMTP id c13sf1084843eek.9 for ; Fri, 17 Oct 2014 18:24:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=iS5nluSkWqYbt2EIhzzFH38XRP0yVuEbOvdomxGuLF0=; b=C6FosKQjVyVkddbqQ0LCwY3jHfC3/UOAuGgFDFBXQUmR+1Ve0+rWXM7ApLU2w9r+cT PHYOgq7bweTeRG74ZvwW8nh0ZD1haDyGZLDGt4jirwQHtewses/0qM6oODpLxsAlEebi C+3PbG7XPPopGEucqO+5L2amF1IHFqOClxj9NsdZXg5E2lySmBGsQhF4rCRDcfS8M4aE 8Vd3IxsUxLJoBuubXQxEfj9uZLU7RorO2Fobp1eOgiDm6ecMRvw5CXssvuQuHVYTQT5h nWGfhbb8mtYokY+HD0w6i+r5UyWP68OYQ3Tw4FaDELZOTQovydv9dpcLcuwwbW5jU9yp sZMQ== X-Gm-Message-State: ALoCoQkA39QtziYrmIfOgAuQerKo1QhaLbapBNO8KLuOxg8vYiPjUhmQ3UHYxYaMM2RUP2wG7gO0 X-Received: by 10.152.3.168 with SMTP id d8mr1942971lad.0.1413595447671; Fri, 17 Oct 2014 18:24:07 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.87.178 with SMTP id az18ls284676lab.96.gmail; Fri, 17 Oct 2014 18:24:07 -0700 (PDT) X-Received: by 10.112.201.138 with SMTP id ka10mr12441872lbc.20.1413595447461; Fri, 17 Oct 2014 18:24:07 -0700 (PDT) Received: from mail-la0-f46.google.com (mail-la0-f46.google.com. [209.85.215.46]) by mx.google.com with ESMTPS id o5si4382906laj.1.2014.10.17.18.24.07 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 17 Oct 2014 18:24:07 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.46 as permitted sender) client-ip=209.85.215.46; Received: by mail-la0-f46.google.com with SMTP id gi9so1540631lab.5 for ; Fri, 17 Oct 2014 18:24:07 -0700 (PDT) X-Received: by 10.112.51.77 with SMTP id i13mr12359346lbo.12.1413595447132; Fri, 17 Oct 2014 18:24:07 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.84.229 with SMTP id c5csp327914lbz; Fri, 17 Oct 2014 18:24:06 -0700 (PDT) X-Received: by 10.66.220.3 with SMTP id ps3mr12360132pac.8.1413595445669; Fri, 17 Oct 2014 18:24:05 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id pn4si2487741pac.47.2014.10.17.18.24.05 for ; Fri, 17 Oct 2014 18:24:05 -0700 (PDT) Received-SPF: none (google.com: linux-usb-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751401AbaJRBX7 (ORCPT + 3 others); Fri, 17 Oct 2014 21:23:59 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:43430 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750870AbaJRBXu (ORCPT ); Fri, 17 Oct 2014 21:23:50 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id s9I1NfAl011315; Fri, 17 Oct 2014 20:23:41 -0500 Received: from DLEE70.ent.ti.com (dlemailx.itg.ti.com [157.170.170.113]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s9I1Ne3N024989; Fri, 17 Oct 2014 20:23:40 -0500 Received: from dlep32.itg.ti.com (157.170.170.100) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.3.174.1; Fri, 17 Oct 2014 20:23:40 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s9I1Neif031521; Fri, 17 Oct 2014 20:23:40 -0500 From: Felipe Balbi To: Linux USB Mailing List CC: Paul Zimmerman , , , , , Felipe Balbi Subject: [PATCH 2/4] usb: gadget: udc: dummy: do not call usb_gadget_unregister_driver() Date: Fri, 17 Oct 2014 20:23:26 -0500 Message-ID: <1413595408-2011-2-git-send-email-balbi@ti.com> X-Mailer: git-send-email 2.1.0.GIT In-Reply-To: <1413595408-2011-1-git-send-email-balbi@ti.com> References: <1413595408-2011-1-git-send-email-balbi@ti.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: balbi@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.46 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , that call is completely unnecessary because usb_del_gadget_udc() already makes sure the gadget driver is properly unregistered from the UDC. Signed-off-by: Felipe Balbi --- found while reading code drivers/usb/gadget/udc/dummy_hcd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c index 5bffb75..254b9e7 100644 --- a/drivers/usb/gadget/udc/dummy_hcd.c +++ b/drivers/usb/gadget/udc/dummy_hcd.c @@ -2362,7 +2362,6 @@ static void dummy_stop(struct usb_hcd *hcd) dum = hcd_to_dummy_hcd(hcd)->dum; device_remove_file(dummy_dev(hcd_to_dummy_hcd(hcd)), &dev_attr_urbs); - usb_gadget_unregister_driver(dum->driver); dev_info(dummy_dev(hcd_to_dummy_hcd(hcd)), "stopped\n"); }