From patchwork Wed Aug 12 13:20:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oliver Neukum X-Patchwork-Id: 258895 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1293AC433DF for ; Wed, 12 Aug 2020 13:20:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E832C207DA for ; Wed, 12 Aug 2020 13:20:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728018AbgHLNUy (ORCPT ); Wed, 12 Aug 2020 09:20:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:55768 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728004AbgHLNUt (ORCPT ); Wed, 12 Aug 2020 09:20:49 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5960CB76F; Wed, 12 Aug 2020 13:21:10 +0000 (UTC) From: Oliver Neukum To: penguin-kernel@i-love.sakura.ne.jp, bjorn@mork.no, linux-usb@vger.kernel.org Cc: Oliver Neukum Subject: [RFC 5/5] CDC-WDM: remove use of intf->dev after potential disconnect Date: Wed, 12 Aug 2020 15:20:34 +0200 Message-Id: <20200812132034.14363-6-oneukum@suse.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20200812132034.14363-1-oneukum@suse.com> References: <20200812132034.14363-1-oneukum@suse.com> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org After a disconnect intf->dev is not a valid pointer any longer as flush() uses it only for logging purposes logging is not worth it. Remove the dev_err() Reported-by: Tetsuo Handa Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-wdm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c index 6071c9044574..2dcf1fb16f2b 100644 --- a/drivers/usb/class/cdc-wdm.c +++ b/drivers/usb/class/cdc-wdm.c @@ -616,9 +616,6 @@ static int wdm_flush(struct file *file, fl_owner_t id) desc->werr = 0; spin_unlock_irq(&desc->iuspin); - if (rv < 0) - dev_err(&desc->intf->dev, "Error in flush path: %d\n", rv); - return usb_translate_errors(rv); }