diff mbox series

[05/14] USB: serial: keyspan_pda: fix tx-unthrottle use-after-free

Message ID 20201025174600.27896-6-johan@kernel.org
State New
Headers show
Series USB: serial: keyspan_pda: fix up write implementation | expand

Commit Message

Johan Hovold Oct. 25, 2020, 5:45 p.m. UTC
The driver's transmit-unthrottle work was never flushed on disconnect,
something which could lead to the driver port data being freed while the
unthrottle work is still scheduled.

Fix this by cancelling the unthrottle work when shutting down the port.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable@vger.kernel.org
Signed-off-by: Johan Hovold <johan@kernel.org>
 drivers/usb/serial/keyspan_pda.c | 4 ++++
 1 file changed, 4 insertions(+)
diff mbox series


diff --git a/drivers/usb/serial/keyspan_pda.c b/drivers/usb/serial/keyspan_pda.c
index d91180ab5f3b..781b6723379f 100644
--- a/drivers/usb/serial/keyspan_pda.c
+++ b/drivers/usb/serial/keyspan_pda.c
@@ -647,8 +647,12 @@  static int keyspan_pda_open(struct tty_struct *tty,
 static void keyspan_pda_close(struct usb_serial_port *port)
+	struct keyspan_pda_private *priv = usb_get_serial_port_data(port);
+	cancel_work_sync(&priv->unthrottle_work);