From patchwork Fri Dec 11 21:19:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Protsenko X-Patchwork-Id: 341981 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp919931jai; Fri, 11 Dec 2020 13:19:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJzjE7CUn+euLE6geteBfqvbbfL9pckD1BAbfasDFUHLZVUFDXwS10zuwHTUAUlMsOPu6ZPZ X-Received: by 2002:a17:906:fa12:: with SMTP id lo18mr13013648ejb.354.1607721584617; Fri, 11 Dec 2020 13:19:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607721584; cv=none; d=google.com; s=arc-20160816; b=t+yE7RlHOL/O3Qpr75QWkrjB2G7qCRbXO+Hi2DaSF0+Kqckqzg1weJYQM0ihaNgxCE pLrvdABnutzGwtSNYMhodnZfr/wqdQ3YxZ8o2rncRguGP7yOpHEAfb2kcMJL3NxGcxjc jaRNgFWkbbORxVEVl0W0+2EEkOhnUmcxwvmAPKUOIbPyjBpxXs/bd5XtdSaMbRKFRwe+ bVdo8QE381E8xt8YdaPqDMkotC399Ndnrs0vHGD5a+KdPP87oWmFTdh133p7e9I1YgwP B44VZ3BcRtNCuccW3S8GeYZOSZrmtd2+/t+qUp2FB0ZxQWOazh4pKwq1vwB4/5TfK+MU WE1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=f4jyCtqfsT6bFiaWz4C37nQaMqaYNh8RgdovwPFEFag=; b=fzm+x8WnBcf6QPrweG3w8zCUeRdh6V7WX6JyyZ+EcESaf5LSU4mlXdpQjpXPwd7vZx ArRpiorG19YpOOgPxg+hSL2tpDUPiyy/ILovxz7H3ZC59Bii+TLMZj6qcuNP7+CsAqDx krqDa/uCAVQxC1XEOaTyKyTmFHP3NWLHs8nHpqUFv6/sNNNZiaxqjoSfmHnM8dUvyXJW M3wUHKpDI3gjDeHi1zmqQ8zQaL+zOVWWmfxVqiTgRTx4eeQRfVyVDZIzR8hgijhE8Y/A lzWkc3hu2vrXn5QkFvyD+E2uW1Pr3UH5RbTe4UvfcQpjESik1q82brCpa+pz6yzlxJ8F vh7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=L3C22yj6; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gn38si5186169ejc.438.2020.12.11.13.19.44; Fri, 11 Dec 2020 13:19:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=L3C22yj6; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395505AbgLKVTN (ORCPT + 4 others); Fri, 11 Dec 2020 16:19:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405690AbgLKVSy (ORCPT ); Fri, 11 Dec 2020 16:18:54 -0500 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E409C061794 for ; Fri, 11 Dec 2020 13:18:13 -0800 (PST) Received: by mail-lf1-x142.google.com with SMTP id y19so15187445lfa.13 for ; Fri, 11 Dec 2020 13:18:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=f4jyCtqfsT6bFiaWz4C37nQaMqaYNh8RgdovwPFEFag=; b=L3C22yj6e7mZ1ae57EoqyLDdn2C7A5WvAmk6sNlRZpg6sSQUZHSCL8MDBYRH6RamIL 9keusa18auHJbx1LOkaR/b2OUBPql7KMG/JZoaRdLcwZtOzSnvAZc1mAMaF736/50DcK C/3iRmO1bgVi5fvLa8QvITGzz+u7Mw1bIcTyx35XZgivj2DtZM7t2NLOi9brMjl/Prk8 3vzl2qVg2x1voOpXo157jfVsnC0BhUZEV4T5sRqJCu1T49fx1r5WImUlTjShqpYJuL+V in9ZR9GOy/E0fQfIf5E1y446bJ6PffMqN9Ln65O0/zkDYghex69Ee5CzJeiQQ29cdax4 6lTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=f4jyCtqfsT6bFiaWz4C37nQaMqaYNh8RgdovwPFEFag=; b=olmI/k+PvxNVMOj+LxW3HfcY5cZZskaROcAoEluPRtBW2C/XHN8C/GiQa6Hi3qlL8O 9wvsu9bgqteQgL4IuB/kh8XoKIO2rSKLA4hjG9SJjdGBA2ZhV0K1om1ppiO4wBAFOpms xeYV8bKfcCpbzHnF5E3UOUIpP02x58LWN8pu0gA5eLxPu6bsBXyHUXDwMi/yRENOq92W SCa61LBHdXDKKQXZmqFTGkTWo3i0aOrxZb5FuXDS8WdKmt2aRicxumit7pNewCED/+ja 0QXqz+6S+fPrS466KR6mAXGNwqpXqRfCbSkKRTh/CGfu3GC1LDf4VsYqVEzwOphOI/bi WzuA== X-Gm-Message-State: AOAM531BSgSbypVHOk4A8lUVg+is40XzNRPM/KQ91XHJuFDE5pal3E3O rPTonOw3zDj0SliUYpzSpWmw8iSyPlYeJpMbrV4= X-Received: by 2002:a19:8c13:: with SMTP id o19mr5397732lfd.573.1607721491314; Fri, 11 Dec 2020 13:18:11 -0800 (PST) Received: from localhost ([31.134.121.151]) by smtp.gmail.com with ESMTPSA id z26sm808501lja.125.2020.12.11.13.18.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Dec 2020 13:18:10 -0800 (PST) From: Sam Protsenko To: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Felipe Balbi , Greg Kroah-Hartman , John Stultz , Andy Shevchenko Subject: [PATCH v3 1/2] usb: dwc3: drd: Avoid error when extcon is missing Date: Fri, 11 Dec 2020 23:19:15 +0200 Message-Id: <20201211211916.6259-2-semen.protsenko@linaro.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201211211916.6259-1-semen.protsenko@linaro.org> References: <20201211211916.6259-1-semen.protsenko@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org If "port" node is missing in PHY controller node, dwc3_get_extcon() isn't able to find extcon device. This is perfectly fine in case when "usb-role-switch" or OTG is used, but next misleading error message is printed in that case, from of_graph_get_remote_node(): OF: graph: no port node found in /phy@1234abcd Avoid printing that message by checking if port node exists in PHY node before calling of_graph_get_remote_node(). Signed-off-by: Sam Protsenko Cc: Andy Shevchenko --- Changes in v3: - Split patch into two patches: logic diff and style diff drivers/usb/dwc3/drd.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.29.2 Reviewed-by: Andy Shevchenko diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c index 3e1c1aacf002..312a4d060e80 100644 --- a/drivers/usb/dwc3/drd.c +++ b/drivers/usb/dwc3/drd.c @@ -463,7 +463,10 @@ static struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc) } np_phy = of_parse_phandle(dev->of_node, "phys", 0); - np_conn = of_graph_get_remote_node(np_phy, -1, -1); + if (of_graph_is_present(np_phy)) + np_conn = of_graph_get_remote_node(np_phy, -1, -1); + else + np_conn = NULL; if (np_conn) edev = extcon_find_edev_by_node(np_conn);