From patchwork Tue Feb 2 16:45:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benson Leung X-Patchwork-Id: 374933 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AED12C433DB for ; Tue, 2 Feb 2021 16:48:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C97064F7B for ; Tue, 2 Feb 2021 16:48:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235821AbhBBQrz (ORCPT ); Tue, 2 Feb 2021 11:47:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236728AbhBBQqX (ORCPT ); Tue, 2 Feb 2021 11:46:23 -0500 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF07BC06178A for ; Tue, 2 Feb 2021 08:45:43 -0800 (PST) Received: by mail-pg1-x535.google.com with SMTP id z21so15262066pgj.4 for ; Tue, 02 Feb 2021 08:45:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NG3TbeCGSsI4uKAhjtspkiRLO8Ot3EEQlnLM9/MQOtI=; b=DvZVdNb4tNoJkxrI6GGJUhGoeYmhWZk9ILPO+noChdQdNqa9QZY+rSZGTQDi+G+6uC qMAuN743kVuissOUFRVp8+0pnGZnkwOlu5f2c8G138R2GxX2LpPmH90b9EPvCgCWmR92 0QH1jdtSLg2EUtmfSkzHBRwVJe1n8krfRyVCY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NG3TbeCGSsI4uKAhjtspkiRLO8Ot3EEQlnLM9/MQOtI=; b=IH8GY1GhsaeNFjnMSEUi/Sy5FDH4UD+G7wwlDKLLaZtWf+7/w3gJLQFrxF0OlRwkUe 0iFt0TnQl3x8TVNdoVldJkdVdGg5mOHI6/ekqWxbRcB9gTgfBY98IbfieSzr/9uGtVdi GvsrMFXaBJgRuN8OaqLWenrva5NjD+Gu9ayOF9Iib1cpuv0TsC68HfLIAVaG/TEZlqCV qu8BTNVwjicjQgyR78HX5H6jt+8kVwJnK9BvwR3aVhusBSbefqUchxZ4nzsfUxABsMjD u/qK50ivTZA5bKeOdfsq/vvbwyvixuSyklPyJuZuqap9VzTJur+8cUBJWzynlrbnazbX aSFg== X-Gm-Message-State: AOAM531EnNKBPS043J+bAaOkH5Ozpkqpim3kosb5pEVeZe74ALuAYU9E 2lzHGyasfa4W3KohEFeM0VEeWw== X-Google-Smtp-Source: ABdhPJwXN8EQOf2SclCXwjIhK5XPHYrvBZf5JQep8fJfjzv8MM+5zoYXlntyhf4Cgq8nmqycNlCLFw== X-Received: by 2002:aa7:95ba:0:b029:1c0:9d17:b36b with SMTP id a26-20020aa795ba0000b02901c09d17b36bmr22719105pfk.5.1612284343397; Tue, 02 Feb 2021 08:45:43 -0800 (PST) Received: from bleung.mtv.corp.google.com ([2620:15c:202:201:f693:9fff:fef4:fc72]) by smtp.gmail.com with ESMTPSA id q15sm19251101pfk.181.2021.02.02.08.45.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Feb 2021 08:45:42 -0800 (PST) From: Benson Leung To: heikki.krogerus@linux.intel.com, enric.balletbo@collabora.com, pmalani@chromium.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kyletso@google.com, bleung@google.com, bleung@chromium.org Subject: [PATCH v2] platform/chrome: cros_ec_typec: Fix call to typec_partner_set_pd_revision Date: Tue, 2 Feb 2021 08:45:31 -0800 Message-Id: <20210202164531.3982778-1-bleung@chromium.org> X-Mailer: git-send-email 2.30.0.365.g02bc693789-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org typec_partner_set_pd_revision returns void now. Fixes: cefc011f8daf ("platform/chrome: cros_ec_typec: Set Partner PD revision from status") Signed-off-by: Benson Leung --- drivers/platform/chrome/cros_ec_typec.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c index a7778258d0a0..7b93dfd02999 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -842,11 +842,7 @@ static int cros_typec_handle_sop_disc(struct cros_typec_data *typec, int port_nu goto disc_exit; } - ret = typec_partner_set_pd_revision(port->partner, pd_revision); - if (ret < 0) { - dev_err(typec->dev, "Failed to update partner PD revision, port: %d\n", port_num); - goto disc_exit; - } + typec_partner_set_pd_revision(port->partner, pd_revision); memset(sop_disc, 0, EC_PROTO2_MAX_RESPONSE_SIZE); ret = cros_typec_ec_command(typec, 0, EC_CMD_TYPEC_DISCOVERY, &req, sizeof(req),