From patchwork Fri Aug 27 08:21:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rui Miguel Silva X-Patchwork-Id: 503377 Delivered-To: patch@linaro.org Received: by 2002:a02:6f15:0:0:0:0:0 with SMTP id x21csp1039787jab; Fri, 27 Aug 2021 01:21:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNjA4nMvsvukKG1wwGqXIJ5LoMCa8KUPWNDn9ltTiMQ+bcAwnCQ270hbzgnKr04xA4xhly X-Received: by 2002:a17:906:1e97:: with SMTP id e23mr8840286ejj.336.1630052500004; Fri, 27 Aug 2021 01:21:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630052500; cv=none; d=google.com; s=arc-20160816; b=OVs9fc+fDz10cP1a8LILwNd8Djloxzk2Oc/Iw703Ydou1HMKqk1PQIJ7LI2C/fbSQT etagO1Gm2V69eqmAM0r7Gt6g7fGR2T0zXgMTxYtuePdEZhy/1ICt/+HlzmhP4Y9TWSGl axkRRMH7BBdPw+lWOn3qnpyg3YHiL2TvTQMmbbcl61dZDRrXnvCNHBvW4yV8pf5J7Vhu K2AsbKjYHoh3Vl0AcXSt2wZKk5SQprEByNAtPulh0ElBzYjzA5hSeFk1Fg/U80Kh3Lsq VnXdUC89i56nSa9tn6UfBw9ZlYlOClWT6qV8Tu9uqGLKDllrOLS6/9r4SHaiFpv21WSv xyJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4quR9ThIRPYQbS8Ifbodvt1W0T6Q/h5o2e7waNnSENc=; b=t8JYAYueX+THg0rJ+omKaxEFUttTTXQpR1Ir3HDH3hrkQ54Mst1U5qmYb55oxKNOxr 1IXx5Fra/UMKn555seZgzpr2Aj8ygcDay9PqipSnNyvBlQkdXloqoVVzn9kENd8k/Rci ROWeNtLANIUHKlTvGi4tl6aYLFiofJQTCiGEbGo3R5RMHrGZ093PmDCV8E8NJlun0HOI cI2azP3PhySYx/2Do4BjdioFwWj5B5oMuIZTPH3GRh0WPt7CEfDtZN9WJj/BqYKkCi55 Y5ybRkK1gErgMAnCGT0gfdbC3+HVQppOwfPnol4QvjYn1Fl7YYCs+FSQl0WvPxxvK7RB pZ0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FlLhaZow; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n2si6333491edi.195.2021.08.27.01.21.39; Fri, 27 Aug 2021 01:21:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FlLhaZow; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244502AbhH0IW1 (ORCPT + 4 others); Fri, 27 Aug 2021 04:22:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232409AbhH0IW0 (ORCPT ); Fri, 27 Aug 2021 04:22:26 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43BE7C061757 for ; Fri, 27 Aug 2021 01:21:38 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id g135so3309769wme.5 for ; Fri, 27 Aug 2021 01:21:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4quR9ThIRPYQbS8Ifbodvt1W0T6Q/h5o2e7waNnSENc=; b=FlLhaZownM7wlqV75LN/q8RevQYUBQoiCG/qB3gPu7NzIMm5VRLHwORCgbic9v6f9o 0hEmxoGdrcgZHidumlo7S5VbEuWzqPsXCyvk4M5o9s5csuashKfUWMxDhLwTuwM2GHyI ET2/etOlnr8qxNrD/+6aiuyeEIyVucOHCJUVvjYsbZsT9VtNomNO0M/8594yzqg4Gpue iipmWEvniNpKvmb3yVtIH60XkuLoV4ZbgQzWyX5roTACKmUPmOShq0r9aAYwt7ak2r86 HNbXE2JSmxawDCOTqjnRVBvlu839Oa5ftsxdeidk2vLbXB1DLbfDeXzwuhwNSRwPmwJq xj5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4quR9ThIRPYQbS8Ifbodvt1W0T6Q/h5o2e7waNnSENc=; b=gGPZRQCkFbMlWiHhx5v9AbnnNKajQTpOcAxIsgIZcdL8cpWNXWDEhM+dAHKgeatFsz bxuDcarCBAvPZyO1pmBKE66AZNb6XS+mhs0o8vUVpLUta83FFrP1tG/kI4n4xQKooENB wuAtAdh7gmQ/cTf7vxmEnqaiQKwd/QGUDydozU5qgXDh9LBnqmXn0QE7/TCipiVNFRQo L5bTQYZzUouoBOb1s+GLFie2wj05aPT4ZDfrFsmDftj3x99Mv5jcTTAdv3Ws4bwpCdBj yJDGlARw6YvsL794QVmV0XZV5TPBqgRCxlLwW3NylTcqP/WUNRys7E0CUWdWiqdq67oO dxfw== X-Gm-Message-State: AOAM531PjHmlkpVDavAW2f3XxDh5DA3rYcxx2azmjyDzQSA++z84EeVZ 5YDa2tjva0ixRe1UEb9CSqrXmAZ1Bf9HFQ== X-Received: by 2002:a1c:2702:: with SMTP id n2mr7551425wmn.78.1630052496922; Fri, 27 Aug 2021 01:21:36 -0700 (PDT) Received: from arch-thunder.local (a109-49-46-234.cpe.netcabo.pt. [109.49.46.234]) by smtp.gmail.com with ESMTPSA id y1sm5177725wmq.43.2021.08.27.01.21.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Aug 2021 01:21:36 -0700 (PDT) From: Rui Miguel Silva To: Greg Kroah-Hartman , Dietmar Eggemann Cc: linux-usb@vger.kernel.org, Rui Miguel Silva Subject: [PATCH 1/5] usb: isp1760: fix memory pool initialization Date: Fri, 27 Aug 2021 09:21:08 +0100 Message-Id: <20210827082112.4061086-2-rui.silva@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210827082112.4061086-1-rui.silva@linaro.org> References: <20210827082112.4061086-1-rui.silva@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The loops to setup the memory pool were skipping some blocks, that was not visible on the ISP1763 because it has fewer blocks than the ISP1761. But won testing on that IP from the family that would be an issue. Reported-by: Dietmar Eggemann Signed-off-by: Rui Miguel Silva --- drivers/usb/isp1760/isp1760-hcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.33.0 diff --git a/drivers/usb/isp1760/isp1760-hcd.c b/drivers/usb/isp1760/isp1760-hcd.c index bf8ab3fe2e5a..b3a55c5d2155 100644 --- a/drivers/usb/isp1760/isp1760-hcd.c +++ b/drivers/usb/isp1760/isp1760-hcd.c @@ -588,8 +588,8 @@ static void init_memory(struct isp1760_hcd *priv) payload_addr = PAYLOAD_OFFSET; - for (i = 0, curr = 0; i < ARRAY_SIZE(mem->blocks); i++) { - for (j = 0; j < mem->blocks[i]; j++, curr++) { + for (i = 0, curr = 0; i < ARRAY_SIZE(mem->blocks); i++, curr += j) { + for (j = 0; j < mem->blocks[i]; j++) { priv->memory_pool[curr + j].start = payload_addr; priv->memory_pool[curr + j].size = mem->blocks_size[i]; priv->memory_pool[curr + j].free = 1;