mbox series

[v1,0/3] watchdog: intel-mid_wdt: header and code cleanups

Message ID 20240305165306.1366823-1-andriy.shevchenko@linux.intel.com
Headers show
Series watchdog: intel-mid_wdt: header and code cleanups | expand

Message

Andy Shevchenko March 5, 2024, 4:52 p.m. UTC 
A few cleanups against the driver, mostly making an order in the header
inclusions.

Andy Shevchenko (3):
  watchdog: intel-mid_wdt: Remove unused intel-mid.h
  watchdog: intel-mid_wdt: Don't use "proxy" headers
  watchdog: intel-mid_wdt: Get platform data via dev_get_platdata()

 drivers/watchdog/intel-mid_wdt.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

Comments

Guenter Roeck March 5, 2024, 5:57 p.m. UTC | #1 
On Tue, Mar 05, 2024 at 06:52:19PM +0200, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/intel-mid_wdt.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
> index b41c45582aa4..06d5d207a065 100644
> --- a/drivers/watchdog/intel-mid_wdt.c
> +++ b/drivers/watchdog/intel-mid_wdt.c
> @@ -9,11 +9,17 @@
>   *      Contact: David Cohen <david.a.cohen@linux.intel.com>
>   */
>  
> +#include <linux/bitops.h>
> +#include <linux/device.h>
> +#include <linux/errno.h>
>  #include <linux/interrupt.h>
> +#include <linux/math.h>
>  #include <linux/module.h>
> -#include <linux/nmi.h>
> +#include <linux/panic.h>
>  #include <linux/platform_device.h>
> +#include <linux/types.h>
>  #include <linux/watchdog.h>
> +
>  #include <linux/platform_data/intel-mid_wdt.h>
>  
>  #include <asm/intel_scu_ipc.h>
> -- 
> 2.43.0.rc1.1.gbec44491f096
>