| Message ID | cover.dedd9f1159389b0a438076ef5e5a46aded186463.1612457906.git-series.a.fatoum@pengutronix.de |
|---|---|
| Headers | show |
| Series | watchdog: f71808e_wdt: migrate to new kernel API | expand |
Hello, On 04.02.21 18:00, Ahmad Fatoum wrote: > This series migrates the driver to the new kernel watchdog API and > then to the driver model. > > Main feedback from Guenther on v2 was that I need to split it up to > enable review. I have done so by removing the extra refactoring for > now and focused on the functional changes described above. The diff > is now much better readable. > > I tested it on a f81866. Gentle ping. > > v2 -> v3: > https://lore.kernel.org/linux-watchdog/20201020062112.6762-1-a.fatoum@pengutronix.de/ > - factored out identifier renaming again for easier review > - reordered commits > - removed refactoring that can go in later. Focusing now on kernel watchdog > API and platform device/driver migration > - removed platform_device_id and changed code to match by name > > v1 -> v2: > https://lore.kernel.org/linux-watchdog/20200611191750.28096-1-a.fatoum@pengutronix.de/ > - reworked to platform device/driver pair (Guenther) > - squashed identifier renaming into the patches that touch > the respective lines anyway > - fixed checkpatch.pl nitpicks (Guenther) > - fixed locally used variable declared without static (0-day) > - fixed unneded line break due to old line limit (Guenther) > - renamed struct fintek_wdog_data to struct fintek_wdt > > Ahmad Fatoum (3): > watchdog: f71808e_wdt: rename variant-independent identifiers appropriately > watchdog: f71808e_wdt: migrate to new kernel watchdog API > watchdog: f71808e_wdt: refactor to platform device/driver pair > > drivers/watchdog/Kconfig | 1 +- > drivers/watchdog/f71808e_wdt.c | 450 +++++++--------------------------- > 2 files changed, 100 insertions(+), 351 deletions(-) > > base-commit: 1048ba83fb1c00cd24172e23e8263972f6b5d9ac > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Hello, On 16.03.21 18:47, Ahmad Fatoum wrote: > On 04.02.21 18:00, Ahmad Fatoum wrote: >> This series migrates the driver to the new kernel watchdog API and >> then to the driver model. >> >> Main feedback from Guenther on v2 was that I need to split it up to >> enable review. I have done so by removing the extra refactoring for >> now and focused on the functional changes described above. The diff >> is now much better readable. >> >> I tested it on a f81866. > > Gentle ping. Any news? Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
This series migrates the driver to the new kernel watchdog API and then to the driver model. Main feedback from Guenther on v2 was that I need to split it up to enable review. I have done so by removing the extra refactoring for now and focused on the functional changes described above. The diff is now much better readable. I tested it on a f81866. v2 -> v3: https://lore.kernel.org/linux-watchdog/20201020062112.6762-1-a.fatoum@pengutronix.de/ - factored out identifier renaming again for easier review - reordered commits - removed refactoring that can go in later. Focusing now on kernel watchdog API and platform device/driver migration - removed platform_device_id and changed code to match by name v1 -> v2: https://lore.kernel.org/linux-watchdog/20200611191750.28096-1-a.fatoum@pengutronix.de/ - reworked to platform device/driver pair (Guenther) - squashed identifier renaming into the patches that touch the respective lines anyway - fixed checkpatch.pl nitpicks (Guenther) - fixed locally used variable declared without static (0-day) - fixed unneded line break due to old line limit (Guenther) - renamed struct fintek_wdog_data to struct fintek_wdt Ahmad Fatoum (3): watchdog: f71808e_wdt: rename variant-independent identifiers appropriately watchdog: f71808e_wdt: migrate to new kernel watchdog API watchdog: f71808e_wdt: refactor to platform device/driver pair drivers/watchdog/Kconfig | 1 +- drivers/watchdog/f71808e_wdt.c | 450 +++++++--------------------------- 2 files changed, 100 insertions(+), 351 deletions(-) base-commit: 1048ba83fb1c00cd24172e23e8263972f6b5d9ac