From patchwork Tue Sep 8 18:24:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 249319 Delivered-To: patch@linaro.org Received: by 2002:a92:5b9c:0:0:0:0:0 with SMTP id c28csp4791393ilg; Tue, 8 Sep 2020 11:24:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw57r1rgMI/pRxAWScaQT6BxG6lpyOOZnBNqqRc6D/9EGDz8B5XWBsAWd8e4FEGKGLn7ZLj X-Received: by 2002:a6b:7017:: with SMTP id l23mr146127ioc.120.1599589443266; Tue, 08 Sep 2020 11:24:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599589443; cv=none; d=google.com; s=arc-20160816; b=jMgLVn94hoinmS++bplUEpzqWik/EBX2PiXQw0gWEvY9OHmOKWEz34PO2bJGxb3Zjh xMy4+EDO/LiOtg4UDQiJQIchOSYcgBw5d9x3lPxGbOzOWXitEuNmUgUGAnlVfDiCCpqU DpyWcY0a9cRTrJZBlHLE4LvRP5/a1QegoKsCWWfdlLmf2MkZeIiQtMrQJJozcuTyi6MG bHxRm3AIolSaNNJDDmtx/Yh0rJ4CgM3XfiK9qH9w1uZxlPGebeNR7yTz2y4LgS1toMNF YfCmWiDnAz0grbK05mqxXdYR/4P8Nz2RQcPj7gLTy/bLoeBFNnydq29GS/aceX3ta4lY rZbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:message-id:date:subject:to:from :dkim-signature:dkim-signature; bh=XTJag35GXXyIjaCCcGIegLaIxlB48VdOFELGo2NzdBI=; b=GUBSH8KJOmuuN8FU76imCNfaIGU9XavsPHuK0nj8+LrnFVrE1ygaWmCK73zPZIv/+c 3foYP0aABjycW1fxh3Qug3NDSFtMHMN+GaBn1b3sMo4MTMg93383evZJDp9odogi7/s0 bYeFquoFJuNxZToiHXYUnYrVJSUVvUlkYOdwNpwf5dyFUz+jQklFwSwMLwu2xMv6lVzM 2cpChTTrxEDxiZp+P0sBj6i3gHiE2oshTNdgMaUQHPNGGTa6zL9mPLVk/QpwIyOKhQmB LprJrXA++vlnVn+VJNI+v7c7G44JqK8gptQ26AM+m8cR7RhEjUhZAQGgwc8jqKG1sDUI ViKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b="XlxQju/f"; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=HIshVomC; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id b28si210043ilg.88.2020.09.08.11.24.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 11:24:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) client-ip=2001:8b0:10b:1231::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b="XlxQju/f"; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=HIshVomC; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=XTJag35GXXyIjaCCcGIegLaIxlB48VdOFELGo2NzdBI=; b=XlxQju/f8Muop7ho1qYXtILmki /P9CZdVmyEiMdjzpYHE3rre1Zbz+CcjeMv4XFcdbXGi/bXbmOXorp7SWn0hgGamgzoUWn35EJSD4L p5nlI/ZelWxeTfokcDyyVZdjQl1KsDpy/ZnXOABgg79kaslUdEpdzJkVv75Qn4xy8lcn2Zcv8qpqV /QAha4HoVDDwpU5+e1Gb4spyAbq14sSeGkgIJzpjZmuzWtZnLEExREp8qHx9vTGao7AWoXDs5omp4 sZhuJM2GetWQPC+O+CEQXVxdCxhE/bH0NhVYl9NyPsE1ptekquHjMiGf5j/kPIVYbGBxmh+pAGRXr goT8bdjA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFiHe-00051p-P4; Tue, 08 Sep 2020 18:23:58 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFiHX-0004wo-Hq for wcn36xx@lists.infradead.org; Tue, 08 Sep 2020 18:23:55 +0000 Received: by mail-wr1-x444.google.com with SMTP id o5so178829wrn.13 for ; Tue, 08 Sep 2020 11:23:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3s4aFu9WOgZEB/ykUx7rMmQlbdfp0yRUuRJCuSjvOTs=; b=HIshVomCeQ2qVybS7PRZgvbOcJHLz1fcBG5oPMJd2ewfPSHVR4DSGi6oi3ZEJ/WSx9 8eTKjcODDPYRTx/YLcIs4ddVegPmkgWBANuhvOT41zDaWpzHEQ//pj3counFxrykCdBd 27tWbb9nNLx6pzpE+v/i0tlaH8GFDODGyCT10ID2XrF8F7jyr43r4rz6A+lOXEy2nQTs Z6uyubcIIj3yD6iy6ejVG7NDi0Ytc6CLK0hL2tvS4aLiNbmEAA5vI9dfH3xZePnCDcEm /KkCh4cQhferVWpotjUOFROz9eS7ydDzdczPB2MO8ftonbQihGfoCXANM8i6ddb2nGPp K5+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3s4aFu9WOgZEB/ykUx7rMmQlbdfp0yRUuRJCuSjvOTs=; b=L21YPjO6kCg3rUAIGzhIp2VZZzBzcgemcjWil41sJj77qd7a9qAMPS9TKTzB5IxsiO f/AU0T8Dy/03Gh3Rx6iP3/IXiRp0aEAdKnEQFa0hXYHnvvuKtrix1z2zFO/nRBLmbPFL H3TwMH19ZB5uBDXcy++IZLWH2pn/IpEs4sMtkUplJU++L+f/+JsaRRhcVFUD8TofE4mX t1NdGWf5lFpa9Wo2+28Utd1IjFoC6U0x+Lb7D0TsIsVcKR4dk4sjHUrT5GYX1uBtfX5q SHsgTOtjr7+ay1F4JCnBt8FWZJjw3Iy5eXqfGwS2hvQuAuByQ/YYCo5dHNxlu0cu5WHm eGTQ== X-Gm-Message-State: AOAM533H9X7SOZoNdEzdRjnmmO9TRvRA6HwKj7VIkTKS/8xBwc17B+b9 2XT/a1oRDKJi2Jdni7JGXPHJVw== X-Received: by 2002:a5d:4603:: with SMTP id t3mr872500wrq.424.1599589430498; Tue, 08 Sep 2020 11:23:50 -0700 (PDT) Received: from localhost.localdomain ([176.61.57.127]) by smtp.gmail.com with ESMTPSA id k8sm362516wrl.42.2020.09.08.11.23.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 11:23:50 -0700 (PDT) From: Bryan O'Donoghue To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Subject: [PATCH v3 0/7] wcn36xx: Add a set of helpers to enable VHT parameter passing Date: Tue, 8 Sep 2020 19:24:30 +0100 Message-Id: <20200908182437.2870281-1-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_142351_627405_518C54E6 X-CRM114-Status: GOOD ( 15.98 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bryan.odonoghue@linaro.org, shawn.guo@linaro.org, loic.poulain@linaro.org Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org This series is two in a set of seven to add support for wcn3680 at 802.11ac data-rates. V3: - Enables MU-MIMO bits in wcn36xx_smd_set_sta_vht_params() - Adds a set of helper functions. In the previous set these unused declarations would cause a warning during compile because they were declared static with the intention to add code later on to use them. To resolve that, I do not declare the functions static. Static declaration is done in a later patch after the functions have been used. - There are two good reasons for this: 1. Granularity. I think its important and useful to have a patch per function that clearly sets out what it does and why. 2. Patch size. Declaring seven functions at the time of their first use is not good practice. I think maintaining patch granularity is a good enough reason to not squash these commits down. It is pretty trivial to declare the functions static later on without generating compile warnings in the interregnum. V2: This set makes a series of modifications to enable passing of an extended V1 data-structure to the firmware. A series of of helper functions are added to facilitate the setup. The final step in the process is enabling the extended data-structure parameter passing for the wcn3680 only. Only a firmware that is capable of 80211.ac will accept the larger V1 messages and only after explicitly enabling the DOT11AC firmware feature bit. - No functional difference from V1 for these patches Breaking into smaller chunks to enable easier review/merging V1: https://lore.kernel.org/linux-wireless/87eensldhi.fsf@codeaurora.org/T/#t Bryan O'Donoghue (7): wcn36xx: Add wcn36xx_set_default_rates_v1 wcn36xx: Add wcn36xx_smd_set_sta_default_vht_params() wcn36xx: Add wcn36xx_smd_set_sta_default_ht_ldpc_params() wcn36xx: Add wcn36xx_smd_set_sta_vht_params() wcn36xx: Add wcn36xx_smd_set_sta_ht_ldpc_params() wcn36xx: Add wcn36xx_smd_set_bss_vht_params() wcn36xx: Add wrapper function wcn36xx_smd_set_sta_params_v1() drivers/net/wireless/ath/wcn36xx/main.c | 8 ++ drivers/net/wireless/ath/wcn36xx/smd.c | 88 ++++++++++++++++++++++ drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 1 + 3 files changed, 97 insertions(+) -- 2.27.0 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx